[U-Boot] [PATCH][v2] driver/nand: Update SRAM initialize logic for IFC.

2014-06-11 Thread Prabhakar Kushwaha
IFC controller v1.1.0 requires internal SRAM initialize by reading NAND flash. Higher controller versions have provided "SRAM init" bit in NCFGR register space. update SRAM initialize logic to reflect the same. Also print error message in case of Page read error. Signed-off-by: Prabhakar Kushwah

[U-Boot] [PATCH][v2] driver/nand: Add support of 16K SRAM for IFC 2.0

2014-06-11 Thread Prabhakar Kushwaha
Internal SRAM has been incresed from 8KB to 16KB for IFC cotroller ver 2.0. Update the page offset calculation logic to support the same. Signed-off-by: Prabhakar Kushwaha --- Changes for v2: rebased the patch drivers/mtd/nand/fsl_ifc_nand.c | 25 + 1 file changed, 25

Re: [U-Boot] Refactoring of U-Boot directory structure

2014-06-11 Thread Masahiro Yamada
Hi Wolfgang, On Thu, 12 Jun 2014 06:41:45 +0200 Wolfgang Denk wrote: > Dear Masahiro, > > In message <20140612131050.963a.aa925...@jp.panasonic.com> you wrote: > > > > [1] Do not split the similar SoC family to various directories > > > > at91 SoC directory exists under arm920t, arm926ejs, a

Re: [U-Boot] [PATCH] fs/fat: add a parameter: allow_whole_dev to fat_register_device()

2014-06-11 Thread Wolfgang Denk
Dear Josh Wu, In message <1402552643-13297-1-git-send-email-josh...@atmel.com> you wrote: > For SPL in FAT and envrionment load/save in FAT, to support no partition > table device (whole device is FAT partition). We need specify the partition > number as 0. Sorry, I cannot parse this. What exact

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > - This buffering of data in this patch is intended to solve a specific > > problem that could be avoided by more clever test scripts. Instead > > of just dumping an endless stream of characters to the serial > > console independent of what U-Boot i

[U-Boot] [PATCH] arm, calimain: Add CONFIG_SYS_GENERIC_BOARD

2014-06-11 Thread Christian Riesch
Signed-off-by: Christian Riesch --- include/configs/calimain.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/configs/calimain.h b/include/configs/calimain.h index febee45..b27f973 100644 --- a/include/configs/calimain.h +++ b/include/configs/calimain.h @@ -1,5 +

[U-Boot] [PATCH] fs/fat: add a parameter: allow_whole_dev to fat_register_device()

2014-06-11 Thread Josh Wu
For SPL in FAT and envrionment load/save in FAT, to support no partition table device (whole device is FAT partition). We need specify the partition number as 0. But in FAT SPL and environment case, when we specify the partition number as 1, it is reasonable to support the device has no partition

[U-Boot] [PATCH] .gitignore: drop include/asm/proc from ignore pattern

2014-06-11 Thread Masahiro Yamada
Commit 7d89982b stopped creating symbolic link arch/${arch}/include/asm/proc. arch/.gitignore should be updated. Signed-off-by: Masahiro Yamada Cc: Vasili Galka --- Vasili, Commit 7d89982b is a very good clean-up. Thanks!! arch/.gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Simon Glass
Hi Wolfgang, On 12 June 2014 01:03, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: >> >> > Hm... ignoring it would mean there is no way to interrupt long running >> > commands. I'm not sure if this is actually an improvement. >> > Eventually we should try to define the wante

[U-Boot] [PATCH v6 13/15] tegra: Enable driver model

2014-06-11 Thread Simon Glass
Enable driver model for Tegra boards. Signed-off-by: Simon Glass Acked-by: Stephen Warren --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Enable dm command in this patch instead of the next Changes in v2: - Split out a separate patch to enable driver model for

[U-Boot] [PATCH v6 09/15] dm: Cast away the const-ness of the global_data pointer

2014-06-11 Thread Simon Glass
In a very few cases we need to adjust the driver model root device, such as when setting it up at initialisation. Add a macro to make this easier. Signed-off-by: Simon Glass --- Changes in v6: - Make DM_ROOT and DM_UCLASS_ROOT simple defines (and rename them) Changes in v5: None Changes in v4:

[U-Boot] [PATCH v6 11/15] dm: Fix printf() strings in the 'dm' command

2014-06-11 Thread Simon Glass
The values here are int, but the map_to_sysmem() call can return a long. Add a cast to deal with this. Signed-off-by: Simon Glass --- Changes in v6: - Use ulong instead of uint for printing addresses Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Add new patch to f

[U-Boot] [PATCH v6 14/15] dm: Tidy up four minor code nits

2014-06-11 Thread Simon Glass
There is a spelling mistake and two functions are missing comments altogether. Also the flags declaration is correct, but doesn't follow style. Finally, the uclass_get_device() function has some errors in its documentation. Fix these problems. Signed-off-by: Simon Glass Acked-by: Marek Vasut -

[U-Boot] [PATCH v6 04/15] Makefile: Support include files for .dts files

2014-06-11 Thread Simon Glass
Linux supports this, and if we are to have compatible device tree files, U-Boot should also. Avoid giving the device tree files access to U-Boot's include/ directory. Only include/dt-bindings is accessible. Signed-off-by: Simon Glass Acked-by: Stephen Warren Reviewed-by: Masahiro Yamada ---

[U-Boot] [PATCH v6 12/15] tegra: dts: Bring in GPIO bindings from linux

2014-06-11 Thread Simon Glass
These files are taken from Linux 3.14. Signed-off-by: Simon Glass Acked-by: Stephen Warren --- Changes in v6: None Changes in v5: None Changes in v4: - Remove 64-bit addresses which are not used in U-Boot Changes in v3: - Bring in GPIO bindings for tegra{30,114,124} also Changes in v2: - Add

[U-Boot] [PATCH v6 10/15] dm: Allow driver model tests only for sandbox

2014-06-11 Thread Simon Glass
The GPIO tests require the sandbox GPIO driver, so cannot be run on other platforms. Similarly for the 'dm test' command. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Add new patch to allow driver model tests only

[U-Boot] [PATCH v6 15/15] dm: Expand and improve the device lifecycle docs

2014-06-11 Thread Simon Glass
The lifecycle of a device is an important part of driver model. Add to the existing documentation and clarify it. Reported-by: Jon Loeliger Signed-off-by: Simon Glass --- Thanks for Jon Loeliger for helping with the text and suggesting improvements. (Jon please comment/adjust to help clarify

[U-Boot] [PATCH v6 01/15] Add an I/O tracing feature

2014-06-11 Thread Simon Glass
When debugging drivers it is useful to see what I/O accesses were done and in what order. Even if the individual accesses are of little interest it can be useful to verify that the access pattern is consistent each time an operation is performed. In this case a checksum can be used to characterise

[U-Boot] [PATCH v6 02/15] arm: Support iotrace feature

2014-06-11 Thread Simon Glass
Support the iotrace feature for ARM, when enabled. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Add a new patch to enable iotrace for arm arch/arm/include/asm/io.h | 3 +++ 1 file changed, 3 insertions(+) diff

[U-Boot] [PATCH v6 08/15] dm: Add missing header files in lists and root

2014-06-11 Thread Simon Glass
These files don't compile in some architectures. Fix it by adding the missing headers. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Add new patch to add missing header files in lists and root drivers/core/lists.

[U-Boot] [PATCH v6 07/15] dm: Use case-insensitive comparison for GPIO banks

2014-06-11 Thread Simon Glass
We want 'N0' and 'n0' to mean the same thing, so ensure that case is not considered when naming GPIO banks. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Add new patch to use case-insensitive comparison for GPIO ba

[U-Boot] [PATCH v6 05/15] dm: Rename struct device_id to udevice_id

2014-06-11 Thread Simon Glass
It is best to avoid having any occurence of 'struct device' in driver model, so rename to achieve this. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: - Add new patch to rename struct device_id to udevice_id Changes in v3: None Changes in v2: None doc/dr

[U-Boot] [PATCH v6 06/15] dm: Update README to encourage conversion to driver model

2014-06-11 Thread Simon Glass
Add a note to encourage people to convert drivers to use driver model. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Update README to encourage conversion to driver model README | 5 + 1 file changed, 5 inser

[U-Boot] [PATCH v6 03/15] sandbox: Support iotrace feature

2014-06-11 Thread Simon Glass
Support the iotrace feature for sandbox, and enable it, using some dummy I/O access methods. Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: None Changes in v4: - Correct typo in CONFIG_CMD_IOTRACE Changes in v3: None Changes in v2: - Add a new patch to enable iotrace for sand

[U-Boot] [PATCH v6 0/15] Collected driver model bug-fixes and docs

2014-06-11 Thread Simon Glass
This series collects some of the patches from the Tegra GPIO conversion to driver model. That work is still in progress, but the bug fixes and iotracing feature should go into this release I think. Also the documentation improvements may as well follow since the existings docs are proven inadequate

[U-Boot] [PATCH] patman: Only apply patches when we know the original HEAD

2014-06-11 Thread Simon Glass
When patman applies the patches it checks out a new branch, uses 'git am' to apply the patches one by one, and then tries to go back to the old branch. If you try this when the branch is 'undefined', this doesn't work as patman cannot restore the correct branch after applying the patches. It seems

[U-Boot] [PATCH] driver/nand: Add support of 16K SRAM for IFC 2.0

2014-06-11 Thread Prabhakar Kushwaha
Internal SRAM has been incresed from 8KB to 16KB for IFC cotroller ver 2.0. Update the page offset calculation logic to support the same. Signed-off-by: Prabhakar Kushwaha --- drivers/mtd/nand/fsl_ifc_nand.c | 25 + 1 file changed, 25 insertions(+) diff --git a/driver

Re: [U-Boot] [Patman Bug Report] Patman breaks git-log during git-rebase

2014-06-11 Thread Simon Glass
Hi Masahiro, On 4 June 2014 04:32, Masahiro Yamada wrote: > Hi Simon, > > On Mon, 2 Jun 2014 20:28:48 -0600 > Simon Glass wrote: > >> Hi Masahiro, >> >> On 2 June 2014 01:44, Masahiro Yamada wrote: >> > Hi Simon, >> > >> > I found an odd behavior of Patman. >> > >> > If I run Patman during "git

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > Hm... ignoring it would mean there is no way to interrupt long running > > commands. I'm not sure if this is actually an improvement. > > Eventually we should try to define the wanted behaviour first. > > My initial feelingis that ^C should terminate a

Re: [U-Boot] Driver Model and DTS Parsing

2014-06-11 Thread Simon Glass
Hi Stephen, On 3 June 2014 12:33, Stephen Warren wrote: > On 06/03/2014 10:04 AM, Simon Glass wrote: >> +Stephen > > I don't think there's anything actionable for me in this email, although > I guess I'll chime in on a couple of points: > > I agree that the current way U-Boot parses DT is complet

Re: [U-Boot] [PATCH v3 07/14] fdt: Add DEV_TREE_BIN option to specify a device tree binary file

2014-06-11 Thread Simon Glass
Hi Tom, On 11 June 2014 18:18, Tom Rini wrote: [snip] > ... as a follow up (I want to get this in already). Thanks! I'll send a new patch to update this when I finish testing the rebase you asked for. Regards, Simon ___ U-Boot mailing list U-Boot@li

Re: [U-Boot] Refactoring of U-Boot directory structure

2014-06-11 Thread Wolfgang Denk
Dear Masahiro, In message <20140612131050.963a.aa925...@jp.panasonic.com> you wrote: > > [1] Do not split the similar SoC family to various directories > > at91 SoC directory exists under arm920t, arm926ejs, armv7 directory. To me this actually makes sense, as they are using different CPU core

Re: [U-Boot] [PATCH] x86: Enable 32-bit build using x86_64 multilib toolchain

2014-06-11 Thread Simon Glass
On 10 June 2014 09:14, Vasili Galka wrote: > Until now building the x86 arch boards required 32-bit toolchain. As > many x86_64 toolchains come with 32-bit support (multilib) that's a > good idea to enable build with such toolchains. > > The change required was to specify the usage of 32-bit expli

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Simon Glass
Hi Wolfgang, On 10 June 2014 01:08, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: >> >> > 1) Looking at sandbox only, we should provide an implementation of >> >ctrlc() that does not consume characters from stdin - I thinkwe >> >should rather be able to react on sign

[U-Boot] [PATCH] arm:board:h2200: Add CONFIG_SYS_GENERIC_BOARD

2014-06-11 Thread Lukasz Dalek
Signed-off-by: Lukasz Dalek --- include/configs/h2200.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/h2200.h b/include/configs/h2200.h index d026484..5d0b85e 100644 --- a/include/configs/h2200.h +++ b/include/configs/h2200.h @@ -12,6 +12,7 @@ #define MACH_TYPE_H2200

Re: [U-Boot] [PATCH v2] sandbox: change local_irq_save() to macro

2014-06-11 Thread Simon Glass
On 11 June 2014 23:26, Masahiro Yamada wrote: > local_irq_save() should be a macro, not a function > because local_irq_save() saves flag to the given argument. > > GCC is silent about this issue, but Clang warns: > > In file included from lib/asm-offsets.c:15: > In file included from include/commo

Re: [U-Boot] [PATCH V2] sandbox: restore ability to access host fs through standard commands

2014-06-11 Thread Simon Glass
Hi Stephen, On 11 June 2014 12:20, Stephen Warren wrote: > From: Stephen Warren > > Commit 95fac6ab4589 "sandbox: Use os functions to read host device tree" > removed the ability for get_device_and_partition() to handle the "host" > device type, and redirect accesses to it to the host filesystem

Re: [U-Boot] [PATCH V2] sandbox: terminate os_dirent_ls() result list

2014-06-11 Thread Simon Glass
On 11 June 2014 12:26, Stephen Warren wrote: > From: Stephen Warren > > Each node in the linked-list that os_dirent_ls() returns has its next > pointer set only when the next node is created. For the last node in the > list, there is no next node, so this never happens, and the next pointer > is

[U-Boot] Refactoring of U-Boot directory structure

2014-06-11 Thread Masahiro Yamada
Hi. In U-Boot, the directory structure under arch/ is like this arch/${ARCH}/cpu/${CPU}/${SOC} Exception: - ${CPU} is missing for some architectures such as blackfin, sandbox, etc. - There are many boards without ${SOC} My question is, ${SOC} should always depend on ${CPU} ? I think

Re: [U-Boot] [PATCH 1/4] Reactivate the tracing feature

2014-06-11 Thread Simon Glass
Hi Masahiro, On 11 June 2014 23:42, Simon Glass wrote: > Hi Masahiro, > > Yes I should remove this otherwise it will at best bloat the code for > SPL. I think it is probably best just to revert that part of the > Makefile. Although actually I'm not sure how to have different flags for everything

[U-Boot] [PATCH] driver/nand:Define MAX_BANKS same as SoC defined for IFC

2014-06-11 Thread Prabhakar Kushwaha
The number of chip select used by IFC controller vary from one SoC to other. For eg. P1010 has 4, T4240 has 8. Update MAX_BANKS same as SoC defined Signed-off-by: Prabhakar Kushwaha --- drivers/mtd/nand/fsl_ifc_nand.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/d

[U-Boot] [PATCH] driver/nand: Update SRAM initialize logic for IFC.

2014-06-11 Thread Prabhakar Kushwaha
IFC controller v1.1.0 requires internal SRAM initialize by reading NAND flash. Higher controller versions have provided "SRAM init" bit in NCFGR register space. update SRAM initialize logic to reflect the same. Also print error message in case of Page read error. Signed-off-by: Prabhakar Kushwah

Re: [U-Boot] [PATCH 1/4] Reactivate the tracing feature

2014-06-11 Thread Simon Glass
Hi Masahiro, On 10 June 2014 00:47, Masahiro Yamada wrote: > Hi Simon, > > > On Thu, 5 Jun 2014 12:27:49 -0600 > Simon Glass wrote: > >> This was lost sometime in the Kbuild conversion. Add it back. > > Not lost. > It was moved to examples/Makefile. > > > Prior to Kbuild conversion, config.mk

Re: [U-Boot] [PATCH v4 11/15] dm: Fix printf() strings in the 'dm' command

2014-06-11 Thread Simon Glass
Hi Andre, On 8 June 2014 18:46, Andre Renaud wrote: > On 7 June 2014 07:13, Simon Glass wrote: >> The values here are int, but the map_to_sysmem() call can return a long. >> Add a cast to deal with this. > ... >> - printf("%s- %s @ %08x", buf, in->name, map_to_sysmem(in)); >> + print

Re: [U-Boot] [PATCH v4 09/15] dm: Cast away the const-ness of the global_data pointer

2014-06-11 Thread Simon Glass
Hi Marek, On 11 June 2014 23:26, Simon Glass wrote: > Hi Marek, > > > On 8 June 2014 01:00, Marek Vasut wrote: >> On Friday, June 06, 2014 at 09:13:26 PM, Simon Glass wrote: >>> In a very few cases we need to adjust the driver model root device, such as >>> when setting it up at initialisation.

Re: [U-Boot] [PATCH v4 09/15] dm: Cast away the const-ness of the global_data pointer

2014-06-11 Thread Simon Glass
Hi Marek, On 8 June 2014 01:00, Marek Vasut wrote: > On Friday, June 06, 2014 at 09:13:26 PM, Simon Glass wrote: >> In a very few cases we need to adjust the driver model root device, such as >> when setting it up at initialisation. Add a macro to make this easier. >> >> Signed-off-by: Simon Gla

[U-Boot] [PATCH v2] sandbox: change local_irq_save() to macro

2014-06-11 Thread Masahiro Yamada
local_irq_save() should be a macro, not a function because local_irq_save() saves flag to the given argument. GCC is silent about this issue, but Clang warns: In file included from lib/asm-offsets.c:15: In file included from include/common.h:20: In file included from include/linux/bitops.h:110: a

[U-Boot] [PATCH] sandbox: change local_irq_save() to macro

2014-06-11 Thread Masahiro Yamada
local_irq_save() should be a macro, not a function because local_irq_save() saves flag to the given argument. GCC is silent about this issue, but Clang warns: In file included from lib/asm-offsets.c:15: In file included from include/common.h:20: In file included from include/linux/bitops.h:110: a

Re: [U-Boot] [PATCH V2] sandbox: restore ability to access host fs through standard commands

2014-06-11 Thread Josh Wu
Hi, Stephen On 6/12/2014 12:20 AM, Stephen Warren wrote: From: Stephen Warren Commit 95fac6ab4589 "sandbox: Use os functions to read host device tree" removed the ability for get_device_and_partition() to handle the "host" device type, and redirect accesses to it to the host filesystem. This b

Re: [U-Boot] [PATCH v5 15/15] dm: Expand and improve the device lifecycle docs

2014-06-11 Thread Simon Glass
Hi Jon, On 11 June 2014 10:19, Jon Loeliger wrote: > On Tue, Jun 10, 2014 at 6:53 PM, Simon Glass wrote: >> The lifecycle of a device is an important part of driver model. Add to the >> existing documentation and clarify it. >> >> Reported-by: Jon Loeliger >> >> Signed-off-by: Simon Glass >> -

Re: [U-Boot] [PATCH] mx6: drop ARM errata 742230

2014-06-11 Thread Nitin Garg
Acked-by: Nitin Garg Regards, Nitin Garg -Original Message- From: Shawn Guo [mailto:shawn@freescale.com] Sent: Wednesday, June 11, 2014 3:53 AM To: u-boot@lists.denx.de Cc: Garg Nitin-B37173; Stefano Babic; Guo Shawn-R65073 Subject: [PATCH] mx6: drop ARM errata 742230 Commit e9fd66

Re: [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile

2014-06-11 Thread Joe Hershberger
On Wed, Jun 11, 2014 at 10:42 AM, Tom Rini wrote: > > On Mon, Jun 09, 2014 at 06:58:46AM +0900, Nobuhiro Iwamatsu wrote: > > Hi, Tom. > > > > 2014-06-06 22:37 GMT+09:00 Tom Rini : > > > On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iwamatsu wrote: > > > > > >> ping. > > >> > > >> 2014-01-23 7

Re: [U-Boot] Pull request: u-boot-sh/rmobile into u-boot-arm/master

2014-06-11 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. 2014-06-10 17:46 GMT+09:00 Albert ARIBAUD : > Hi Nobuhiro, > > On Tue, 10 Jun 2014 16:58:39 +0900, Nobuhiro Iwamatsu > wrote: > >> Dear Albert Aribaud, >> >> Please pull u-boot-sh/rmobile into u-boot-arm/master. >> >> The following changes since commit 0a26e1d6c394aac

Re: [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile

2014-06-11 Thread Nobuhiro Iwamatsu
Hi, 2014-06-12 9:30 GMT+09:00 Joe Hershberger : > > On Wed, Jun 11, 2014 at 10:42 AM, Tom Rini wrote: >> >> On Mon, Jun 09, 2014 at 06:58:46AM +0900, Nobuhiro Iwamatsu wrote: >> > Hi, Tom. >> > >> > 2014-06-06 22:37 GMT+09:00 Tom Rini : >> > > On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iw

Re: [U-Boot] unsigned int for gpio

2014-06-11 Thread Simon Glass
Hi Jeroen, On 11 June 2014 15:37, Jeroen Hofstee wrote: > Hello Simon, > > in commit 95a260a9 > > > dm: Enable gpio command to support driver model > > Now that named GPIO banks are supported, along with a way of obtaining > the status of a GPIO (input or output), we can provide an enhanced > GPI

[U-Boot] [PATCH] usb: xhci: (likely) fix bracket in if condition

2014-06-11 Thread Jeroen Hofstee
Because of the brackets the & and && is evaluated before the comparison. This is likely not the intention. Change it to test the first and second condition to both be true. cc: Marek Vasut Signed-off-by: Jeroen Hofstee --- fixes a warning: drivers/usb/host/xhci.c:647:32: warning: comparison o

Re: [U-Boot] [PATCH v3 07/14] fdt: Add DEV_TREE_BIN option to specify a device tree binary file

2014-06-11 Thread Simon Glass
Hi Masahiro, On 9 June 2014 23:59, Masahiro Yamada wrote: > Hi Simon, > > > On Mon, 2 Jun 2014 22:04:50 -0600 > Simon Glass wrote: > >> In some cases, an externally-built device tree binary is required to be >> attached to U-Boot. An example is when using image signing, since in that >> case th

Re: [U-Boot] common/xyzModem.c: move empty statements to newline

2014-06-11 Thread Tom Rini
On Wed, Jun 11, 2014 at 01:04:42AM +0200, Jeroen Hofstee wrote: > To prevent a warning for clang the loop without a body > is made more clear by moving it to a line of its own. > This prevents a clang warning. > > cc: sba...@denx.de > Signed-off-by: Jeroen Hofstee Applied to u-boot/master, than

Re: [U-Boot] common/cli_hush.c: remove unnecessary double braces

2014-06-11 Thread Tom Rini
On Wed, Jun 11, 2014 at 12:28:47AM +0200, Jeroen Hofstee wrote: > Clang interpretes an if condition like "if ((a = b) == NULL) > as it tries to assign a value in a statement. Hence if you do > "if ((something)) it warns you that you might be confused. > Hence drop the double braces for plane if s

Re: [U-Boot] board:keymile: remove unnecessary double braces

2014-06-11 Thread Tom Rini
On Wed, Jun 11, 2014 at 12:34:39AM +0200, Jeroen Hofstee wrote: > Clang interpretes an if condition like "if ((a = b) == NULL) > as it tries to assign a value in a statement. Hence if you do > "if ((something)) it warns you that you might be confused. > Hence drop the double braces for plane if s

Re: [U-Boot] jffs2:jffs2_1pass.c: remove double braces

2014-06-11 Thread Tom Rini
On Wed, Jun 11, 2014 at 12:40:25AM +0200, Jeroen Hofstee wrote: > Clang interpretes an if condition likeĀ  "if ((a = b) == NULL) > as it tries to assign a value in a statement. Hence if you do > "if ((something)) it warns you that you might be confused. > Hence drop the double braces for plane if s

Re: [U-Boot] LzmaTools: don't self assign values

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 11:37:23PM +0200, Jeroen Hofstee wrote: > It seems the code tries to trick the compiler the argument > is actually used. However compilers became too smart to > fool them so easily an now warn. Gcc and clang don't seem > to emit a warning when the argument is unused. If so

Re: [U-Boot] imximage_hynix.cfg: fix unterminated comment

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 11:16:09PM +0200, Jeroen Hofstee wrote: > cc: Troy Kisky > Signed-off-by: Jeroen Hofstee Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de htt

Re: [U-Boot] cosmetic: board: pm9263 rewrite old style stuct init

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 11:12:04PM +0200, Jeroen Hofstee wrote: > this prevent some warnings when compiling with clang > > cc: Stelian Pop > Signed-off-by: Jeroen Hofstee Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] tps6586x.h: fix inclusion guard

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 11:01:58PM +0200, Jeroen Hofstee wrote: > cc: Simon Glass > Signed-off-by: Jeroen Hofstee > Acked-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing lis

Re: [U-Boot] kbuild: move spl/Makefile to scripts/Makefile.spl

2014-06-11 Thread Tom Rini
On Mon, Jun 09, 2014 at 03:14:11PM +0900, Masahiro Yamada wrote: > All files under spl/ and tpl/ are generated during the build process > except spl/Makefile. > > We can simplify clean-rule and git-ignore by moving spl/Makefile > to somewhere else. > > Signed-off-by: Masahiro Yamada Applied to

Re: [U-Boot] cosmetic: atmel: replace old style struct init

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 12:16:23AM +0200, Jeroen Hofstee wrote: > This prevents some warnings when building with clang. > cc:: andreas.de...@googlemail.com > Signed-off-by: Jeroen Hofstee Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] Remove ${objtree}/include/asm/proc/ link

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 04:16:14PM +0300, Vasili Galka wrote: > mkconfig links ${objtree}/include/asm/proc/ to > ${srctree}/arch/${arch}/include/asm/proc-armv/. This seems to be a > remnant from the past. Ever since its introduction in 2003 it is used > only in ARM build and always links to same p

Re: [U-Boot] cosmetic: Whitespace fix

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 04:06:52PM +0300, Vasili Galka wrote: > Signed-off-by: Vasili Galka Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mail

Re: [U-Boot] [U-Boot,3/3] ext4: correctly zero filename

2014-06-11 Thread Tom Rini
On Mon, Jun 09, 2014 at 03:29:00PM +0200, Jeroen Hofstee wrote: > Since ALLOC_CACHE_ALIGN_BUFFER declares a char* for filename > sizeof(filename) is not the size of the buffer. Use the already > known length instead. > > cc: Uma Shankar > cc: Manjunatha C Achar > cc: Marek Vasut > Signed-off-b

Re: [U-Boot] common: hash: zero end the string instead of the pointer

2014-06-11 Thread Tom Rini
On Mon, Jun 09, 2014 at 11:02:02AM +0200, Jeroen Hofstee wrote: > if algo->digest_size is zero nothing is set in the str_output > buffer. An attempt is made to zero end the buffer, but the > pointer to the buffer is set to zero instead. I am unaware if > it causes any actual problems, but solves t

Re: [U-Boot] m68k: Fix warnings with gcc 4.6

2014-06-11 Thread Tom Rini
On Sat, Jun 07, 2014 at 10:07:58PM -0600, Simon Glass wrote: > Most of the warnings seem to be related to using 'int' for size_t. Change > this and fix up the remaining warnings and problems. For bootm, the warning > was masked by others, and there is an actual bug in the code. > > Signed-off-by:

Re: [U-Boot] [U-Boot, v2] kbuild, tools: generate wrapper C sources automatically by Makefile

2014-06-11 Thread Tom Rini
On Fri, Jun 06, 2014 at 02:04:32PM +0900, Masahiro Yamada wrote: > There are many source files shared between U-boot image and tools. > Instead of adding a lot of dummy wrapper files that just include > the corresponding file in lib/ or common/ directory, > Makefile should automatically generate t

Re: [U-Boot] [U-Boot, 1/2] kbuild: remove unnecessary adjustment for Cygwin

2014-06-11 Thread Tom Rini
On Fri, Jun 06, 2014 at 08:46:44PM +0900, Masahiro Yamada wrote: > "SFX = .exe" was originally added for Cygwin environment. > > It is true that GCC on Cygwin spits executables with .exe extention. > > For example, > > gcc -o foo foo.c > > will generate "foo.exe", not "foo". > > But GNU mak

Re: [U-Boot] docs: driver-model: Fix spelling

2014-06-11 Thread Tom Rini
On Sat, Jun 07, 2014 at 10:35:55AM +1200, Chris Packham wrote: > Signed-off-by: Chris Packham Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/ma

Re: [U-Boot] [U-Boot, 2/2] .gitignore: move *.exe pattern to the top gitignore for Cygwin

2014-06-11 Thread Tom Rini
On Fri, Jun 06, 2014 at 08:46:45PM +0900, Masahiro Yamada wrote: > GCC on Cygwin generates executables with .exe extension, > for example: > scripts/basic/fixdep.exe > scripts/docproc.exe > > To ignore them, *.exe pattern should be moved > from tools/.gitignore to ./.gitignore > > Signed-off-b

Re: [U-Boot] .gitignore: drop *.dts.tmp pattern

2014-06-11 Thread Tom Rini
On Fri, Jun 06, 2014 at 08:18:37PM +0900, Masahiro Yamada wrote: > This pattern was added by commit cc4f427b to ignore the intermidiate > file for generating DTB. > > When Kbuild was introduced, dts/Makefile was totally re-written. > This ignore pattern is already useless. > > Signed-off-by: Mas

Re: [U-Boot] kbuild: export HOSTCXX and HOSTCXXFLAGS

2014-06-11 Thread Tom Rini
On Fri, Jun 06, 2014 at 10:15:27AM +0900, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.d

Re: [U-Boot] [U-Boot,RESEND,2/3] Add run_command_repeatable()

2014-06-11 Thread Tom Rini
On Thu, Jun 05, 2014 at 08:07:57PM +0200, Thomas Betker wrote: > run_command() returns 0 on success and 1 on error. However, there are some > invocations which expect 0 or 1 for success (not repeatable or repeatable) > and -1 for error; add run_command_repeatable() for this purpose. > > Signed-of

Re: [U-Boot] disk: part_dos.c: Add a PBR check when MBR checking fails

2014-06-11 Thread Tom Rini
On Fri, Jun 06, 2014 at 03:48:26PM +1200, Darwin Dingel wrote: > Bug: SDCard with a messed up partition but still has a FAT signature > intact is readable in Linux but unreadable in uboot with 'fatls'. > > Fix: When partition info checking fails, there is no checking for a > FAT signature (DOS_PB

Re: [U-Boot] [U-Boot,RESEND,3/3] Use run_command_repeatable()

2014-06-11 Thread Tom Rini
On Thu, Jun 05, 2014 at 08:07:58PM +0200, Thomas Betker wrote: > Replace run_command() by run_command_repeatable() in places which > depend on the return code to indicate repeatability. > > Signed-off-by: Thomas Betker > Acked-by: Simon Glass > Tested-by: Simon Glass Applied to u-boot/master,

Re: [U-Boot] [U-Boot, RESEND, 1/3] Check run_command() return code properly

2014-06-11 Thread Tom Rini
On Thu, Jun 05, 2014 at 08:07:56PM +0200, Thomas Betker wrote: > run_command() returns 0 for success, 1 for failure. Fix places which > assume that failure is indicated by a negative return code. > > Signed-off-by: Thomas Betker > Acked-by: Simon Glass > Tested-by: Simon Glass > Tested-by: Ste

Re: [U-Boot] [U-Boot,v3,13/14] am33xx/omap: Enable FIT support

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:56PM -0600, Simon Glass wrote: > Enable booting a FIT containing a kernel/device tree. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot ma

Re: [U-Boot] [U-Boot, v3, 14/14] am33xx/omap: Add a new board to enable verified boot

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:57PM -0600, Simon Glass wrote: > Enable verified boot functionality for a new am335x_boneblack_vboot target. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [PATCH v3 0/14] Minor improvements to secure boot and enable on beaglebone

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:43PM -0600, Simon Glass wrote: > This series fixes a few problems that have come up since the secure boot > series was merged: > > - A recent commit broken the assumption that u-boot.bin ends at a known > address (thus making things appended to U-Boot inaccessible fr

Re: [U-Boot] [PATCH v3 07/14] fdt: Add DEV_TREE_BIN option to specify a device tree binary file

2014-06-11 Thread Tom Rini
On Tue, Jun 10, 2014 at 02:59:23PM +0900, Masahiro Yamada wrote: > Hi Simon, > > > On Mon, 2 Jun 2014 22:04:50 -0600 > Simon Glass wrote: > > > In some cases, an externally-built device tree binary is required to be > > attached to U-Boot. An example is when using image signing, since in that

Re: [U-Boot] [U-Boot, v3, 10/14] mkimage: Automatically make space in FDT when full

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:53PM -0600, Simon Glass wrote: > When adding hashes or signatures, the target FDT may be full. Detect this > and automatically try again after making 1KB of space. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description

Re: [U-Boot] [U-Boot, v3, 12/14] am33xx/omap: Enable CONFIG_OF_CONTROL

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:55PM -0600, Simon Glass wrote: > Add support for device tree control and add device tree files for the > beaglebone black initially. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [U-Boot, v3, 11/14] arm: ti: Increase malloc size to 16MB for armv7 boards

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:54PM -0600, Simon Glass wrote: > The current size of 1MB is not enough use to use DFU. Increase it for > ARMv7 boards, all of which should have 32MB or more SDRAM. > > With this change it is possible to do 'dfu mmc 0' on a Beaglebone Black. > > Signed-off-by: Simon

Re: [U-Boot] [U-Boot, v3, 09/14] Improve error handling in fit_common

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:52PM -0600, Simon Glass wrote: > Make the error handling common, and make sure the file is always closed > on error. Rename the parameter to be more description and add comments. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.

Re: [U-Boot] [U-Boot, v3, 08/14] fdt: Update functions which write to an FDT to return -ENOSPC

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:51PM -0600, Simon Glass wrote: > When writing values into an FDT it is possible that there will be > insufficient space. If the caller gets a useful error then it can > potentially deal with the situation. > > Adjust these functions to return -ENOSPC when the FDT is

Re: [U-Boot] [U-Boot, v3, 06/14] hash: Export the function to show a hash

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:49PM -0600, Simon Glass wrote: > This function is useful for displaying a hash value, so export it. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature

Re: [U-Boot] [U-Boot, v3, 05/14] am33xx/omap: Allow cache enable for all Sitara/OMAP

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:48PM -0600, Simon Glass wrote: > Enable the cache for all devices, unless CONFIG_SYS_DCACHE_OFF is defined. > This speeds up the Beaglebone Black boot considerable. > > (Tested only on Beaglebone Black with SD card boot) > > Signed-off-by: Simon Glass Applied to u

Re: [U-Boot] [U-Boot, v3, 07/14] fdt: Add DEV_TREE_BIN option to specify a device tree binary file

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:50PM -0600, Simon Glass wrote: > In some cases, an externally-built device tree binary is required to be > attached to U-Boot. An example is when using image signing, since in that > case the .dtb file must include the public keys. > > Add a DEV_TREE_BIN option to th

Re: [U-Boot] [U-Boot, v3, 02/14] cm_t335: Fix the U-Boot binary output

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:45PM -0600, Simon Glass wrote: > Correct the binary output so that image_binary_size is really at the > end of the image. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, v3, 03/14] mx31ads: Fix the U-Boot binary output

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:46PM -0600, Simon Glass wrote: > Correct the binary output so that image_binary_size is really at the > end of the image. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, v3, 01/14] ti: am335x: Fix the U-Boot binary output

2014-06-11 Thread Tom Rini
On Mon, Jun 02, 2014 at 10:04:44PM -0600, Simon Glass wrote: > This should include the hash so that image_binary_size is really at the > end of the image, and not some 300 bytes earlier. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digit

Re: [U-Boot] [U-Boot, 2/2] tools: include u-boot version of sha256.h

2014-06-11 Thread Tom Rini
On Fri, May 30, 2014 at 03:45:28PM +0200, Jeroen Hofstee wrote: > When building tools the u-boot specific sha256.h is required, but the > host version of sha256.h is used when present. This leads to build errors > on FreeBSD which does have a system sha256.h include. Like libfdt_env.h > explicitly

Re: [U-Boot] [U-Boot, 1/2] Makefile: fix clang warnings due to clang support

2014-06-11 Thread Tom Rini
On Fri, May 30, 2014 at 03:45:27PM +0200, Jeroen Hofstee wrote: > Building u-boot tools with clang as a host compiler e.g. on > FreeBSD with `gmake HOSTCC=clang CONFIG_USE_PRIVATE_LIBGCC=y tools` > leads to many warnings [1] for every compiler invocation since > commit 598e2d33. Part of mentioned

[U-Boot] [PATCH 4/4] dfu: add SF backend

2014-06-11 Thread Stephen Warren
From: Stephen Warren This allows SPI Flash to be programmed using DFU. Signed-off-by: Stephen Warren --- drivers/dfu/Makefile | 1 + drivers/dfu/dfu.c| 3 ++ drivers/dfu/dfu_sf.c | 139 +++ include/dfu.h| 22 4 files cha

  1   2   >