Re: [U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32

2013-10-05 Thread Wolfgang Denk
Dear Tom Rini, In message <1380227287-26057-2-git-send-email-tr...@ti.com> you wrote: > Currently our limit is too small to allow for /dev/mmcblk0boot0 to work, > for example. Expand to 32 for future needs. > > Signed-off-by: Tom Rini > --- > tools/env/fw_env.c |2 +- > 1 file changed, 1 i

Re: [U-Boot] [PATCH 02/11] env_mmc.c: Make the non-redundant env_relocate_spec use malloc not stack

2013-10-05 Thread Wolfgang Denk
Dear Tom Rini, In message <1380227287-26057-3-git-send-email-tr...@ti.com> you wrote: > Switch the case of non-redundant non-embedded environment to use malloc > to allocate buffers, rather than place them on the stack, like the > redundant case does. What exactly would be the benefit of this cha

Re: [U-Boot] [PATCH] env_mmc: fix buffer allocation for armv7

2013-10-05 Thread Wolfgang Denk
Dear Tom Rini, In message <20131004170203.GL15917@bill-the-cat> you wrote: > > I really don't like this. We're now allocating for example 256KiB on > the stack, rather than malloc. I posted a patch recently to convert the > non-redundant case to malloc instead for this reason. I believe the >

[U-Boot] fs/fs.c - error handling needed?

2013-10-05 Thread Wolfgang Denk
Dear Simon, with commit a8f6ab5 "fs: Add support for saving data to filesystems" you add the function do_save() to U-Boot. This includes the following code (line numbers as of current master): "fs/fs.c": ... 331 filename = argv[3]; 332 addr = simple_strtoul(argv[4], NULL, cmdlin

[U-Boot] [PATCH] Fix number base handling of "load" command

2013-10-05 Thread Wolfgang Denk
A documented, almost all U-Boot commands expect numbers to be entered in hexadecimal input format. (Exception: for historical reasons, the "sleep" command takes its argument in decimal input format.) This rule was broken for the "load" command; for details please see especially commits 045fa1e "fs

Re: [U-Boot] [PATCH 7/9][v2] net: tsec: Use portable types and accessors for BDs

2013-10-05 Thread Timur Tabi
On Sat, Oct 5, 2013 at 9:31 AM, Timur Tabi wrote: > > + out_be32(®s->tbase, (u32)&txbd[0]); > + out_be32(®s->rbase, (u32)&rxbd[0]); > > &rxbd[0] is a virtual address. > > Doesn't rbase require a physical address? You're assuming that virt == phys. Also: - out_be32(®s->tbase, (unsigned int)(&rtx

Re: [U-Boot] [PATCH 7/9][v2] net: tsec: Use portable types and accessors for BDs

2013-10-05 Thread Timur Tabi
On Fri, Oct 4, 2013 at 11:25 AM, Claudiu Manoil wrote: > [v3] declaring the BDs as __iomem to avoid casting submitted: > http://patchwork.ozlabs.org/patch/280664/ + out_be32(®s->tbase, (u32)&txbd[0]); + out_be32(®s->rbase, (u32)&rxbd[0]); &rxbd[0] is a virtual address. Doesn't rbase require a

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Sourav Poddar
On Saturday 05 October 2013 05:10 PM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 3:25 PM, Sourav Poddar wrote: On Saturday 05 October 2013 03:11 PM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar wrote: On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 20

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Jagan Teki
On Sat, Oct 5, 2013 at 3:25 PM, Sourav Poddar wrote: > On Saturday 05 October 2013 03:11 PM, Jagan Teki wrote: >> >> On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar >> wrote: >>> >>> On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar

Re: [U-Boot] AES: Encryption of u-boot.img

2013-10-05 Thread Albert ARIBAUD
Hi bin4ry, Sorry for the delay in answering. On Mon, 30 Sep 2013 09:51:54 +0200, bin4ry <0xbin...@gmail.com> wrote: > Hi Albert, > > so if I get you right the workflow for payload authentication is the > following: > > Encryption process: (you really should not talk about "encryption process"

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Sourav Poddar
On Saturday 05 October 2013 03:11 PM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar wrote: On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar wrote: On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: On Fri, Oct 4, 20

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Jagan Teki
On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar wrote: > On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: >> >> On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar >> wrote: >>> >>> On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: On Fri, Oct 4, 2013 at 8:21 PM, Sourav Poddar

Re: [U-Boot] [PATCH 0/4] arm64: rela relocation

2013-10-05 Thread Albert ARIBAUD
Hi FengHua, On Fri, 4 Oct 2013 23:55:01 +0800 (GMT+08:00), FengHua wrote: > > > > arm64: rela relocation > > > > This lets us remove the manual relocation stuff from the arm64 patchset > > (the symbol itself is removed by this patchset, but not all the new > > manual relocations added by the

Re: [U-Boot] [PATCH 1/4] arm64: Add tool to statically apply RELA relocations

2013-10-05 Thread Albert ARIBAUD
Hi Scott, On Thu, 3 Oct 2013 17:48:28 -0500, Scott Wood wrote: > ARM64 uses the newer RELA-style relocations rather than the older REL. > RELA relocations have an addend in the relocation struct, rather than > expecting the loader to read a value from the location to be updated. > > While this i

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-10-05 Thread Albert ARIBAUD
Hi Simon, On Thu, 3 Oct 2013 17:49:23 -0600, Simon Glass wrote: > Hi, > > > On Wed, Oct 2, 2013 at 1:27 PM, Albert ARIBAUD > wrote: > > > Hi Masahiro, > > > > On Wed, 21 Aug 2013 13:33:19 +0900, Masahiro Yamada > > wrote: > > > > > Hello, Albert and U-Boot developers. > > > > > > > > > The