Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-23 Thread Helmut Raiger
On 08/22/2011 06:02 PM, Marek Vasut wrote: > ... _COSMETIC_, while this new mx3fb driver really works nicely ;-) > Oh my sense for metrosexuality of code really kicks in here ;-) Arousal was not my first objective, but deliberately endorsed :-P I'll do what can be done easily concerning the bit ac

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-23 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > But frankly: do you consider this list above _readable_? ... > grep is your friend - All you need to to is grep for GLOBAL (actually I > think COMMON is a better name) and the ARCH, SOC, and BOARD keywords in > the namespace for your board and voila

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Wolfgang Denk
Dear Eric, In message <20110824054915.0860711f9...@gemini.denx.de> I wrote: > > > Sure, DHCP is the best *technical* solution. > > I meant for static IP address? > > Why does anybody need static IP addresses for the default case, i. e. > for system bring up? And if you need one, what is the iss

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Stefano Babic
On 08/24/2011 06:56 AM, Eric Jarrige wrote: > Dear Wolfgang, Dear Stefano, Hi Eric, >>> We really need a set of default IP addresses for private network to >>> simplify as much as possible the life of the armadeus project developers. >> >> And what makes you think that 192.168.0.10 might be a f

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Eric Jarrige
Dear Wolfgang, Dear Stefano, On 23 août 2011, at 13:26, Wolfgang Denk wrote: > Dear Eric Jarrige, > > can you please mind your line length? It is strongly recommended that > text lines should not exceed 70 characters or so. Thanks. I will take care of that. I do apologize for the inconvenient

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-23 Thread Graeme Russ
Hi Wolfgang, On Wed, Aug 24, 2011 at 3:38 PM, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message > you > wrote: >> >> So we end up with: >> >> #DEFINE INIT_GLOBAL_START 1 >> #DEFINE INIT_X86_CPU_FINIT_GLOBAL_START + 1 >> #DEFINE INIT_ARM_CPU_FINIT_G

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Wolfgang Denk
Dear Eric Jarrige, In message you wrote: > > > Stefano is right. "filesize" and "fileaddr" are dynamic variables, > > thet get created and updated on the fly. It makes no sense to > > pre-define them to any specific value. [Actually I have some changes > > in mind that avoid to save such variab

Re: [U-Boot] [PATCH] add dm9000 eeprom read/write command

2011-08-23 Thread Eric Jarrige
On 23 août 2011, at 16:21, Stefano Babic wrote: > On 08/23/2011 03:42 PM, Mike Frysinger wrote: >> On Tuesday, August 23, 2011 01:15:25 Eric Jarrige wrote: >>> On 22 août 2011, at 23:55, Mike Frysinger wrote: On Monday, August 22, 2011 17:37:42 Eric Jarrige wrote: > +#if (!defined(CONFIG

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-23 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > So we end up with: > > #DEFINE INIT_GLOBAL_START 1 > #DEFINE INIT_X86_CPU_FINIT_GLOBAL_START + 1 > #DEFINE INIT_ARM_CPU_FINIT_GLOBAL_START + 1 > ... > #DEFINE INIT_X86_INIT_X86_ + 1 > ... > #DEF

[U-Boot] [PATCH 3/3] powerpc/mpc8610hpcd: set pci1_hose.config_table after fsl_setup_hose

2011-08-23 Thread Zhao Chenhui
The function fsl_setup_hose clears the variable pci1_hose. Set pci1_hose.config_table after it. Signed-off-by: Zhao Chenhui --- board/freescale/mpc8610hpcd/mpc8610hpcd.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/board/freescale/mpc8610hpcd/mpc8610hpcd.c

[U-Boot] [PATCH 1/3] powerpc/mpc8548cds: set pci1_hose.config_table after fsl_setup_hose

2011-08-23 Thread Zhao Chenhui
The function fsl_setup_hose clears the variable pci1_hose. Set pci1_hose.config_table after it. Signed-off-by: Zhao Chenhui --- board/freescale/mpc8548cds/mpc8548cds.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/board/freescale/mpc8548cds/mpc8548cds.c b/board/f

[U-Boot] [PATCH] powerpc/mpc8548cds: Cleanup mpc8548cds.c

2011-08-23 Thread Zhao Chenhui
Remove unnecessary or dead code/includes. Signed-off-by: Zhao Chenhui --- board/freescale/mpc8548cds/mpc8548cds.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/board/freescale/mpc8548cds/mpc8548cds.c b/board/freescale/mpc8548cds/mpc8548cds.c index 5ffae47..f70a9

[U-Boot] [PATCH 2/3] powerpc/mpc8568mds: set pci1_hose.config_table after fsl_setup_hose

2011-08-23 Thread Zhao Chenhui
The function fsl_setup_hose clears the variable pci1_hose. Set pci1_hose.config_table after it. Signed-off-by: Zhao Chenhui --- board/freescale/mpc8568mds/mpc8568mds.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/board/freescale/mpc8568mds/mpc8568mds.c b/bo

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Wolfgang Denk" wrote: > Dear Ajay Bhargav, > > In message > <1570238601.123783.1314104389736.javamail.r...@ahm.einfochips.com> you > wrote: > > > > ok I just wanted to clear myself.. I do not have a dedicated > hardware > > storage in my ethernet controller so I will just look into > en

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Eric Jarrige
Hi Stefano, On 23 août 2011, at 11:46, Stefano Babic wrote: > > > sorry for my late answer. I have missed a point. No problem on my side - my answers are sometime even longer. > >>> Please drop fix ip address. They should not be part of mainline, >> >> Here, I have a problem as our document

Re: [U-Boot] [PATCH v3] Add 'sf update' command to do smart SPI flash update

2011-08-23 Thread Simon Glass
Hi Che-Liang. On Tue, Aug 23, 2011 at 8:41 PM, Che-liang Chiou wrote: > Hi Simon, > > I have a dumb question: How did you make u-boot run native under > Linux? Did you mock out all platform functions? Or did you bundle > u-boot with a emulator? Basically created a new architecture (like arm/x86)

Re: [U-Boot] [PATCH v3] Add 'sf update' command to do smart SPI flash update

2011-08-23 Thread Che-liang Chiou
Hi Simon, I have a dumb question: How did you make u-boot run native under Linux? Did you mock out all platform functions? Or did you bundle u-boot with a emulator? Regards, Che-Liang On Wed, Aug 24, 2011 at 6:16 AM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 18:01:34 Simon Glass wrote

Re: [U-Boot] [PATCH] arm: tegra2: fix out-of-tree build

2011-08-23 Thread Che-liang Chiou
Hi Anton, Thanks for comments. Replied below. Regards, Che-Liang On Wed, Aug 24, 2011 at 1:01 AM, Anton Staaf wrote: > On Tue, Aug 23, 2011 at 3:03 AM, Che-Liang Chiou wrote: >> The out-of-tree build fails because the Makefiles in question depend on >> source files of another directory but do

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 18:42:46 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > Why cannot we define a macro that declares a (sufficiently sized) > > > buffer on the stack and provides and a pointer to a (correctly > > > aligned) address in this buffer? > > > > isnt that what i already pos

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-23 Thread Graeme Russ
Hi Wolfgang, On Tue, Aug 23, 2011 at 9:49 PM, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message > you > wrote: >> [snip] > >> > 2. One of the advantages of the current implementation is that there >> > is a central place in the code (well, at least per architecture, >> > untill we

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108231732.39791.vap...@gentoo.org> you wrote: > > > Why cannot we define a macro that declares a (sufficiently sized) > > buffer on the stack and provides and a pointer to a (correctly > > aligned) address in this buffer? > > isnt that what i already posted and

Re: [U-Boot] [PATCH v3] Add 'sf update' command to do smart SPI flash update

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 18:01:34 Simon Glass wrote: > That's a great trick. How much of the drivers did you implement in the > simulator? probably more than i'd like to admit, but not as many as i'd like ;) http://docs.blackfin.uclinux.org/doku.php?id=toolchain:sim#peripherals > How about thi

Re: [U-Boot] [PATCH v3] Add 'sf update' command to do smart SPI flash update

2011-08-23 Thread Simon Glass
Hi Mike, On Fri, Aug 19, 2011 at 3:28 PM, Mike Frysinger wrote: > On Friday, August 19, 2011 17:25:10 Simon Glass wrote: >> On Fri, Aug 19, 2011 at 3:15 PM, Mike Frysinger wrote: >> > On Friday, August 19, 2011 15:28:48 Simon Glass wrote: >> >> This adds a new SPI flash command which only rewrite

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 2:32 PM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 17:09:37 Wolfgang Denk wrote: >> Mike Frysinger wrote: >> > On Tuesday, August 23, 2011 16:27:26 Anton Staaf wrote: >> > > So then, to guide our efforts, what is a more suitable solution? >> > > Would you prefer w

Re: [U-Boot] [PATCH v4 03/13] common: add run_command2 for running simple or hush commands

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 17:06:51 Jason Hobbs wrote: > Signed-off-by: Jason Hobbs > --- > changes in v2: > - whitespace correction > > changes in v4: > - fix indention of a run_command2 line > - make run_command2 static inline > > common/hush.c |2 +- > common/main.c | 50 +++

Re: [U-Boot] [PATCH v4 07/13] Add standard environment variables README

2011-08-23 Thread Mike Frysinger
this somewhat duplicates the "Environment Variables" section in the top level README. can't we have just one location for this stuff ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.

Re: [U-Boot] [PATCH v4 06/13] Replace space and tab checks with isblank

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 17:06:54 Jason Hobbs wrote: > - while (*nn == ' ' || *nn == '\t') > + while (isblank(*nn)) > nn++; at least for these "walking forward" ones, they could be replaced with: nn += strspn(nn, " \t"); -mike signature.asc Description: This is a

Re: [U-Boot] [PATCH v4 04/13] Add isblank

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 17:06:52 Jason Hobbs wrote: > Existing ctype checks are implemented using a 256 byte lookup table, > allowing each character to be in any of 8 character classes. Since there > are 8 existing character classes without the blank class, I implemented > isblank without using

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 17:09:37 Wolfgang Denk wrote: > Mike Frysinger wrote: > > On Tuesday, August 23, 2011 16:27:26 Anton Staaf wrote: > > > So then, to guide our efforts, what is a more suitable solution? > > > Would you prefer we stick with the existing path of calling memalign > > > and p

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 17:06:41 Anton Staaf wrote: > On Tue, Aug 23, 2011 at 1:37 PM, Mike Frysinger wrote: > > On Tuesday, August 23, 2011 16:27:26 Anton Staaf wrote: > >> So then, to guide our efforts, what is a more suitable solution? > >> Would you prefer we stick with the existing path o

[U-Boot] [PATCH v4 13/13] arm: ca9x4_ct_vxp: enable PXE BOOTP options support

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- changes for v2: - add armv7 architecture to VCI string changes for v4: - combine the PXE bootp options with the other bootp options include/configs/ca9x4_ct_vxp.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/c

[U-Boot] [PATCH v4 12/13] arm: ca9x4_ct_vxp: enable pxe command support

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- changes in v2: - use CONFIG_MENU to enable building the menu for pxecfg use changes in v4: - use CONFIG_CMD_PXE instead of CONFIG_CMD_PXECFG - update to standard environment variables include/configs/ca9x4_ct_vxp.h |4 1 files changed, 4

[U-Boot] [PATCH v4 11/13] Convert ca9x4_ct_vxp to standard env variables

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- new in v4 include/configs/ca9x4_ct_vxp.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 8c57eab..7e5dc66 100644 --- a/include/configs/ca9x4_c

[U-Boot] [PATCH v4 10/13] net: bootp: add PXE/RFC 4578 DHCP options support

2011-08-23 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Signed-off-by: Jason Hobbs --- changes for v2

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108231637.05845.vap...@gentoo.org> you wrote: > > On Tuesday, August 23, 2011 16:27:26 Anton Staaf wrote: > > So then, to guide our efforts, what is a more suitable solution? > > Would you prefer we stick with the existing path of calling memalign > > and passin

[U-Boot] [PATCH v4 08/13] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes for v2: - Move uuid_str_to_bin's prototype from uuid. to common.h - Place uuid.o make rule in sorted order and conditionalize changes for v3: - check for NULL pointers in uuid conversion function changes for v4: - add a UUID string validator include/commo

[U-Boot] [PATCH v4 07/13] Add standard environment variables README

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- new in v4 doc/README.standard-env | 92 +++ 1 files changed, 92 insertions(+), 0 deletions(-) create mode 100644 doc/README.standard-env diff --git a/doc/README.standard-env b/doc/README.standard-env new file mode 100

[U-Boot] [PATCH v4 06/13] Replace space and tab checks with isblank

2011-08-23 Thread Jason Hobbs
These are various places I found that checked for conditions equivalent to isblank. Signed-off-by: Jason Hobbs --- new in v4 board/hymod/env.c|9 + common/command.c |9 + common/main.c|5 +++-- drivers/b

[U-Boot] [PATCH v4 04/13] Add isblank

2011-08-23 Thread Jason Hobbs
Existing ctype checks are implemented using a 256 byte lookup table, allowing each character to be in any of 8 character classes. Since there are 8 existing character classes without the blank class, I implemented isblank without using the lookup table. Since there are only two blank characters -

[U-Boot] [PATCH v4 05/13] cosmetic: remove unneeded curly braces

2011-08-23 Thread Jason Hobbs
This prevents a checkpatch warning in the patch to use isblank Signed-off-by: Jason Hobbs --- new in v4 common/main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/common/main.c b/common/main.c index e9e8350..bf5ddca 100644 --- a/common/main.c +++ b/common/main.c

[U-Boot] [PATCH v4 03/13] common: add run_command2 for running simple or hush commands

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - whitespace correction changes in v4: - fix indention of a run_command2 line - make run_command2 static inline common/hush.c |2 +- common/main.c | 50 +- include/hush.h |2 +- 3 files cha

[U-Boot] [PATCH v4 02/13] common, menu: use abortboot for menu timeout

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - expose abortboot externally instead of using a wrapper - expose abortboot externally when CONFIG_MENU is set changes in v3: - simplify the conditional export of abortboot - add timeout support for the menu in this patch - add doc for timeout feature

[U-Boot] [PATCH v4 01/13] Add generic, reusable menu code

2011-08-23 Thread Jason Hobbs
This will be used first by the pxe code, but is intended to be generic and reusable for other jobs in U-boot. Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 changes in v3: - move timeout support to later patch - fix NULL case bug in menu_item_key_match - consistently use 'item_key

[U-Boot] [PATCH v4 00/13] Add PXE support

2011-08-23 Thread Jason Hobbs
This patch series adds PXE booting support to U-boot. It adds aseries of DHCP options to allow U-boot DHCP requests to be compliant with RFC 4578, and a set of commands to provide PXELINUX like behavior. The pxe commands provide a near subset of the functionality provided by the PXELINUX boot load

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 1:37 PM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 16:27:26 Anton Staaf wrote: >> So then, to guide our efforts, what is a more suitable solution? >> Would you prefer we stick with the existing path of calling memalign >> and passing it the cache size by directly

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 16:27:26 Anton Staaf wrote: > So then, to guide our efforts, what is a more suitable solution? > Would you prefer we stick with the existing path of calling memalign > and passing it the cache size by directly calling > get_dcache_line_size? Or would you prefer somethin

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 16:12:03 Wolfgang Denk wrote: > Anton Staaf wrote: > > > what about adding a new func like: > > > #define dma_buffer_alloca(size) > > > > I generally avoid large allocations on the stack, they can confuse > > virtual stack management and blow out small embedded stacks.

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 1:12 PM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> > what about adding a new func like: >> > #define dma_buffer_alloca(size) >> >> I generally avoid large allocations on the stack, they can confuse >> virtual stack management and blow o

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 1:18 PM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> > and what do you do when there is no memory left in the malloc arena because >> > you leaked it all and so can't service any new read requests ? >> >> I think you've miss-understood my

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > > and what do you do when there is no memory left in the malloc arena because > > you leaked it all and so can't service any new read requests ? > > I think you've miss-understood my patch. The allocated buffer is > stored in a static variable. So on

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108231447.39934.vap...@gentoo.org> you wrote: > > then people would simply do: > DMA_DECLARE_BUFFER(char, sec_buf, SECTOR_SIZE); > > but i'm not sure this is better than the proposed: > char *sec_buf = dma_buffer_alloca(SECTOR_SIZE); > > i'd have to

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > > what about adding a new func like: > > #define dma_buffer_alloca(size) > > I generally avoid large allocations on the stack, they can confuse > virtual stack management and blow out small embedded stacks. But > neither of these are really a problem

Re: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu

2011-08-23 Thread Angelo Dureghello
Hello Jason and all, i started to work to rewrite the patch. Starting from mcf532x/cpu.c, i am not sure this is the right place to add MCF5307. 1) On "checkcpu", mcf5307 don't have ccm->cir where to read mask/ver. 2) About "do_reset", here also mcf5307 don't have MMAP_RCM, memory map and reset

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 11:55 AM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 14:48:24 Anton Staaf wrote: >> On Tue, Aug 23, 2011 at 11:32 AM, Mike Frysinger wrote: >> > and what do you do when there is no memory left in the malloc arena >> > because you leaked it all and so can't service

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 14:48:24 Anton Staaf wrote: > On Tue, Aug 23, 2011 at 11:32 AM, Mike Frysinger wrote: > > and what do you do when there is no memory left in the malloc arena > > because you leaked it all and so can't service any new read requests ? > > I think you've miss-understood my

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 11:47 AM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 14:39:48 Wolfgang Denk wrote: >> Anton Staaf wrote: >> > >> This patch allocates a cache line size aligned sector sized bounce >> > >> buffer the first time that ext2fs_devread is called. >> > > >> > > ...and nev

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 11:32 AM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 13:58:01 Anton Staaf wrote: >> On Tue, Aug 23, 2011 at 10:23 AM, Mike Frysinger wrote: >> > On Monday, August 22, 2011 17:48:47 Anton Staaf wrote: >> >> On Mon, Aug 22, 2011 at 2:42 PM, Wolfgang Denk wrote: >> >>

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 14:39:48 Wolfgang Denk wrote: > Anton Staaf wrote: > > >> This patch allocates a cache line size aligned sector sized bounce > > >> buffer the first time that ext2fs_devread is called. > > > > > > ...and never frees ist, which is a bad thing. =A0Please fix. > > > > Tha

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 11:36 AM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 14:12:09 Anton Staaf wrote: >> On Tue, Aug 23, 2011 at 10:30 AM, Mike Frysinger wrote: >> > what about adding a new func like: >> > #define dma_buffer_alloca(size) >> >> I generally avoid large allocations on the

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > >> This patch allocates a cache line size aligned sector sized bounce > >> buffer the first time that ext2fs_devread is called. > > > > ...and never frees ist, which is a bad thing. =A0Please fix. > > That was actually intentional. To free the buffer

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 14:12:09 Anton Staaf wrote: > On Tue, Aug 23, 2011 at 10:30 AM, Mike Frysinger wrote: > > what about adding a new func like: > > #define dma_buffer_alloca(size) > > I generally avoid large allocations on the stack, they can confuse > virtual stack management and blow ou

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 14:12:09 Anton Staaf wrote: > On Tue, Aug 23, 2011 at 10:30 AM, Mike Frysinger wrote: > > On Tuesday, August 23, 2011 05:19:39 Lukasz Majewski wrote: > >> On Mon, 22 Aug 2011 11:57:57 -0700 Anton Staaf wrote: > >> > drivers/mmc/mmc.c: ext_csd in mmc_change_freq is alloca

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 13:58:01 Anton Staaf wrote: > On Tue, Aug 23, 2011 at 10:23 AM, Mike Frysinger wrote: > > On Monday, August 22, 2011 17:48:47 Anton Staaf wrote: > >> On Mon, Aug 22, 2011 at 2:42 PM, Wolfgang Denk wrote: > >> > Anton Staaf wrote: > >> >> Currently, if a device read reque

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 10:30 AM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 05:19:39 Lukasz Majewski wrote: >> On Mon, 22 Aug 2011 11:57:57 -0700 Anton Staaf wrote: >> > drivers/mmc/mmc.c: ext_csd in mmc_change_freq is allocated on the stac >> > drivers/mmc/mmc.c: scr and switch_status i

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 10:23 AM, Mike Frysinger wrote: > On Monday, August 22, 2011 17:48:47 Anton Staaf wrote: >> On Mon, Aug 22, 2011 at 2:42 PM, Wolfgang Denk wrote: >> > Anton Staaf wrote: >> >> Currently, if a device read request is done that does not begin or end >> >> on a sector boundary

Re: [U-Boot] FDT without FIT?

2011-08-23 Thread Wolfgang Denk
Dear Simon Schwarz, In message <4e53c9f6.4010...@gmail.com> you wrote: > > How can FDT be used without a FIT image? I don't understand this question - using the FDT and the image format are orthogonal to each other. > I can't really get this from the code - if someone can point me in the > rig

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Wolfgang Denk
Dear Ralph Metzler, In message <20051.51102.404246.81248@morden.metzler> you wrote: > > So, I introduced "pxa168_mac" as Linux command line argument to pass > ethaddr to pxa168_eth. Or does anybody have a better solution? Add device tree support for your board, and pass the MAC address in the dev

Re: [U-Boot] [ELDK] global variables

2011-08-23 Thread Wolfgang Denk
Dear Detlev Zundel, In message you wrote: > > So currently as U-Boot is its own loader, we accept the fact that .bss > will be cleared on relocation. Actually I don't even know if it is > correct at all to use .bss variables before then (if you look around, > you'll find the "global_data" struc

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 05:19:39 Lukasz Majewski wrote: > On Mon, 22 Aug 2011 11:57:57 -0700 Anton Staaf wrote: > > drivers/mmc/mmc.c: ext_csd in mmc_change_freq is allocated on the stac > > drivers/mmc/mmc.c: scr and switch_status in sd_change_freq are > > allocated on the stack. > > drivers/m

Re: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

2011-08-23 Thread Mike Frysinger
On Monday, August 22, 2011 17:48:47 Anton Staaf wrote: > On Mon, Aug 22, 2011 at 2:42 PM, Wolfgang Denk wrote: > > Anton Staaf wrote: > >> Currently, if a device read request is done that does not begin or end > >> on a sector boundary a stack allocated bounce buffer is used to perform > >> the rea

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 11:30:38 Ralph Metzler wrote: > Wolfgang Denk writes: > > > ok I just wanted to clear myself.. I do not have a dedicated hardware > > > storage in my ethernet controller so I will just look into environment > > > variable ethaddr, if its set I will just copy it to dri

[U-Boot] [PATCH] mmc: dcache: allocate cache aligned buffer for scr and switch_status

2011-08-23 Thread Anton Staaf
Currently the sd_change_freq function allocates two buffers on the stack that it passes down to the MMC device driver. These buffers could be unaligned to the L1 dcache line size. This causes problems when using DMA and with caches enabled. This patch correctly cache alignes the buffers used for

Re: [U-Boot] [PATCH] arm: tegra2: fix out-of-tree build

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 3:03 AM, Che-Liang Chiou wrote: > The out-of-tree build fails because the Makefiles in question depend on > source files of another directory but do not explicitly mkdir that > directory. > > As a matter of fact, other Makefiles under board/*/ directory that refer > to sour

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Anton Staaf
On Tue, Aug 23, 2011 at 2:19 AM, Lukasz Majewski wrote: > Hi Anton, > > On Mon, 22 Aug 2011 11:57:57 -0700 > Anton Staaf wrote: > >> drivers/mmc/mmc.c: ext_csd in mmc_change_freq is allocated on the stac >> drivers/mmc/mmc.c: scr and switch_status in sd_change_freq are >> allocated on the stack.

[U-Boot] FDT without FIT?

2011-08-23 Thread Simon Schwarz
Hi list, I'am a bit stuck here. How can FDT be used without a FIT image? I can't really get this from the code - if someone can point me in the right direction this would be great! Thanks! Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://l

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ralph Metzler
Wolfgang Denk writes: > > ok I just wanted to clear myself.. I do not have a dedicated hardware > > storage in my ethernet controller so I will just look into environment > > variable ethaddr, if its set I will just copy it to driver layer and > > if it is not set, I let the user set it. He/She

Re: [U-Boot] [ELDK] global variables

2011-08-23 Thread Detlev Zundel
Hi Tim, > Thank you very much. > I'm using ELDK4.2. I just defined my global variable in lib_ppc/board.c, > here we have three functions: board_init_f(), board_init_r(), > Reset_Watchdog(). > Reset_Watchdog() will be called in board_init_f(), board_init_r(). > > here as below is my code, > /*

Re: [U-Boot] [PATCH v5] ARM: Add Calxeda Highbank platform

2011-08-23 Thread Rob Herring
Albert, On 08/21/2011 02:28 PM, Rob Herring wrote: > On 08/21/2011 09:40 AM, Albert ARIBAUD wrote: >> Hi Rob, >> >> Le 21/08/2011 15:16, Rob Herring a écrit : >>> From: Rob Herring >>> >>> Add basic support for Calxeda Highbank platform. Only minimal support >>> with >>> serial and SATA are includ

Re: [U-Boot] [PATCH] add dm9000 eeprom read/write command

2011-08-23 Thread Stefano Babic
On 08/23/2011 03:42 PM, Mike Frysinger wrote: > On Tuesday, August 23, 2011 01:15:25 Eric Jarrige wrote: >> On 22 août 2011, at 23:55, Mike Frysinger wrote: >>> On Monday, August 22, 2011 17:37:42 Eric Jarrige wrote: +#if (!defined(CONFIG_DM9000_NO_SROM) && defined(CONFIG_DRIVER_DM9000)) >>> >

[U-Boot] [PATCH] da850evm: Move LPSC configuration to board_early_init_f()

2011-08-23 Thread Christian Riesch
Since commit f1d2b313c9eb6808d30c16a9eb5251240452a56c the serial port of the da850evm is accessed before the UART2 peripheral of the SoC is powered on in the function board_init() in board/davinci/da8xxevm/da850evm.c. When u-boot is used in conjunction with the UBL (user boot loader, see doc/READM

Re: [U-Boot] [PATCH 7/9] DM9000:Add a byte swap macro for dm9000 io operation.

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 01:47:54 Jason Jin wrote: > +#ifndef DM9000_BYTE_SWAPPED should be CONFIG_XXX -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailma

Re: [U-Boot] [PATCH] add dm9000 eeprom read/write command

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 01:15:25 Eric Jarrige wrote: > On 22 août 2011, at 23:55, Mike Frysinger wrote: > > On Monday, August 22, 2011 17:37:42 Eric Jarrige wrote: > >> +#if (!defined(CONFIG_DM9000_NO_SROM) && defined(CONFIG_DRIVER_DM9000)) > > > > why is this necessary ? > > the methods dm90

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Wolfgang Denk
Dear Ajay Bhargav, In message <1570238601.123783.1314104389736.javamail.r...@ahm.einfochips.com> you wrote: > > ok I just wanted to clear myself.. I do not have a dedicated hardware > storage in my ethernet controller so I will just look into environment > variable ethaddr, if its set I will jus

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Wolfgang Denk" wrote: > Dear Ajay Bhargav, > > In message > <1058764603.122757.1314095393033.javamail.r...@ahm.einfochips.com> you > wrote: > > > > > I think someone NAKed this whole part with MAC randomisation and > he was right > > > about it ... you're supposed to configure the MAC

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108222100.25104.vap...@gentoo.org> you wrote: > > >If you look at the current code - heavily larded with #ifdefs of > >all shapes and colors - I cannot see any good way to transform this > >into an initcall (and thus sequence number based) implementa

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Wolfgang Denk" wrote: > Dear Ajay Bhargav, > > In message > <1058764603.122757.1314095393033.javamail.r...@ahm.einfochips.com> you > wrote: > > > > > I think someone NAKed this whole part with MAC randomisation and > he was right > > > about it ... you're supposed to configure the MAC

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-23 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > 1. I think we should change the code in a different order. I would > > prefer to first unify the init code across architectures (the big > > ARM reorganization we just seem to have overcome was an important > > prerequisite for this), before

Re: [U-Boot] [STATUS] ARM

2011-08-23 Thread Michael Jones
Hi Albert, On 08/22/2011 10:15 AM, Simon Schwarz wrote: > > Hi Albert, > > On 08/20/2011 01:12 PM, Albert ARIBAUD wrote: >> snip> >> >> Sandeep has requested that I pick these two in u-boot-arm. >> > > > So is right that everything else in the responsibility of Sandeep won't > make it into t

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Wolfgang Denk
Dear Eric Jarrige, can you please mind your line length? It is strongly recommended that text lines should not exceed 70 characters or so. Thanks. In message <1fad4112-2a57-415d-9cdf-8fc7a9edb...@armadeus.org> you wrote: > >> +#define CONFIG_EXTRA_ENV_SETTINGS \ > >> + "env_version="

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Wolfgang Denk
Dear Ajay Bhargav, In message <1058764603.122757.1314095393033.javamail.r...@ahm.einfochips.com> you wrote: > > > I think someone NAKed this whole part with MAC randomisation and he was > > right > > about it ... you're supposed to configure the MAC properly yourself. ... > MAC randomization i

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Tuesday, August 23, 2011 08:11:57 AM Ajay Bhargav wrote: > > - "Marek Vasut" wrote: > > > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > > > This patch adds support for Fast Ethernet Controller driver for > > > > Armada100 series. > > > > > >

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Marek Vasut
On Tuesday, August 23, 2011 08:11:57 AM Ajay Bhargav wrote: > - "Marek Vasut" wrote: > > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > > This patch adds support for Fast Ethernet Controller driver for > > > Armada100 series. > > > > > > Signed-off-by: Ajay Bhargav > > > ---

[U-Boot] [PATCH] arm: tegra2: fix out-of-tree build

2011-08-23 Thread Che-Liang Chiou
The out-of-tree build fails because the Makefiles in question depend on source files of another directory but do not explicitly mkdir that directory. As a matter of fact, other Makefiles under board/*/ directory that refer to source files under another directory explicitly call mkdir. This patch

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-23 Thread Stefano Babic
On 08/15/2011 10:25 PM, Eric Jarrige wrote: > Hi Stefano, Hi Eric, sorry for my late answer. I have missed a point. >>> +#define CONFIG_EXTRA_ENV_SETTINGS \ >>> + "env_version=" CONFIG_ENV_VERSION "\0"\ >>> + "fileaddr=" MK_STR(CONFIG_SYS_LOAD_ADDR)"

Re: [U-Boot] [PATCH] add dm9000 eeprom read/write command

2011-08-23 Thread Stefano Babic
On 08/22/2011 11:37 PM, Eric Jarrige wrote: > Signed-off-by: Eric Jarrige > Signed-off-by: Stefano Babic > CC: Ben Warren I think we should drop Ben's name as maintainer for the network because he retired some times ago, but his name is still in the maintainer list. Wolfgang is the maintainer

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Lukasz Majewski
Hi Anton, On Mon, 22 Aug 2011 11:57:57 -0700 Anton Staaf wrote: > drivers/mmc/mmc.c: ext_csd in mmc_change_freq is allocated on the stac > drivers/mmc/mmc.c: scr and switch_status in sd_change_freq are > allocated on the stack. > drivers/mmc/mmc.c: ext_csd in mmc_startup is allocated on the stac

[U-Boot] OMAP3 ONFI support

2011-08-23 Thread Simon Schwarz
Hi list, OMAP3 uses fixed timings for GPMC NAND communication from what I see in mem.c. Is there a reason not to use ONFI detection? There seems to be ONFI support in nand_base. Regards Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.d

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-23 Thread Lukasz Majewski
Hi Mike, On Mon, 22 Aug 2011 12:08:42 -0400 Mike Frysinger wrote: > On Monday, August 22, 2011 03:29:52 Lukasz Majewski wrote: > > On Fri, 19 Aug 2011 11:35:50 -0400 Mike Frysinger wrote: > > > On Friday, August 19, 2011 11:28:18 Lukasz Majewski wrote: > > > > On Fri, 19 Aug 2011 09:57:10 -0400

[U-Boot] [PATCH v6 1/2] i2c:gpio:s5p: I2C GPIO Software implementation (via soft_i2c)

2011-08-23 Thread Lukasz Majewski
This patch adds support for software I2C for GONI and Universal C210 reference targets. It adds support for access to GPIOs by number, not as it is present, by bank and offset. Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park Cc: Minkyu Kang Cc: Heiko Schocher --- Changes for v2:

[U-Boot] [PATCH v2 2/2] i2c:gpio:s5p: Enable I2C GPIO on the GONI target

2011-08-23 Thread Lukasz Majewski
This patch enables the software I2C for GONI reference target. Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park Cc: Minkyu Kang Cc: Heiko Schocher --- Changes for v2: - Replace explicit GPIO definition with more readable one --- include/configs/s5p_goni.h | 12 ++

  1   2   >