Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-30 Thread Mike Frysinger
On Sat, Apr 30, 2011 at 10:34, Tabi Timur-B04825 wrote: > Mike Frysinger wrote: >> so implement this in your board file in misc_init_r or board_eth_init.  have >> the code do something like: >>       uchar enetaddr[6]; >>       if (!eth_getenv_enetaddr("ethaddr", enetaddr)) { >>               /* ..

[U-Boot] [PATCH] IDE: fix compiler warnings

2011-04-30 Thread Wolfgang Denk
The changes introduced by commit 0abddf8 ``cmd_ide: enhance new feature "CONFIG_IDE_AHB"'' caused compiler warnings like cmd_ide.c: In function 'ide_init': cmd_ide.c:716: warning: assignment from incompatible pointer type Constify the respective function arguments to fix this. Signed-off-by: Wol

Re: [U-Boot] [PATCH] common/cmd_mdio.c: fix compile warning

2011-04-30 Thread Wolfgang Denk
Dear Anatolij Gustschin, In message <1304167169-22651-1-git-send-email-ag...@denx.de> you wrote: > cmd_mdio.c: In function 'mdio_read_ranges': > cmd_mdio.c:97: warning: comparison is always false due to limited range of > data type > > Signed-off-by: Anatolij Gustschin > Cc: Andy Fleming > ---

Re: [U-Boot] [PATCH] miiphy: miiphyutil.c: fix compile warning

2011-04-30 Thread Wolfgang Denk
Dear Anatolij Gustschin, In message <1304165864-10499-1-git-send-email-ag...@denx.de> you wrote: > Fix warning introduced while recent PHY Lib changes: > > miiphyutil.c: In function 'miiphy_read': > miiphyutil.c:304: warning: comparison is always false due to limited range of > data type > > Si

Re: [U-Boot] [GIT PULL] Pull request u-boot-mpc85xx.git

2011-04-30 Thread Wolfgang Denk
Dear Kumar Gala, In message you wrote: > > The following changes since commit a000b7950da938d2df37ec5e081cd0680e6e4bbe: ... > Trübenbach, Ralf (1): > powerpc/85xx: Fix Wrong PCIe 3 virtual address on corenet_ds platforms It appears you are changing the commit messages without notice? The

Re: [U-Boot] Pull request: u-boot-arm/master

2011-04-30 Thread Wolfgang Denk
Dear Macpaul Lin, In message you wrote: > > > Is this a bug fix? ... > It is about code clean up, avoid relocation prolem for > global declaration, and reorganinzed structures for > better coding style. > > Also add some enhancement according to correct datasheet > which is used by other SoC th

Re: [U-Boot] [PATCH] xilinx_emaclite.c ping-pong macro names

2011-04-30 Thread Wolfgang Denk
Dear alain.pet...@space.unibe.ch, In message <20110415144908.16476jnz1wxcp...@mail.unibe.ch> you wrote: > > Please find attached the checked patch. Sorry for the inconvenience. Please send patches inline. No attachments! And please stick to the rules with updated versions - mark the version in t

Re: [U-Boot] [PATCH v3] cmd_nvedit.c: clean up with checkpatch

2011-04-30 Thread Wolfgang Denk
Dear Macpaul Lin, In message <1303870605-31401-1-git-send-email-macp...@andestech.com> you wrote: > Code clean up of cmd_nvedit.c by using checkpatch.pl. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Replace the ident characters for #ifdef from space to tab. > Changes for v3: >

Re: [U-Boot] [PATCH 2/6] NET: pass source IP address to packet handlers

2011-04-30 Thread Wolfgang Denk
Dear Luca Ceresoli, In message <1302796377-3321-3-git-send-email-luca.ceres...@comelit.it> you wrote: > This is needed for the upcoming TFTP server implementation. > > This also simplifies PingHandler() and fixes rxhand_f documentation. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk Un

Re: [U-Boot] [PATCH 2/6] NET: pass source IP address to packet handlers

2011-04-30 Thread Wolfgang Denk
Dear Luca Ceresoli, In message <1302796377-3321-3-git-send-email-luca.ceres...@comelit.it> you wrote: > This is needed for the upcoming TFTP server implementation. > > This also simplifies PingHandler() and fixes rxhand_f documentation. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > -

Re: [U-Boot] [PATCH 1/6] README: remove spurious line

2011-04-30 Thread Wolfgang Denk
Dear Luca Ceresoli, In message <1302796377-3321-2-git-send-email-luca.ceres...@comelit.it> you wrote: > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > --- > README |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Softwar

Re: [U-Boot] [PATCH 4/4] MergerBox: add board specific files in vendor dir.

2011-04-30 Thread Wolfgang Denk
Dear Andre Schwarz, In message <1302786707-15359-5-git-send-email-andre.schw...@matrix-vision.de> you wrote: > > Signed-off-by: Andre Schwarz There is a ton ot checkpatch warnings and errors. Please ix these. ... > +int fpga_config_fn(int assert, int flush, int cookie) > +{ > + volatile i

Re: [U-Boot] [PATCH 3/4] MergerBox: add maintainer and boards.cfg entries.

2011-04-30 Thread Wolfgang Denk
Dear Andre Schwarz, In message <1302786707-15359-4-git-send-email-andre.schw...@matrix-vision.de> you wrote: > > Signed-off-by: Andre Schwarz > --- > MAINTAINERS |1 + > boards.cfg |1 + > 2 files changed, 2 insertions(+), 0 deletions(-) Your patch splitting is incorrect. After this

Re: [U-Boot] [PATCH 2/4] MergerBox: add documentation.

2011-04-30 Thread Wolfgang Denk
Dear Andre Schwarz, In message <1302786707-15359-3-git-send-email-andre.schw...@matrix-vision.de> you wrote: > > Signed-off-by: Andre Schwarz > --- > doc/README.mergerbox | 59 > ++ > 1 files changed, 59 insertions(+), 0 deletions(-) > create

Re: [U-Boot] [PATCH 1/4] MergerBox: Add board config file.

2011-04-30 Thread Wolfgang Denk
Dear Andre Schwarz, In message <1302786707-15359-2-git-send-email-andre.schw...@matrix-vision.de> you wrote: > > Signed-off-by: Andre Schwarz > --- > include/configs/MERGERBOX.h | 619 > +++ > 1 files changed, 619 insertions(+), 0 deletions(-) > creat

Re: [U-Boot] [PATCH] MPC837x: set i2c1_clk Running on mpc837x without CONFIG_FSL_ESDHC leads to i2c1_clk not being set at all. It is bound to clock of encryption module. fix this.

2011-04-30 Thread Wolfgang Denk
Dear Andre Schwarz, In message <1302785597-14449-1-git-send-email-andre.schw...@matrix-vision.de> you wrote: > > Signed-off-by: Andre Schwarz > --- Subject WAY TOO LONG. Please truncate, and provide a proper commit message instead. Best regards, Wolfgang Denk -- DENX Software Engineering G

Re: [U-Boot] [PATCH] MatrixVision common code: use getenv_f instead of snprintf.

2011-04-30 Thread Wolfgang Denk
Dear Andre Schwarz, In message <1302785522-14393-1-git-send-email-andre.schw...@matrix-vision.de> you wrote: > > Signed-off-by: Andre Schwarz It appears this commit contains some unrelated changes? > - "static_ipaddr", "static_netmask", "static_gateway", > + "static_ipaddr", "static_n

Re: [U-Boot] [PATCH v5 3/5] Add documentation for USB Host Networking

2011-04-30 Thread Wolfgang Denk
Dear Simon Glass, In message <1303266585-15701-3-git-send-email-...@chromium.org> you wrote: > This describes what it is for, devices supported, how to enable for your > board in U-Boot, setting up the server, and notes about MAC addresses. > > Signed-off-by: Simon Glass > --- > doc/README.usb

Re: [U-Boot] [RFC] Act as a TFTP server

2011-04-30 Thread Wolfgang Denk
Dear Luca Ceresoli, In message <4da59b5e.5000...@comelit.it> you wrote: > > >> Usage:tftpsrv [] > >> > >> This would be used almost like tftpboot, except no file name is specified > >> on > >> the commandline. > >>would default to the environment variable. > > I see some user interfac

Re: [U-Boot] [RFC] Allow for parallel builds and saved output

2011-04-30 Thread Wolfgang Denk
Dear Andy Fleming, In message <1302687759-1649-1-git-send-email-aflem...@freescale.com> you wrote: > The MAKEALL script cleverly runs make with the appropriate options > to use all of the cores on the system, but your average U-Boot build > can't make much use of more than a few cores. If you hap

Re: [U-Boot] [PATCH 3/5] Add documentation for USB Host Networking

2011-04-30 Thread Wolfgang Denk
Dear Simon Glass, In message <1302642840-6958-3-git-send-email-...@chromium.org> you wrote: > This describes what it is for, devices supported, how to enable for your > board in U-Boot, setting up the server, and notes about MAC addresses. > > Signed-off-by: Simon Glass ... > +If you have a sup

Re: [U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-04-30 Thread Wolfgang Denk
Dear Sergei Shtylyov, In message <201104122323.59105.sshtyl...@ru.mvista.com> you wrote: > Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it > tries to read the MBR into 512-byte buffer situated on stack. Instead allocate > this buffer dynamically to be safe with any l

Re: [U-Boot] [PATCH] cfi_flash driver: fixed addressing for 8-bit flash buses.

2011-04-30 Thread Aaron Williams
Will do. I've been quite busy lately bringing up a 32-core chip and getting ready for a release but I should have some time now. I've got some other patches I also need to submit. -Aaron On 04/30/2011 12:12 PM, Wolfgang Denk wrote: > Dear Aaron Williams, > > In message > <1302594796-26276-1-git

Re: [U-Boot] [PATCH] cfi_flash driver: fixed addressing for 8-bit flash buses.

2011-04-30 Thread Wolfgang Denk
Dear Aaron Williams, In message <1302594796-26276-1-git-send-email-aaron.willi...@caviumnetworks.com> you wrote: > This patch corrects the addresses used when working with Spansion/AMD FLASH > chips. Addressing for 8 and 16 bits is almost identical except in the 16 > bit case the LSB of the addr

Re: [U-Boot] [PATCH v2 2/2] ftide020: add faraday ide ahb controller

2011-04-30 Thread Wolfgang Denk
Dear Macpaul Lin, In message <1302590733-23912-2-git-send-email-macp...@andestech.com> you wrote: > Faraday's ftide020_s is an IDE-AHB controller for SoC design. > This patch add the u-boot driver (PIO) of ftide020 ATA (IDE) driver. > IDE commands include read, info, and other functions has been i

Re: [U-Boot] [PATCH v2 1/2] cmd_ide: enhance new feature "CONFIG_IDE_AHB"

2011-04-30 Thread Wolfgang Denk
Dear Macpaul Lin, In message <1302590733-23912-1-git-send-email-macp...@andestech.com> you wrote: > Although most IDE controller is designed to be connected to PCI bridge, > there are still some IDE controller support AHB interface for SoC design. > > The driver implementation of these IDE-AHB co

Re: [U-Boot] [PATCH v4] spi: add new driver for OpenCores tiny_spi

2011-04-30 Thread Wolfgang Denk
Dear Thomas Chou, In message <1302587327-4699-1-git-send-email-tho...@wytron.com.tw> you wrote: > This patch adds support for OpenCores tiny_spi. > > http://opencores.org/project,tiny_spi > > Signed-off-by: Thomas Chou > --- > for u-boot > v2, use const and clean up as Mike suggested. > v3, use

Re: [U-Boot] [PATCH] powerpc/85xx: Add support for 2nd USB controller on p1_p2_rdb

2011-04-30 Thread Wolfgang Denk
Dear Kumar Gala, In message <1302373351-19192-1-git-send-email-ga...@kernel.crashing.org> you wrote: > From: Ramneek Mehresh > > Second USB controller only works for SPI and SD boot because of pin muxing > > Signed-off-by: Ramneek Mehresh ... > +int misc_init_r(void) > +{ > +#if defined(CONFI

Re: [U-Boot] [PATCH] powerpc/p4080: Add support for secure boot flow on CoreNet Based QorIQ chips

2011-04-30 Thread Wolfgang Denk
Dear Kumar Gala, In message <1302373725-21799-1-git-send-email-ga...@kernel.crashing.org> you wrote: ... > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c > b/arch/powerpc/cpu/mpc85xx/cpu_init.c > index 6f256cf..aafb007 100644 > --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c > +++ b/arch/powerpc/cpu

Re: [U-Boot] [PATCH] zlib: split up to match original source tree

2011-04-30 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1302301410-1135-1-git-send-email-vap...@gentoo.org> you wrote: > While looking to upgrade to zlib-1.2.5, the current mondo merge of > multiple files into a single was making things way more difficult > than it should have been. Hard to pick out what has been chang

Re: [U-Boot] [PATCH v3 1/4] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

2011-04-30 Thread Rabin Vincent
On Thu, Apr 14, 2011 at 04:03, Simon Glass wrote: > On Wed, Apr 13, 2011 at 12:16 PM, Andy Fleming wrote: >>> +       read_buf &= ~HW_CFG_RXDOFF_; >>> + >>> +#ifdef CONFIG_TEGRA2 >>> +       /* Tegra2 requires NET_IP_ALIGN = 0 */ >>> +#define NET_IP_ALIGN 0 >>> +#else >>> +       /* set Rx data o

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-30 Thread Tabi Timur-B04825
Mike Frysinger wrote: > so implement this in your board file in misc_init_r or board_eth_init. have > the code do something like: > uchar enetaddr[6]; > if (!eth_getenv_enetaddr("ethaddr", enetaddr)) { > /* ... read current MAC out of the driver's registers ... */ >

[U-Boot] [PATCH] common/cmd_mdio.c: fix compile warning

2011-04-30 Thread Anatolij Gustschin
cmd_mdio.c: In function 'mdio_read_ranges': cmd_mdio.c:97: warning: comparison is always false due to limited range of data type Signed-off-by: Anatolij Gustschin Cc: Andy Fleming --- common/cmd_mdio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cmd_mdio.

[U-Boot] [PATCH] miiphy: miiphyutil.c: fix compile warning

2011-04-30 Thread Anatolij Gustschin
Fix warning introduced while recent PHY Lib changes: miiphyutil.c: In function 'miiphy_read': miiphyutil.c:304: warning: comparison is always false due to limited range of data type Signed-off-by: Anatolij Gustschin Cc: Andy Fleming --- common/miiphyutil.c | 12 1 files changed

Re: [U-Boot] [Test] [u-boot] u-boot timing analysis

2011-04-30 Thread Wolfgang Denk
Dear manohar kallutla, In message you wrote: > > could you please let me know the steps to identify the timing of u-boot. As > u-boot gives the control to kernel, there won't be any u-boot code is > running on processor right. The easiest way is to print appropriate messages on a serial console

Re: [U-Boot] [Test] [u-boot] u-boot timing analysis

2011-04-30 Thread manohar kallutla
Hi Wolfgang, thanks for your reply, this is not a test mail. could you please let me know the steps to identify the timing of u-boot. As u-boot gives the control to kernel, there won't be any u-boot code is running on processor right. Thanks and regards, Manohar.K On Wed, Apr 27, 2011 at 2:40

[U-Boot] Adding spi support for SH7757 processor.

2011-04-30 Thread manohar kallutla
Hi , I am newbie to the u-boot loader. I have one external CPLD which has connected to processor via spi protocol. My requirement is to support CPLD from u-boot (eg:- read registers and write registers etc) Could you please help me ,how to follow the steps to implement this functionality. I have

Re: [U-Boot] [PATCH 24/30] km/common: add pnvramsize to default environment

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message you wrote: > From: Holger Brunck > > The pnvram size was used later from start scripts in linux. Therefore > it must be set inside u-boot. How does this work? A plain setenv() here just adds an entry to the hash table where U-Boot stores the variables. T

Re: [U-Boot] [PATCH 23/30] km/common: replace env var checkboardidlist by function

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message you wrote: > From: Thomas Herzmann > > The environment variable (defining a checkboardidlist function) > has been replaced by a u-boot function call. This call is much > faster and the environment is a leaner. ... > + p = get_local_var("IVM_BoardId"); >

Re: [U-Boot] [PATCH 22/30] km/common: implement setboardid as a command

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message <30d7413306aba80ca4540c3353d884bdffe9a643.1302272395.git.valentin.longch...@keymile.com> you wrote: > From: Holger Brunck > > Read out board id and HW key from the IVM eeprom and set > these values as an environment variable was now done inside the > code as

Re: [U-Boot] [PATCH 21/30] common/hush: make get_local_var visible for other users

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message you wrote: > From: Holger Brunck > > Signed-off-by: Holger Brunck > Acked-by: Heiko Schocher > cc: Wolfgang Denk > cc: Detlev Zundel > cc: Valentin Longchamp > Signed-off-by: Valentin Longchamp What is the rationale for this change? Best regards, W

Re: [U-Boot] [PATCH 17/30] cramfs: make cramfs usable without a NOR flash

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message you wrote: > From: Heiko Schocher > > Signed-off-by: Heiko Schocher > cc: Wolfgang Denk > cc: Detlev Zundel > cc: Valentin Longchamp > cc: Holger Brunck > Signed-off-by: Valentin Longchamp > --- > common/cmd_cramfs.c | 12 +++- > fs/cramfs/

Re: [U-Boot] [PATCH 10/30] arm/km: add addbootcount environment variable

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message you wrote: > From: Holger Brunck > > This environment variable is used to set the bootcount address > for the kernel. "addbootcount" reads to me as "add something to the boot counter". I do not expect that this has anything to do with an address. Please us

Re: [U-Boot] [PATCH 08/30] powerpc/km82xx: rename mgcoge2ne to mgcoge3ne board support

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message you wrote: > From: Holger Brunck > > This patch rename mgcoge2ne board support to mgcoge3ne. > The board is similar to mgcoge. The difference is that > a NUMONYX flash is used and a larger SDRAM (256MB). > Also introduce CONFIG_KM_82XX to collect ppc82xx co

Re: [U-Boot] [PATCH 06/30] powerpc/km82xx: move SDRAM config to board config

2011-04-30 Thread Wolfgang Denk
Dear Valentin Longchamp, In message <08249e40b548fff1e636cecf980e11adabda14ac.1302272395.git.valentin.longch...@keymile.com> you wrote: > From: Holger Brunck > > To be prepared for mgcoge3ne which has a different SDRAM on board. > The config was moved from generic code to board specific header

Re: [U-Boot] [PATCH 5/7] JFFS2: Change DEFAULT_EMPTY_SCAN_SIZE to 256 Bytes

2011-04-30 Thread Wolfgang Denk
Dear Baidu Liu, In message you wrote: > > > A patch description should include _all_ changes. Either you also put > > that change into the patch description or you make a separate change. > > Doing changes not described in the commit log are a good sign to show > > that one does not care what o

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-30 Thread Mike Frysinger
On Friday, April 29, 2011 06:20:36 Wolfgang Denk wrote: > Andy Fleming wrote: > > It's just that the other way would also be possible. I re-read the > > thread where this was discussed, and while I definitely agree that the > > originally proposed solution was highly error-prone, I think > > *allow