Re: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support

2011-01-08 Thread Minkyu Kang
Hi On 9 January 2011 10:14, seedshope wrote: > On 01/08/2011 11:15 PM, Minkyu Kang wrote: >> >> Dear seedshope, >> >> On 8 January 2011 00:53, seedshope  wrote: >>> >>> From: seedshope >>> >>> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >>> >>> start.o: In function `clbss_l': >>> nand

Re: [U-Boot] [PATCH] spi: add new driver for OpenCores tiny_spi

2011-01-08 Thread Mike Frysinger
On Saturday, January 08, 2011 18:56:03 Thomas Chou wrote: > + */ > +#include space between comment and includes > +#include > +#define TINY_SPI_RXDATA 0 space between includes and defines > +static struct tiny_spi_host tiny_spi_host_list[] = CONFIG_SYS_TINY_SPI_LIST; i think you only read t

Re: [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

2011-01-08 Thread seedshope
On 01/08/2011 11:17 PM, Albert ARIBAUD wrote: > Le 08/01/2011 16:10, seedshope a écrit : >> On 01/08/2011 01:55 PM, Albert ARIBAUD wrote: >>> Le 07/01/2011 16:53, seedshope a écrit : From: seedshope CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM and substract the global size

Re: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support

2011-01-08 Thread seedshope
On 01/08/2011 11:15 PM, Minkyu Kang wrote: > Dear seedshope, > > On 8 January 2011 00:53, seedshope wrote: >> From: seedshope >> >> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >> >> start.o: In function `clbss_l': >> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to

[U-Boot] [PATCH] spi: add new driver for OpenCores tiny_spi

2011-01-08 Thread Thomas Chou
This patch adds support for OpenCores tiny_spi. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou --- drivers/spi/Makefile |1 + drivers/spi/oc_tiny_spi.c | 241 + 2 files changed, 242 insertions(+), 0 deletions(-) create mod

Re: [U-Boot] [RFC PATCH 6/8] omap3_beagle: add nand_spl support

2011-01-08 Thread John Rigby
On Sat, Jan 8, 2011 at 1:33 AM, Aneesh V wrote: > John, > On Saturday 08 January 2011 12:16 PM, John Rigby wrote: >> >> On Fri, Jan 7, 2011 at 11:33 PM, Aneesh V  wrote: >>> >>> Hi John, >>> >>> On Tuesday 28 December 2010 06:17 AM, John Rigby wrote: Signed-off-by: John Rigby +

Re: [U-Boot] [PATCH RFC] armv7: fixloop: don't fixup if location is NULL

2011-01-08 Thread Andreas Bießmann
Dear Albert ARIBAUD, Am 08.01.2011 um 13:18 schrieb Albert ARIBAUD: > Le 08/01/2011 11:49, Albert ARIBAUD a écrit : > >>> In my investigations for 'NULL fixup' (-> see >>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/89864/focus=89906) >>> pointed out that only symbols in 'absolute fix

Re: [U-Boot] [PATCH RFC] armv7: fixloop: don't fixup if location is NULL

2011-01-08 Thread Joakim Tjernlund
> > Le 08/01/2011 11:49, Albert ARIBAUD a écrit : > > >> In my investigations for 'NULL fixup' (-> see > >> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/89864/focus=89906) > >> pointed out that only symbols in 'absolute fixup' loop could be 'NULL' > >> if there is a not aliased/empty weak

Re: [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

2011-01-08 Thread Albert ARIBAUD
Le 08/01/2011 16:10, seedshope a écrit : > On 01/08/2011 01:55 PM, Albert ARIBAUD wrote: >> Le 07/01/2011 16:53, seedshope a écrit : >>> From: seedshope >>> >>> CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM >>> and substract the global size. >>> >>> Signed-off-by: seedshope >> Please fix the F

Re: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support

2011-01-08 Thread Minkyu Kang
Dear seedshope, On 8 January 2011 00:53, seedshope wrote: > From: seedshope > > Modify u-boot.lds from nand_spl/board/samsung/smdk6400. > > start.o: In function `clbss_l': > nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to > `coloured_LED_init' > nand_spl/board/samsung/smdk64

Re: [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared

2011-01-08 Thread seedshope
On 01/08/2011 01:55 PM, Albert ARIBAUD wrote: > Le 07/01/2011 16:53, seedshope a écrit : >> From: seedshope >> >> CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM >> and substract the global size. >> >> Signed-off-by: seedshope > Please fix the From: line in all patches in this set; it should not

Re: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support

2011-01-08 Thread seedshope
On 01/08/2011 02:14 PM, Albert ARIBAUD wrote: > Hi seedshope, > > Le 07/01/2011 16:53, seedshope a écrit : >> From: seedshope >> >> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. > You're also modifying start.S. If you mention files in the patch > summary, then please mention them all. ok

Re: [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer

2011-01-08 Thread seedshope
On 01/08/2011 02:04 PM, Albert ARIBAUD wrote: > Le 07/01/2011 16:53, seedshope a écrit : >> From: seedshope >> >> Remove u-boot-nand.lds from board/samsung/smdk6400 and >> use the common u-boot.lds of arm1176 cpu layer. This >> patch also fix the building errors: >> >> arch/arm/cpu/arm1176/s3c64xx/

Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7

2011-01-08 Thread Albert ARIBAUD
Le 08/01/2011 14:17, Aneesh V a écrit : >> Why use pointers here rather than weak functions? > > In fact, I hadn't thought about it. Maybe I was biased by the Linux > implementation.The only reason I can think of is that pointer gives the > flexibility of doing this assignment at run-time. Let's s

Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7

2011-01-08 Thread Aneesh V
On Saturday 08 January 2011 12:06 PM, Albert ARIBAUD wrote: > Hi Aneesh, Pressed the Send button too fast last time. Missed answering the last few questions. >> + >> +void invalidate_dcache_all(void) >> +{ >> +v7_maint_dcache_all(ARMV7_DCACHE_INVAL_ALL); >> +if (v7_outer_cache.inval_all)

Re: [U-Boot] [PATCH RFC] armv7: fixloop: don't fixup if location is NULL

2011-01-08 Thread Albert ARIBAUD
Le 08/01/2011 11:49, Albert ARIBAUD a écrit : >> In my investigations for 'NULL fixup' (-> see >> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/89864/focus=89906) >> pointed out that only symbols in 'absolute fixup' loop could be 'NULL' >> if there is a not aliased/empty weakly linked sym

Re: [U-Boot] "b reset" does not work in u-boot_v2010.12-rc3 with eldk4.2

2011-01-08 Thread Wolfgang Denk
Dear "MrGates", please always keep the mailing list on cc: In message you wrote: > >> These indicate that in start.S,first instruction:b reset not jump success > > > > What do you mean by that statement? > I am sorry that i have no clear. > I mean that "b reset"statement does not jump t

Re: [U-Boot] [PATCH RFC] armv7: fixloop: don't fixup if location is NULL

2011-01-08 Thread Albert ARIBAUD
Le 08/01/2011 11:32, Andreas Bießmann a écrit : > Dear Minkyu Kang, > > Am 27.12.2010 um 11:27 schrieb Minkyu Kang: > >> There is possibility that pointers set to NULL before relocation. >> In this case, system is hang, because of r0 is invalid location in RAM. >> >> Signed-off-by: Minkyu Kang >> -

Re: [U-Boot] [PATCH RFC] armv7: fixloop: don't fixup if location is NULL

2011-01-08 Thread Andreas Bießmann
Dear Minkyu Kang, Am 27.12.2010 um 11:27 schrieb Minkyu Kang: > There is possibility that pointers set to NULL before relocation. > In this case, system is hang, because of r0 is invalid location in RAM. > > Signed-off-by: Minkyu Kang > --- > arch/arm/cpu/armv7/start.S |3 +++ > 1 files chan

Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7

2011-01-08 Thread Aneesh V
Hi Albert, On Saturday 08 January 2011 12:06 PM, Albert ARIBAUD wrote: > Hi Aneesh, > > Le 22/12/2010 12:54, Aneesh V a écrit : >> - Add a framework for layered cache maintenance >> - separate out SOC specific outer cache maintenance from >>maintenance of caches known to CPU >> >> - A

[U-Boot] USB EHCI support

2011-01-08 Thread Aaron Williams
I'm working on adding EHCI support for our chips to U-Boot and I'm a bit confused. In our case I have to replace the ehci_read/writel macros since all of our EHCI registers are located starting at 0x800016F000400 (notice it's a 64-bit address). Anyway, to get back to my comment, it seems th

Re: [U-Boot] [PATCH 4/8] arm: minor fixes for cache and mmu handling

2011-01-08 Thread Aneesh V
Hi Albert, On Saturday 08 January 2011 12:34 PM, Albert ARIBAUD wrote: > Hi Aneesh, > > Le 22/12/2010 12:54, Aneesh V a écrit : >> 1. make sure that page table setup is not done multiple times >> 2. flush_dcache_all() is more appropriate while disabling cache >> than a range flush on the enti

Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7

2011-01-08 Thread Albert ARIBAUD
Le 08/01/2011 07:36, Albert ARIBAUD a écrit : >> --- a/arch/arm/cpu/armv7/config.mk >> +++ b/arch/arm/cpu/armv7/config.mk >> @@ -23,7 +23,7 @@ >>PLATFORM_RELFLAGS += -fno-common -ffixed-r8 -msoft-float >> >># Make ARMv5 to allow more compilers to work, even though its v7a. >> -PLATFORM_CPP

Re: [U-Boot] [RFC PATCH 6/8] omap3_beagle: add nand_spl support

2011-01-08 Thread Aneesh V
John, On Saturday 08 January 2011 12:16 PM, John Rigby wrote: > On Fri, Jan 7, 2011 at 11:33 PM, Aneesh V wrote: >> Hi John, >> >> On Tuesday 28 December 2010 06:17 AM, John Rigby wrote: >>> >>> Signed-off-by: John Rigby >>> + >>> +void board_init_f(unsigned long bootflag) >>> +{ >>> + nand_

Re: [U-Boot] [PATCH 3/8] armv7: integrate cache maintenance support

2011-01-08 Thread Aneesh V
Hi Albert, On Saturday 08 January 2011 12:24 PM, Albert ARIBAUD wrote: > Hi Aneesh, > > Le 22/12/2010 12:54, Aneesh V a écrit : >> - Enable I-cache on bootup >> - Enable MMU and D-cache immediately after relocation >> - Do necessary initialization before enabling d-cache and MMU >> - Changes

Re: [U-Boot] [PATCH] Fix CONFIG_CMD_SHA1SUM

2011-01-08 Thread Albert ARIBAUD
Le 04/01/2011 09:04, Alexander Holler a écrit : > Am 04.01.2011 08:47, schrieb Alexander Holler: > >> Only CONFIG_CMD_SHA1SUM should have been used. >> --- >>README |2 +- >>common/cmd_mem.c |4 ++-- >>2 files changed, 3 insertions(+), 3 deletions(-) >> > > Sorry, have f