[U-Boot] [PATCH 1/1] ARM Add New Board GEC2410 rev2

2009-11-05 Thread Hui.Tang
Signed-off-by: Hui.Tang --- checkpatch.pl shows total: 0 errors, 0 warnings, 1249 lines checked 0001-ARM-Add-New-Board-GEC2410.patch has no obvious style problems and is ready for submission. MAINTAINERS |4 + MAKEALL |1 + Makefi

Re: [U-Boot] [PATCH] Save environment data to mmc.

2009-11-05 Thread Lv Terry-R65388
Hi Mike, I will fix the two issues you pointed. Thanks a lot. Actually, env_mmc.c is written based on env_nand.c in u-boot 1.3.3. I have modified it according to the latest changes in environment code. But seems there's still a lot of issue. Sorry for that. It

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Tom
Wolfgang Denk wrote: > Dear Tom, > > In message <4af339e1.9060...@windriver.com> you wrote: >> The arguments for using weak are getting weak :P > > :-P > >> Using weak is less relevant with the #ifdef's > > But it's the wrong direction your heading. We should get rid of > #ifdef's, not add new

Re: [U-Boot] [PATCH] NAND: Update to support 64 bit device size

2009-11-05 Thread Paulraj, Sandeep
> > On Fri, Oct 30, 2009 at 01:51:23PM -0400, s-paul...@ti.com wrote: > > From: Sandeep Paulraj > > > > This patch adds support for NANDs greater than 2 GB. > > Patch is based on the MTD NAND driver in the kernel. > > > > Signed-off-by: Sandeep Paulraj > > Applied to u-boot-nand-flash/next, wi

Re: [U-Boot] [PATCH 3/3] [OneNAND] Flex-OneNAND boundary settings

2009-11-05 Thread Scott Wood
On Wed, Nov 04, 2009 at 10:39:41AM +0530, Amul Kumar Saha wrote: > while (blocks) { > + blocksize = onenand_blocksize(ofs); > + > ret = mtd->block_isbad(mtd, ofs); > if (ret) { > printk("Bad blocks %d at 0x%x\n", > -

Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-11-05 Thread Scott Wood
On Wed, Nov 04, 2009 at 10:37:17AM +0530, Amul Kumar Saha wrote: > This patch adds support for Flex-OneNAND devices. > > Signed-off-by: Rohit Hagargundgi > Signed-off-by: Amul Kumar Saha A couple 64-bit offset nits... > +static void flexonenand_get_size(struct mtd_info *mtd) > +{ > + struc

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Wolfgang Denk
Dear Tom, In message <4af339e1.9060...@windriver.com> you wrote: > > The arguments for using weak are getting weak :P :-P > Using weak is less relevant with the #ifdef's But it's the wrong direction your heading. We should get rid of #ifdef's, not add new ones. With #ifdef's, you have differen

Re: [U-Boot] [RFC] env: Group environment variables

2009-11-05 Thread John Schmoller
On Thu, 2009-11-05 at 23:37 +0100, Wolfgang Denk wrote: > Dear John, > > In message <1257452739.8937.1166.ca...@johns> you wrote: > > > > > Also, it would be nice if "prontenv" now would allow to print a group, > > > i. e. in your example something as "printenv net pci" should be > > > supported.

Re: [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak

2009-11-05 Thread Wolfgang Denk
Dear Tom, In message <4af33815.4030...@windriver.com> you wrote: > > >> Signed-off-by: Abdoulaye Walsimou Gaye > > > > What is this? Are you sure this patch is properly attributed? Was > > Abdoulaye Walsimou Gaye really the first to submit this patch? > > > > Best regards, > > > > Wolfgang De

Re: [U-Boot] [RFC] env: Group environment variables

2009-11-05 Thread Wolfgang Denk
Dear John, In message <1257452739.8937.1166.ca...@johns> you wrote: > > > Also, it would be nice if "prontenv" now would allow to print a group, > > i. e. in your example something as "printenv net pci" should be > > supported. > > This is already (accidentally :) supported. a "printenv $net" wo

Re: [U-Boot] [PATCH] NAND: Update to support 64 bit device size

2009-11-05 Thread Scott Wood
On Fri, Oct 30, 2009 at 01:51:23PM -0400, s-paul...@ti.com wrote: > From: Sandeep Paulraj > > This patch adds support for NANDs greater than 2 GB. > Patch is based on the MTD NAND driver in the kernel. > > Signed-off-by: Sandeep Paulraj Applied to u-boot-nand-flash/next, with a few whitespace

Re: [U-Boot] [PATCH 10/10] omap3evm: musb: add USB config

2009-11-05 Thread Remy Bohmer
Hi Tom and Ajay, 2009/11/4 Tom Rix : > From: Ajay Kumar Gupta > > Added USB host and device config for host (MSC, Keyboard) and > device (ACM) functionalities. > > Signed-off-by: Ajay Kumar Gupta > --- >  include/configs/omap3_evm.h |   39 +++ >  1 files chang

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Tom
Wolfgang Denk wrote: > Dear Tom Rix, > > In message <1257292804-10612-2-git-send-email-tom@windriver.com> you > wrote: >> The ARM board LED functions are defined as weak. >> They add a size overhead if they are not used. >> >> Now they are only defined if CONFIG_STATUS_LED is also defined. >>

Re: [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak

2009-11-05 Thread Tom
Wolfgang Denk wrote: > Dear Tom Rix, > > In message <1257292804-10612-3-git-send-email-tom@windriver.com> you > wrote: >> From: Abdoulaye Walsimou Gaye >> >> This patch fix build error with gcc-4.4.2 about inline function >> declared weak, see below: >> board.c:96: error: inline function 'co

Re: [U-Boot] [RFC 3/5] CAN device driver for the SJA1000

2009-11-05 Thread Wolfgang Denk
Dear Wolfgang Grandegger, In message <4aef3f18.6000...@grandegger.com> you wrote: > > Well, I think Wolfgang will tell me to use structs sooner than later. Why should I? You already know it! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel H

Re: [U-Boot] [RFC] env: Group environment variables

2009-11-05 Thread John Schmoller
On Thu, 2009-11-05 at 20:57 +0100, Wolfgang Denk wrote: > > > 2) Trying to figure out which enviroment variables have already been printed > > in groups is less than elegant. Currently, it's a brute-force approach of > > looking through every entry until a variable is found in a group or not. >

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Wolfgang Denk
Dear Tom Rix, In message <1257292804-10612-2-git-send-email-tom@windriver.com> you wrote: > The ARM board LED functions are defined as weak. > They add a size overhead if they are not used. > > Now they are only defined if CONFIG_STATUS_LED is also defined. > > The arm920t and arm926ejs _sta

Re: [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak

2009-11-05 Thread Wolfgang Denk
Dear Tom Rix, In message <1257292804-10612-3-git-send-email-tom@windriver.com> you wrote: > From: Abdoulaye Walsimou Gaye > > This patch fix build error with gcc-4.4.2 about inline function > declared weak, see below: > board.c:96: error: inline function 'coloured_LED_init' cannot be declare

Re: [U-Boot] [PATCH] v2 Linuxstamp II 9260 support

2009-11-05 Thread Wolfgang Denk
Dear Paul Thomas, In message you wrote: > > > I have looked at about half of them. > > It looks like partition tables are identical. Right, and such duplication should be avoided. > > I am interested in a way to generalize this file > > and move it to the cpu layer so all the common > > or nea

Re: [U-Boot] AT91 Rework

2009-11-05 Thread Wolfgang Denk
Dear Jens Scharsig, In message <4af1d190.1010...@scharsoft.de> you wrote: > > We discussed the AT91 defs replaced by C structures. > I have checked the AT91 and the AT91RM9200 tree. > I have planned the following procedure: > > 1. Add the CONFIG_AT_LEGACY to all affected boards >(until the b

Re: [U-Boot] [PATCH] use "boot selecr" jumper on NGW100 to select USART

2009-11-05 Thread Wolfgang Denk
Dear Thomas Sprinkmeier, In message you wrote: > Without the "boot select" jumper U-Boot will use the USART selected > using the CONFIG_USART1, CONFIG_USART2, directive. Please fix the typo in the Subject: > If CONFIG_ALT_USART1 (or ..2, ..3, ..0) is defined then, > with the jumper in place,

Re: [U-Boot] Pull request - mpc85xx (for 200911 release) (updated)

2009-11-05 Thread Wolfgang Denk
Dear Kumar Gala, In message you wrote: > Added two trivial patches in > > The following changes since commit b91b8f74fe9ded18344c3d03080a4abc07254502: > Wolfgang Denk (1): > Merge branch 'master' of /home/wd/git/u-boot/custodians > > are available in the git repository at: > > git:

Re: [U-Boot] [RFC] env: Group environment variables

2009-11-05 Thread Wolfgang Denk
Dear John, In message <1257352452-11748-1-git-send-email-jschmol...@xes-inc.com> you wrote: > This patch groups environment variables using a non-invasive protocol. > Grouping is achieved by setting a "grouping" variable to a string of > variables, and setting the master grouping variable, "env_gr

Re: [U-Boot] AT91 Rework

2009-11-05 Thread Jens Scharsig
Dear Wolfgang Denk, > > Umm... you are quite active for AT91 now - the position of the AT91 > is still orphaned; did you ever think about volunteering? > At the moment I'm work for different AT91 (AT91RM9200, AT91SAM9260 and AT91SAM9360) in timeslot mode. But I am fully costumer driven, so that

Re: [U-Boot] [PATCH] Save environment data to mmc.

2009-11-05 Thread Wolfgang Denk
Dear Terry Lv, In message <12574070132761-git-send-email-r65...@freescale.com> you wrote: > This patch is to save environment data to mmc card. > It uses interfaces defined in generic mmc. ... > + if (!crc1_ok && !crc2_ok) > + gd->env_valid = 0; > + else if (crc1_ok && !crc2_ok