[Twisted-Python] If the errbacks of a canceled Deferred are called with error other than CancelledError, is this acceptable?

2013-06-18 Thread zhang kai
If I cancel a Deferred, the errbacks of the Deferred are not called with CancelledError but with other errors like ConnectionDone, is this acceptable? ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailma

[Twisted-Python] TestInternet2.testPickledTimer Failed

2013-07-31 Thread zhang kai
Hi, I'm a Google Summer of Code intern working on "Deferred Cancellation" project. I'm recently working on adding cancellation support to twisted.internet.task.LoopingCall. However, after I added the canceller to LoopingCall.deferred, the twisted.test.test_application.TestInternet2.testPickledTim

Re: [Twisted-Python] TestInternet2.testPickledTimer Failed

2013-08-01 Thread zhang kai
On Thu, Aug 1, 2013 at 7:50 PM, wrote: > I suggest you take a look at TimerService and figure out why pickling one > of those ever tries to pickle a LoopingCall (take a look around > `__getstate__` and `volatile`, I think that's where the problem is). I > think you'll find an existing bug that t

[Twisted-Python] Raising exception from a Deferred canceller.

2013-08-29 Thread zhang kai
Hi, As itamar mentioned in ticket #6676 , If a cancellation function for a Deferred throws an exception(the cancel() method of Deferred won’t throw exceptions, but the canceller may), behavior is undefined. If the cancellation function throws an exception it is currently not ca