DO comment.
-
For my project I use a specific marker for TODO comments so that it
much easier to automate some checks.. (ex no comments for closed
tickets are left in the code) or provide a list with
TODO/tech-debt tickets.
What do you think?
--
On 2 February 2015 at 06:55, Glyph wrote:
>
> On Feb 1, 2015, at 6:16 AM, Adi Roiban wrote:
>
> Hi,
>
> The coding standard contains:
>
> "Comments marked with XXX or TODO must contain a reference to the
> associated ticket."
>
> -
>
>
Server as part of a
Microsoft Partner Network licensing scheme.
We don't have XP, Vista, Win7 licenses.
Cheers,
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/tw
go further and instruct developers not to use the
pyflakes/pylint versions provided by the OS as they might be old or
too new for twistedchecker :)
Cheers,
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.
On 2 February 2015 at 19:18, Glyph Lefkowitz wrote:
[snip]
> Candidates should submit an application to this new list,
> com...@twistedmatrix.com which is a list of links to at least 10 tickets, at
> least 5 of which are patches they've submitted, and at least 5 of which are
> code reviews they've
On 2 February 2015 at 18:48, Glyph Lefkowitz wrote:
>
> On Feb 2, 2015, at 4:16 AM, Adi Roiban wrote:
>
> Hi,
>
> Is this wiki page still valid?
>
> http://twistedmatrix.com/trac/wiki/Windows
>
> I saw that it was not updated in the last 5 years.
>
>
> Ye
r' to have a something
called after startup.
http://twistedmatrix.com/documents/14.0.0/api/twisted.internet.interfaces.IReactorCore.html#addSystemEventTrigger
When you want to stop the reactor, make sure you call it from the
right thread using reactor.callFromThread(reactor.stop)
You can use addSystemEventTrigger to hook into the r
ed developer already know about all those
things and have already read the documentation of virtualenv / pip
and the new documentation of Twisted installation process.
The code snippet from there is just a reminder :)
--
Adi Roiban
___
Twisted-Python mail
On 4 February 2015 at 06:29, Glyph wrote:
>
> On Feb 3, 2015, at 3:26 AM, Adi Roiban wrote:
>
> On 2 February 2015 at 19:18, Glyph Lefkowitz
> wrote:
[snip]
> Meanwhile I will start recording my activity.
>
> For new contributors, I suggest that they can create a wiki
lk about 4 errors, but I can only see one.
The log is full of non-problem info like skip and todo, so I tried to
search for "[ERROR]" string
How can I find the other errors?
Is there a way to see the log only with the problems? Ignoring
skipped/toto test?
Tha
current case.
What do you think?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
for test which take a few second, but for test that take
40minutes I found email notifications much useful.
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 7 February 2015 at 20:32, Glyph wrote:
>
> On Feb 7, 2015, at 6:35 AM, Adi Roiban wrote:
>
> Trac support RST format, so we can maintain those pages in RST... and
> trac wiki allow to view changes as diffs.
>
>
> How does one enable RST formatting in trac? I don
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
?
What do you say if we will also have an UnicodeFilePath class which
only accept Unicode as path input and only outputs Unicode?
It can start with simple path traversal/directory creation/file
creation just to have t.p.moduled (and trial) ported.
Thanks!
--
Adi Roiban
d-dev-tools/issues/11
I think that reviewing patched in less than 2 weeks is critical for
having an active open source project and expecting for developers to
send more patches.
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-P
hanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
could be sent to one of the trendy web services and
have a nice graph.
Does Twisted have this in place?
Do you think this might be useful?
Is there a ticket for that?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
isinstance(someTransport.getHost(), SSHTransportAddress):
pass
I understand the need for endpoints but has somebody implemented an
endpoint which reads an SSHTransportAddress?
Am I the only one who fails to see the advantages of using
SSHTransportAddress over a normal IAddress?
Thanks!
--
Adi
On 18 March 2015 at 05:30, Glyph wrote:
>
> On Mar 17, 2015, at 6:44 AM, Adi Roiban wrote:
>
> Hi,
>
> While trying to fix https://twistedmatrix.com/trac/ticket/5999 I found
> out about the SSHTransportAddress introduced in 12.1.
>
> SSHTransportAddress is just an
On 18 March 2015 at 05:43, Glyph wrote:
>
>> On Mar 16, 2015, at 2:17 AM, Adi Roiban wrote:
>
[snip]
> I'm approximately -0 on this. I don't like the idea of dumping a bunch of
> code into the main Twisted repo that isn't distributed along with Twisted
> (pe
e but the changes are not
reviewed since 8 Feb https://github.com/twisted-infra/braid/pull/77
I can donate time to work on this, just let me know what can I do :)
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
utes or methods. You
> can't do *anything* with an object that only provides `IAddress`.
>
> Jean-Paul
True. I was thinking at IPv4Address and IPv6Address.
Thanks for the follow up. I have change getHost and getPeer for conch
to return SSHTranspor
Nope. Not for my part. +1 for removing it.
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
dispatch them as a nice JSON
https://github.com/chevah/txghserf/blob/master/txghserf/server.py
I find it easy to type needs-review / needs-chagnes ... etc than using
the mouse to set a tag or change the owner of a ticket.
What do you say?
--
Adi Roiban
_
but I could not find the
documentation for this behaviour.
Should I continue searching for the documentation ? or file a ticket?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/ma
On 19 Mar 2015, at 23:26, Adi Roiban wrote:
>>
>> Hi,
>>
>> My usecase is this:
>>
>> When all headers of an HTTP request are received I want to ask a
>> remote service if the
>> request should be accepted and what to do with it.
>>
>&
ata from dataReceived to your FTP data connection...all
this using a consumer/producer API.
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 16 March 2015 at 18:53, Glyph Lefkowitz wrote:
>
> On Mar 16, 2015, at 11:20 AM, Adi Roiban wrote:
>
> Hi,
>
> I would like to ask why the twisted branch name convention ask for
> trailing ticket ID.
>
> Why not leading ID?
>
> some-text-1234 vs 1234-some-t
When running the pyhon3 tests I see many Unhandled Error
ex:
https://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/2736/steps/shell/logs/stdio
This looks bad. Is this a bug in the test runner or a bug in the code?
Thanks!
--
Adi Roiban
ns as up-to-date as possible. Give
> it a look if you're interested, and please suggest improvements.
>
> Thanks,
>
> Christian Long
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
>
Hi,
Without a Trac account you can not create a new ticket or update wiki page.
I just tried to create a new account named 'robot-spammer' and it
looks like it would be extremely easy to automate the process.
Observing notifications on IRC I saw that many spam comments were
posted by dedicated s
ave trial on py3 and we will no longer
need to worry about this primitive test runner.
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
t easier for people to discover it.
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
to projects which are part of Twisted
ecosystem. Any project which imports Twisted can be part of it.
What do you say?
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo
process of testing / reviewing this kind of patches?
Many thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
ubprojects.
I would like to see the subproject developed as independent
projects... this should help enforcing the decoupling and would speed
up the test suite.
Right now if you make a change in twisted.positioning, buildbot will
run all tests :(
--
Adi Roiban
do you say if we add six as dependency for twisted ?
In case you don't want six as a dependency, it can be copied in
twisted code base and make it available from twisted.python.six or a
similar package.
--
Adi Roiban
___
Twisted-Python mailing
wisted-dev-tools / news-builder / pydoctor.
Why should I care about txmongo or need to create a custom filter to
exclude such projects?
As a twisted core dev I should also care for the twisted-infra since
it its results are used by every dev.
[1] https://github.com/issues?user=twist
On 24 April 2015 at 08:25, Glyph wrote:
>
> Many developers don't care about working on the tooling themselves either.
> Why should they have to create a custom filter rather than you?
[snip]
Thanks. No problem!
--
Adi Roiban
___
On 24 April 2015 at 08:00, Glyph wrote:
>
>> On Apr 24, 2015, at 02:41, Adi Roiban wrote:
>>
>> Hi,
>>
>> I feel that twisted.python.compat is slowly duplicating / reinventing
>> an important part of the six code.
>>
>> Code which does not impor
PI docs formatting which hides private methods by
default, we might want to have the log method public so that users
will have a greater change to observer the method and prevent them
from overwriting the method.
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 8 June 2015 at 16:33, Amber "Hawkie" Brown wrote:
snip
> - Fix https://twistedmatrix.com/trac/ticket/7931 to make the Python 3K
> Warnings builder pass
Done. python-3k-warnings is not an official builder :)
--
Adi Roiban
__
I think that it make sense. +1 on this exception.
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
//keybase.io/hawkowl
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
--
Adi Roiban
__
ing on this!
Why are the benchmarks part of twisted-infra and not of twisted ?
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
sues/44
In axiom a class was defined as
class _SiteScheduler(object, Service, SchedulerMixin)
Is this a common practice?
Why do you want to have multiple inheritance and put object as the
first inherited class and not the last one?
Regards,
--
Adi Roiban
___
rather than any bytes.
Thanks for your feedback!
[1] https://github.com/twisted/twisted/compare/trunk...conch-ssh-keys-py3-7998
[2] https://www.ietf.org/rfc/rfc4819.txt
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
ht
wisted.internet.error.ProcessTerminated
exception has an explicit message attribute?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
ticket https://github.com/twisted-infra/braid/issues/102
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
which should focus on
updating the current documentation to include some examples and best
practices.
This email is just to let you know about the new ticket and that it
requires your feedback.
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
I need to care about LP / Ubuntu upstream patches?
Does Twisted has a follow-up process so that upstream patches are
applied in trunk?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi
Hi,
I saw that the osuosl-osx10.6 slave no longer has attached builders.
Is that OK?
If yes, then do we still need this slave?
If we no longer need it maybe we should announce the guy from OSUOSL
to free up this system and remove it from our buildmaster.
Cheers,
--
Adi Roiban
str/int/long ?
-
Is there a way to deprecate a single argument from a method/function?
Since max_age does not comply with the coding convention, can we
deprecated max_age with support for str/int/log and create a new
maxAge argument which only supports by
on GitHub?
>
> -glyph
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
>
> ___
> Twisted-Python mailing list
> Twisted-
lity getter / setter for
keyObject while deprecating it in the same time.
-
I am happy to work or review any code which tries to remove PyCrypto
dependency and work on deprecating current PyCrytpo dependency.
Many thanks for working on this!
--
Adi Roiban
_
?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 5 November 2015 at 00:05, Adi Roiban wrote:
> Hi,
>
> Does anyone know what specifications / RFC is used for implementing
> twisted.conch.ssh.keys.Key.privateBlob ?
>
> https://github.com/twisted/twisted/blob/trunk/twisted/conch/ssh/keys.py#L577
>
> I could not find
hanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
In case you care about Twisted SSH client interacting with very of SSH
servers, please take a look and send your feedback over the Trac issue
Otherwise, feel free to ignore and enjoy the rest of the day /night :)
--
Adi Roiban
___
Twisted-Python
an , break it into small task and start
working on them.
Cheers
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
a/metadata.
GitHub issues are pretty basic and we have little control over
them so at least in the first phase we will not try to migrate to
GitHub issues.
We will just move to cloud based Git hosting as main repo ... and see
how we can migrate form a system based on shell-scripts hooks to
web
://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 20 November 2015 at 10:32, Glyph Lefkowitz
wrote:
> > On Nov 20, 2015, at 12:08 AM, Adi Roiban wrote:
> >
> > It was released before 15.4
> >
> > Twisted Web 15.2.0 (2015-05-18)
> > ===
> >
> > Features
>
On 20 November 2015 at 12:25, Glyph Lefkowitz
wrote:
>
> On Nov 20, 2015, at 1:42 AM, Adi Roiban wrote:
>
>
> On 20 November 2015 at 10:32, Glyph Lefkowitz
> wrote:
>
>> > On Nov 20, 2015, at 12:08 AM, Adi Roiban wrote:
>> >
>> > It was release
deprecatedMember method which is called as a
normal method.
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
ing but since
it is broken and has no tests, I have no idea what this code is expected to
do and how end users are expecting to use it.
Does someone volunteer to fix it?
Otherwise, has anyone any objections against deprecating
twisted/runner/inetdtap.py?
Since it is broken, can
C code. I'd prefer you don't delete the whole
> module though.
>
>
Done https://twistedmatrix.com/trac/ticket/8123
I will go with the deprecation part.
Thanks for the feedback.
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 23 November 2015 at 02:32, Glyph Lefkowitz
wrote:
>
> On Nov 22, 2015, at 07:04, Adi Roiban wrote:
>
> The @deprecated decorator (at leas on py2.7) does not work when paired
> @property
>
> For deprecated instance variables, our deprecation policy recommend
> convert
>
>
>
> Will push the tests and will ask for help in the review queue.
>
> Thanks!
>
>
Another option is to fix @deprecated to call getDeprecationWarningString
when the method is called not when it is created.
Regards
--
Adi Roiban
__
extensions or
encourage people to collaborate toward a single implementation which is
hosted by Twisted?
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo
the meeting - http://doodle.com/poll/4ys8m8qakav9u9f9
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
directions to GitHub code
browser
Since Twisted trunk merges are not busy, I don't think that we need to
worry to much about breaking the dev process... I am more worried about
failing to gather the merges required to create the waiting/testing queue.
--
Adi
>
>
> > On 18 Nov
know if next release
will be16.0 or 15.6.
We can use a 'next-release' tag and when a release is done, check all
tickets and update their tag.
Please send your suggestions and comments.
Thanks!
--
Adi Roiban
___
Twist
On 5 December 2015 at 02:17, Glyph Lefkowitz
wrote:
>
> > On Dec 4, 2015, at 4:51 AM, Adi Roiban wrote:
> >
> > Hi,
> >
> > Please send your suggestions and comments.
>
> By "tags" do you mean "keywords"? If so, couldn't we just
eased version info in the Trac ticket is easier than
searching the NEWS file.
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
my review and add your wisdom :)
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Hi,
On 25 December 2015 at 11:20, Glyph Lefkowitz
wrote:
>
> On Dec 20, 2015, at 9:05 AM, Adi Roiban wrote:
>
> Hi,
>
> What is the purpose of IOpenSSLTrustRoot ?
>
>
> The idea is that we have public functions, mainly `optionsForClientTLS´,
> which need to
here is no conch
> folder.
>
>
> I tried to build twisted from source and conch doesn’t seem to build either
>
> What can I do to solve this?
>
Use Python 2.7 :)
Conch.ssh was not ported to Python 3
Regards
--
Adi Roiban
___
Twi
to make this
happen.
https://github.com/twisted-infra/braid/pull/183
Feel fee to push changes to that branch.
On my installation with about 30 slaves the buildmaster process on py2.7 -
64bit uses 100MB for RES and 1.5G for VIRT CPU usage is very, very
ls with the following error.
>
>
>
Hi,
I think that this is a know issue.
Please see https://twistedmatrix.com/trac/ticket/8159
It would help if you could try the patch and report that all is ok for your
use case.
If not the same issue, please report a new t
FYI. Amber has merged the branch adding @deprecatedProperty
https://twistedmatrix.com/trac/ticket/8124 and the issue raised in this
ticket is solved
Thanks!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http
gt; the Twisted Software Foundation, the developers who contributed code as
> well as documentation, and all the people building great things with
> Twisted!
>
> Twisted Regards,
> Amber Brown (HawkOwl)
>
This is also the release in which the code
ython on Windows and I am not sure if
Travis-ci.org will support this free of charge.
I think that we can have both... and in the first instance automatically
trigger Travis-CI builds and manually trigger buildbot builds.
--
GitLab is an op
ave python 2.7 coverage .
Is is still acceptable to touch that code ? :)
Regards,
Adi
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 28 May 2016 at 08:48, Glyph wrote:
>
> On May 27, 2016, at 13:46, Glyph wrote:
>
> On May 27, 2016, at 06:31, Adi Roiban wrote:
>
> On 27 May 2016 at 13:13, Itamar Turner-Trauring
> wrote:
>
> 2. They're doing one particular incompatibility at a time, rath
commiters
will no longer have to merge and send to buildbot each new revision
submitted by a contributor.
Cheers,
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
sted's
official review queue (https://twistedmatrix.com/trac/report/25) which is
already huge.
Thanks again Craig and keep up the good work ! :)
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
t; correspondence in the meanwhile.
>
>
Is there a wiki page, a ticket or some place where switching to the 'review
queue' as GitHub PR list is discussed or brainstormed?
I could not find any reference in the git migration plan
https://github.com/twisted-infra/braid/m
document it as part
of the work for ticket #8368
Regards,
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On 13 June 2016 at 22:35, Glyph wrote:
>
> On Jun 13, 2016, at 4:20 AM, Adi Roiban wrote:
>
> Is there a wiki page, a ticket or some place where switching to the
> 'review queue' as GitHub PR list is discussed or brainstormed?
>
>
> Thus far all discussion has
PR contributor has an
account in Trac and that the contributor will receive notifications for all
the discussions done in the Trac ticket.
AFAIK the PR are just replacing the attached patched to a Trac ticket. The
review should still be done in the Trac ticket.
Cheers,
--
Adi Roiban
___
On 13 June 2016 at 22:46, Glyph wrote:
>
> On Jun 13, 2016, at 4:26 AM, Adi Roiban wrote:
>
> Hi,
>
> What is the best practice for deprecating a class in Twisted and writing
> tests for it ... and updating existing tests.
>
>
> We appear to have 'assertDeprec
g the buildbot status,
codecoverage and then adding comments, rather than also creating branches
in twisted, updating Trac ticket, trigger buildbot builds, composing the
merge message and doing the actual merge and push :)
Many thanks Craig for your hel
automation, it will work with both methods...
but hopefully people will prefer 1234.
For me is easier to auto-complete branches based on id.
Cheers,
Adi
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedm
On 14 June 2016 at 05:24, Glyph wrote:
>
>
> I'm the owner of txghbot. I hope it ends up being useful for Twisted!
>
>
> I strongly suspect that it will be the official solution. Thanks so much
> for doing this - the existence of this code is a structural expression of
> the setup process which
rs you see when interacting with buildbot here, over
#twisted-admin or by creating a new issue here
https://github.com/twisted-infra/braid/issues
Have a good day!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.co
!
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
refactored... but
I think that the topic of ignoring missing coverage is still valid.
I suggest to introduce ` # pragma: no cover`
and update the coverage config with
[report]
exclude_lines =
pragma: no cover
---
What do you think?
Thanks!
--
Adi Roiban
ckSpace.
BTW. I see that the Windows slave is pretty busy sometimes. Can we add a
Windows slave hosted by Rackspace? (I think that Glyph or Amber can answer
this)
--
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twis
1 - 100 of 405 matches
Mail list logo
