Re: [Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

2020-06-03 Thread Glyph
> On May 28, 2020, at 3:13 PM, Tom Most wrote: > > On Fri, May 22, 2020, at 10:54 PM, Glyph wrote: >> So, pidfd's cool, we should totally use it. Also we should use posix_spawn >> and maybe some other stuff too. But I wonder if there's any heuristic we >> could use to speed up our current str

Re: [Twisted-Python] log.callWithLogger not used - slows down reactor?

2020-06-03 Thread Glyph
> On Jun 2, 2020, at 4:54 AM, Barry Scott wrote: > > I'm hunting down performance issue in our code and spotted this in > passing. As far I can tell nothing seems to need callWithLogger. > > I ran our 6k+ tests with this patch applied and everything worked. > > Does anything in the twisted wo

Re: [Twisted-Python] log.callWithLogger not used - slows down reactor?

2020-06-03 Thread Barry Scott
On Wednesday, 3 June 2020 08:07:37 BST Glyph wrote: > > On Jun 2, 2020, at 4:54 AM, Barry Scott > > wrote: > > > > I'm hunting down performance issue in our code and spotted this in > > passing. As far I can tell nothing seems to need callWithLogger. > > > > I ran our 6k+ tests with this patch a