Re: [Twisted-Python] Twisted 18.9.0 Release Announcement

2018-10-23 Thread Evilham
Am 22/10/2018 um 10:33 schrieb Glyph: >> - twisted.internet._sslverify.ClientTLSOptions no longer raises IDNAError >> when given an IPv6 address as a hostname in a HTTPS URL. > This is twisted.internet.ssl.optionsForClientTLS for those of you who are not > maintaining Twisted's innards :-). > A

[Twisted-Python] Etiquette of tagging people for reviews?

2018-10-23 Thread Wim Lewis
Every project seems to have its own norms around this. When I have some code in a reviewable state, I will sometimes look for someone who has recently worked on that piece of code or similar features and request a review from them, just to get the ball rolling. Is this a reasonable thing to do

Re: [Twisted-Python] Etiquette of tagging people for reviews?

2018-10-23 Thread Glyph
> On Oct 23, 2018, at 10:21 PM, Wim Lewis wrote: > > Every project seems to have its own norms around this. When I have some code > in a > reviewable state, I will sometimes look for someone who has recently worked > on > that piece of code or similar features and request a review from them