On 26 November 2017 at 05:36, Glyph wrote:
>
>> On Nov 25, 2017, at 8:52 PM, Adi Roiban wrote:
>>
>> Do you see anything suspicious with this code?
>
> Just that it looks like it leaves a Deferred in an error state. You said the
> tests weren’t “written using” trial, but are you running them wit
Hi,
What is the procedure for accepting patches for platforms for which we
don't have a continuous testing system ?
This is a follow up of the review from
https://twistedmatrix.com/trac/ticket/9323
There is a patch for Cygwin but AFAIK there is no current builder for
running Twisted with Python
> On Nov 26, 2017, at 10:23 AM, Adi Roiban wrote:
>
> Hi,
>
> What is the procedure for accepting patches for platforms for which we
> don't have a continuous testing system ?
>
> This is a follow up of the review from
> https://twistedmatrix.com/trac/ticket/9323
>
> There is a patch for Cygw
> On Nov 26, 2017, at 5:10 AM, Adi Roiban wrote:
>
> On 26 November 2017 at 05:36, Glyph wrote:
>>
>>> On Nov 25, 2017, at 8:52 PM, Adi Roiban wrote:
>>>
>>> Do you see anything suspicious with this code?
>>
>> Just that it looks like it leaves a Deferred in an error state. You said the
>
On Sun, Nov 26, 2017 at 5:30 PM, Glyph wrote:
>
>
> Quite often—as I believe is the case for the patch you’re referring to
> here—patches are adjusting behaviors which would be difficult to cleanly
> integration-test on the platform in question anyway, and the appropriate
> thing to do is to make
