Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread jabir Mohammed (jamohamm)
Hi Team, Wanted to bring one code changes which is really required from twisted side otherwise it is not behaving as per RFC (rfc4253 Section 7.2), twisted is failing when we negotiate any kex algorithm based on SHA1 and we have MAC as hmac-sha2-512. The reason for the failure was the below co

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread Adi Roiban
Hi Jarib, Thanks for the details. On 27 March 2017 at 10:33, jabir Mohammed (jamohamm) wrote: > Hi Team, > > Wanted to bring one code changes which is really required from twisted side > otherwise it is not behaving as per RFC (rfc4253 Section 7.2), twisted is > failing when we negotiate any ke

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread jabir Mohammed (jamohamm)
Its a security issue even you are allowing a weaker key in case of 64 bytes deriving only 40 bytes. Let me know how we issue a tracker bug can you please guide me. Since don’t want someone else to waist effort in debugging the same issue. Thanks, Jabir \|/ --- ( o o ) oooO--

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread jabir Mohammed (jamohamm)
No probs Adi, can you help me to upload the fix to the twisted since I don¹t know the procedure, if you can guide me that helps. Since I was pretty sure that this a bug in coding twisted set keys part and not comply to RFC. Thanks, Jabir \|/ --- ( o o ) oooO---O---Oooonull O

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread Adi Roiban
On 27 March 2017 at 12:07, jabir Mohammed (jamohamm) wrote: > > Its a security issue even you are allowing a weaker key in case of 64 bytes > deriving only 40 bytes. Let me know how we issue a tracker bug can you > please guide me. Since don’t want someone else to waist effort in debugging > the s

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread jabir Mohammed (jamohamm)
Please see inline comments [[>> Jamohamm: <<]]. Thanks for the response team. Thanks, Jabir \|/ --- ( o o ) oooO---O---Oooonull On 27/03/17 6:45 pm, "Twisted-Python on behalf of Adi Roiban" wrote: >On 27 March 2017 at 12:07, jabir Mohammed (jamohamm) >wrote: >> >> Its a se

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread Craig Rodrigues
On Mon, Mar 27, 2017 at 2:33 AM, jabir Mohammed (jamohamm) < jamoh...@cisco.com> wrote: > > Can somebody help me to plot this fix so that twisted will work fine with > all the other servers out there and even make it comply to the RFC. Thanks > in advance and this will be my first findings on twis

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread jabir Mohammed (jamohamm)
Thanks Craig shall follow up. Thanks, Jabir \|/ --- ( o o ) oooO---O---Oooonull From: mailto:crodr...@gmail.com>> on behalf of Craig Rodrigues mailto:rodr...@crodrigues.org>> Date: Monday, 27 March 2017 9:38 pm To: Twisted general discussion mailto:twisted-python@twistedmatri