Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

> On 6 Mar 2017, at 09:05, Adi Roiban wrote: > > I am not sure about which code are we talking here. > The specific HTTP11ClientProtocol which will fix only the HTTP client > part or the generic TLSMemoryBIOProtocol code which might fix any TLS > connection? I’m talking about the fact that call

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

On Tue, 7 Mar 2017 at 09:56 Glyph Lefkowitz wrote: > On Mar 6, 2017, at 9:02 PM, Tristan Seligmann > wrote: > > On Tue, 7 Mar 2017 at 06:38 Glyph Lefkowitz > wrote: > > > This is definitely bad, forbidden by existing policy, etc. In fact I > remember adjusting the settings so that the 'merge'

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

On Mon, Mar 6, 2017 at 8:37 PM, Glyph Lefkowitz wrote: > > > Craig, since you're the one who made this merge, can you explain what > happened? Has github's 'merge' button stopped prompting for a commit > message? Failing to wait for the removal of the 'review' keyword was > obviously a mistake,

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

> On Mar 7, 2017, at 10:40 AM, Craig Rodrigues wrote: > > > > On Mon, Mar 6, 2017 at 8:37 PM, Glyph Lefkowitz > wrote: > > > Craig, since you're the one who made this merge, can you explain what > happened? Has github's 'merge' button stopped prompting for