Re: [Twisted-Python] twistedmatrix.com TLS certificate

2017-03-06 Thread Cory Benfield
> On 6 Mar 2017, at 07:22, Tristan Seligmann wrote: > > twistedmatrix.com 's current certificate is issued > by StartCom Certification Authority; for certificates issued by this CA prior > to 2016-09-21, the domain must be on a Chrome whitelist for it to be > accept

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-06 Thread Cory Benfield
> On 5 Mar 2017, at 14:25, Tristan Seligmann wrote: > > On Sun, 5 Mar 2017 at 15:36 Adi Roiban > wrote: > I have observed this while running some end to end tests in which the > pool.closeCachedConnections() deferred was not called, even after a > generous amount of secon

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-06 Thread Adi Roiban
On 6 March 2017 at 08:17, Cory Benfield wrote: > > On 5 Mar 2017, at 14:25, Tristan Seligmann wrote: > > On Sun, 5 Mar 2017 at 15:36 Adi Roiban wrote: >> >> I have observed this while running some end to end tests in which the >> pool.closeCachedConnections() deferred was not called, even after

[Twisted-Python] non-merge commits to trunk & "review" keyword

2017-03-06 Thread Jean-Paul Calderone
Hello, GitHub apparently allows fast-forward merges to trunk. Here's an example of one: https://github.com/twisted/twisted/pull/730 This doesn't seem like a good thing. - The ticket is still open - There is no merge commit - There is no merge commit message - There are non-merge

Re: [Twisted-Python] twistedmatrix.com TLS certificate

2017-03-06 Thread Glyph Lefkowitz
> On Mar 6, 2017, at 12:16 AM, Cory Benfield wrote: > > >> On 6 Mar 2017, at 07:22, Tristan Seligmann > > wrote: >> >> twistedmatrix.com 's current certificate is >> issued by StartCom Certification Authority; for certificates issued

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

2017-03-06 Thread Glyph Lefkowitz
> On Mar 6, 2017, at 6:03 PM, Jean-Paul Calderone > wrote: > > Hello, > > GitHub apparently allows fast-forward merges to trunk. Here's an example of > one: > > https://github.com/twisted/twisted/pull/730 > > > This doesn't seem like a good

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

2017-03-06 Thread Tristan Seligmann
On Tue, 7 Mar 2017 at 06:38 Glyph Lefkowitz wrote: > > This is definitely bad, forbidden by existing policy, etc. In fact I > remember adjusting the settings so that the 'merge' button would always > create a merge commit; in fact, the configuration is still set that way. > Rebase merging was a

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

2017-03-06 Thread Glyph Lefkowitz
> On Mar 6, 2017, at 9:02 PM, Tristan Seligmann wrote: > > On Tue, 7 Mar 2017 at 06:38 Glyph Lefkowitz > wrote: > > This is definitely bad, forbidden by existing policy, etc. In fact I > remember adjusting the settings so that the 'merge' button would always