On 1 July 2016 at 19:34, Craig Rodrigues wrote:
> Hi,
>
> For this pull request:
>
> https://github.com/twisted/twisted/pull/284
>
> This Windows build ran and tried to upload coverage results to codecov:
>
>
> https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7-coverage/builds/623/step
Hi,
What decision should be made based on the feedback sent so far?
Should we disabled the codecov coverage enforcement for 100% coverage for a
patch as it also blocks missing coverage in a test?
If we want to enforce only implementation code, then we need to update the
tests to send separate re
The tests directories can simply be excluded in coverage.py (or codecov), I
don't think there's any need to do something more complicated than that.
While I agree that 100% test coverage is an ideal worth aspiring to, I
think getting there from the current state is going to be a large amount of
wo
HTTP2 support sounds really exciting.
> Please let me know if you have any issues, as well as if you don't! If
everything works well, that's a good thing for me to know :)
I played around with this today and found out that the command you
recommend:
> pip install -U https://twistedmatrix.com/Re
On 3 July 2016 at 11:15, Paweł Miech wrote:
> HTTP2 support sounds really exciting.
>
> > Please let me know if you have any issues, as well as if you don't! If
> everything works well, that's a good thing for me to know :)
>
> I played around with this today and found out that the command you
>
> AFAIK this is a known issue :
Ah thanks, that's ok.
One other thing I noticed a propos HTTP 2 is that it seems that reading
relatively large file results in error:
"priority.priority.MissingStreamError: 'Stream 1 not in tree'". I created
simple gist to recreate this issue see here:
https://gist
On 3 July 2016 at 09:53, Tristan Seligmann wrote:
> The tests directories can simply be excluded in coverage.py (or codecov),
> I don't think there's any need to do something more complicated than that.
>
>
That is, don't report coverage at all for the test code?
I would prefer to see the covera
A bit of an aside... but both personally and in several businesses I work
with, I've use Lastpass to manage passwords. Because the passwords are
shared at the server, updated passwords are propagated to all users. It
also has a really nice 2-factor option where your phone just offers you an
"approv
> On Jul 3, 2016, at 01:53, Tristan Seligmann wrote:
>
> While I agree that 100% test coverage is an ideal worth aspiring to, I think
> getting there from the current state is going to be a large amount of work
> that yields very little benefit at this point in time; I would say that there
>
On Sun, Jul 3, 2016 at 9:10 AM, Glyph Lefkowitz
wrote:
>
> For now, let's just bite the bullet and require 100% patch coverage from
> here on out. If we hit a really nasty case where it really *is* a
> significant investment of effort, then maybe we can revisit this discussion
> and explore a be
> On Jul 3, 2016, at 00:27, Adi Roiban wrote:
>
> I no longer have access to the Win7 VNC as it looks like the password was
> changed.
The password hasn't been changed, so I'm not sure why you're having trouble
accessing it.
-glyph___
Twisted-Pytho
Hi,
I submitted this pull request:
https://github.com/twisted/twisted/pull/224
and codecov is saying that only 66.67% of the patch is covered because it
is not hitting the Python 3 specific block:
https://codecov.io/gh/twisted/twisted/compare/502f3a1e2cc125d214b6b7df5b173aa91fc7f966...d286bf22f8b
On 4 July 2016 at 00:43, Craig Rodrigues wrote:
> Hi,
>
> I submitted this pull request:
> https://github.com/twisted/twisted/pull/224
>
> and codecov is saying that only 66.67% of the patch is covered because it
> is not hitting the Python 3 specific block:
>
> https://codecov.io/gh/twisted/twis
13 matches
Mail list logo
