Re: [Twisted-Python] Porting PB to python3

2016-06-12 Thread Wolfgang Rohdewald
Am Freitag, 10. Juni 2016, 12:39:20 CEST schrieb Craig Rodrigues: > I hope you haven't lost interest in this, and are still willing to push > forward. Maybe in autumn. But I rather hope somebody else would continue with this. -- Wolfgang ___ Twisted-Py

[Twisted-Python] Responding to PRs

2016-06-12 Thread Itamar Turner-Trauring
Hi all, Since we're starting to get PRs from random people it's worth trying to make the process as friendly as possible. So, maybe instead of telling new contribtutors "PRs won't be reviewed without an issue, see contributor guidelines" it would be better to say "Thanks for the PR! I opened

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Craig Rodrigues
Hi, I support this approach. I have a few small suggestions. (1) Give the exact link of some reasonable text that you want people to read. The contributor guidelines are accurate, but the text is verbose. It takes a while to get to the text that gives you the actual steps to follow.

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Adi Roiban
On 12 June 2016 at 21:32, Itamar Turner-Trauring wrote: > Hi all, > > Since we're starting to get PRs from random people it's worth trying to > make the process as friendly as possible. > > So, maybe instead of telling new contribtutors "PRs won't be reviewed > without an issue, see contributor g

Re: [Twisted-Python] Porting PB to python3

2016-06-12 Thread Amber "Hawkie" Brown
> On 13 Jun 2016, at 01:04, Wolfgang Rohdewald > wrote: > > Am Freitag, 10. Juni 2016, 12:39:20 CEST schrieb Craig Rodrigues: >> I hope you haven't lost interest in this, and are still willing to push >> forward. > > Maybe in autumn. But I rather hope somebody else would continue with this. >

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Glyph
> On Jun 12, 2016, at 13:32, Itamar Turner-Trauring wrote: > > Hi all, > > Since we're starting to get PRs from random people it's worth trying to make > the process as friendly as possible. > > So, maybe instead of telling new contribtutors "PRs won't be reviewed without > an issue, see con