[Twisted-Python] Using zope

2016-06-10 Thread Craig Rodrigues
Hi, There are some places in the Twisted code which use zope.interface to do things like: class MyClass: inherits(IMyInterface) That works in Python 2, but the zope.interface library has code to hard fail that line on Python 3. The supported way of doing the same thing on Python 2 and 3 i

[Twisted-Python] Porting PB to python3

2016-06-10 Thread Craig Rodrigues
Hi, I reviewed your branch: https://github.com/wrohdewald/twisted/commits/spread-py3-7598/twisted In my opinion, that branch has two categories of Python 3 porting: Category 1: Minor -> these are "minor" fixos, such as dealing with xrange -> range Category 2: Major -> you have done a lot o

Re: [Twisted-Python] Porting PB to python3

2016-06-10 Thread Amber "Hawkie" Brown
> On 11 Jun 2016, at 03:39, Craig Rodrigues wrote: > > Hi, > > I reviewed your branch: > https://github.com/wrohdewald/twisted/commits/spread-py3-7598/twisted > > In my opinion, that branch has two categories of Python 3 porting: > > Category 1: Minor > -> these are "minor" fixos, such as

[Twisted-Python] Upcoming Buildbot Changes (Ubuntu version support)

2016-06-10 Thread Amber "Hawkie" Brown
Hi everyone, I'm doing some builder work today; including changing the versions of Ubuntu we test on. From next week, our supported Ubuntu platforms will be: - Ubuntu 12.04 (Python 2.7) - Ubuntu 14.04 (Python 2.7) - Ubuntu 16.04 (Python 2.7, Python 3.4, Python 3.5, PyPy (unsupported)) These are