Re: [Twisted-Python] Waiting for transports to close

2015-12-25 Thread Glyph Lefkowitz
> On Dec 19, 2015, at 5:01 AM, Chris Norman > wrote: > > Hello, > > On 17/12/2015 13:03, Glyph Lefkowitz wrote: >> >>> On Dec 17, 2015, at 4:56 AM, Chris Norman < >>> chris.norm...@googlemail.com >>> > wrote: >>> >>>

Re: [Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

2015-12-25 Thread Glyph Lefkowitz
> On Dec 20, 2015, at 9:05 AM, Adi Roiban wrote: > > Hi, > > What is the purpose of IOpenSSLTrustRoot ? The idea is that we have public functions, mainly `optionsForClientTLS´, which need to take a thing that represents a "trust root". We want this to be something that can abstractly be des

Re: [Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

2015-12-25 Thread Adi Roiban
Hi, On 25 December 2015 at 11:20, Glyph Lefkowitz wrote: > > On Dec 20, 2015, at 9:05 AM, Adi Roiban wrote: > > Hi, > > What is the purpose of IOpenSSLTrustRoot ? > > > The idea is that we have public functions, mainly `optionsForClientTLS´, > which need to take a thing that represents a "trust

Re: [Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

2015-12-25 Thread meejah
Glyph Lefkowitz writes: (Thanks for the review, Adi!) > On Dec 20, 2015, at 9:05 AM, Adi Roiban wrote: >> It it documented as a private interface, it has only private methods, >> but then it is exposed in twisted.internet.ssl.optionsForClientTLS >> Why? > Yes, this is intentional. It is a pr

Re: [Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

2015-12-25 Thread Glyph Lefkowitz
> On Dec 25, 2015, at 2:19 PM, Adi Roiban wrote: > > Hi, > > On 25 December 2015 at 11:20, Glyph Lefkowitz > wrote: > >> On Dec 20, 2015, at 9:05 AM, Adi Roiban > > wrote: >> >> Hi, >> >> What is the purpose of IOpenSSLTrustRoot ? > >

Re: [Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

2015-12-25 Thread Glyph Lefkowitz
> On Dec 25, 2015, at 2:35 PM, meejah wrote: > > Glyph Lefkowitz writes: > > (Thanks for the review, Adi!) > >> On Dec 20, 2015, at 9:05 AM, Adi Roiban wrote: > >>> It it documented as a private interface, it has only private methods, >>> but then it is exposed in twisted.internet.ssl.optio