[Twisted-Python] please can haz code review -> Tor-ified Twisted Python HTTP proxy server - txtorhttpproxy

2015-08-11 Thread David Stainton
Dear Twisted/Tor developers, I am motivated by language security concerns. I think Twisted Python can often implement excellent replacements for our old crufty C implementations. In this case I'd like to stop using C programs running as root (or not root) to torify http connections... like privoxy

Re: [Twisted-Python] please can haz code review -> Tor-ified Twisted Python HTT

2015-08-11 Thread Judy Craig
This is an automatic reply. I am away from the office for the summer, returning on Tuesday, August 25, 2015. I will be happy to get back to you then. Enjoy your summer! Judy Craig Student Services This email and any files transmitted with it may be confidential and are intended solely for t

[Twisted-Python] List admin attention

2015-08-11 Thread Phil Mayers
Someone please un-sub this person? Forwarded Message Subject:Re: [Twisted-Python] ANN: Eliot 0.8, the logging system with causality Date: Mon, 10 Aug 2015 12:59:48 -0600 From: Judy Craig Reply-To: Twisted general discussion To: twisted-python@twistedmatr

Re: [Twisted-Python] List admin attention

2015-08-11 Thread Glyph
> On Aug 11, 2015, at 8:33 AM, Phil Mayers wrote: > > Someone please un-sub this person? If I've done my job right this message will not receive an autoreply... -glyph ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedma

Re: [Twisted-Python] List admin attention

2015-08-11 Thread J Todd Ulrich
Yes please remove. Walk Tall.  J Todd Ulrich m. 416.625.3209  Please excuse brevity as this message sent from my BlackBerry 10 smartphone on  the Rogers network.   Original Message   From: Glyph Sent: Tuesday, August 11, 2015 4:49 PM To: Twisted general discussion Reply To: Twisted general discu

[Twisted-Python] incompatible change in 15.3 - something reviewers should look for

2015-08-11 Thread Glyph
In https://twistedmatrix.com/trac/changeset/45163 twisted.internet.application.service.Service to be a new-style class. Just to remind everyone, converting an old-style class to a new-style class is an incompatible change, and reviewers should look for this. We discovered this because this cha

Re: [Twisted-Python] please can haz code review -> Tor-ified Twisted Python HTTP proxy server - txtorhttpproxy

2015-08-11 Thread Aaron Gallagher
David Stainton writes: > If I get rid of this last terrible import: > from twisted.web._newclient import ResponseDone > > then I'm not sure how to detect when to call the finish() method here: > https://github.com/david415/txtorhttpproxy/blob/master/txtorhttpproxy/proxy.py#L38-L52 Fortunately, R

Re: [Twisted-Python] incompatible change in 15.3 - something reviewers should look for

2015-08-11 Thread Adi Roiban
Hi, Thanks for the notice! On 12 August 2015 at 01:24, Glyph wrote: > In https://twistedmatrix.com/trac/changeset/45163 > twisted.internet.application.service.Service to be a new-style class. Just > to remind everyone, converting an old-style class to a new-style class is an > incompatible chan

Re: [Twisted-Python] incompatible change in 15.3 - something reviewers shoul

2015-08-11 Thread Judy Craig
This is an automatic reply. I am away from the office for the summer, returning on Tuesday, August 25, 2015. I will be happy to get back to you then. Enjoy your summer! Judy Craig Student Services This email and any files transmitted with it may be confidential and are intended solely for t