Re: [Twisted-Python] Spurious failure on winxp32-py2.7

2015-01-26 Thread Adi Roiban
On 26 January 2015 at 04:00, Glyph wrote: > > On Jan 25, 2015, at 7:28 AM, exar...@twistedmatrix.com wrote: > > > This test has intermittently failed on Windows since disttrial was merged > into trunk. > > > And, as you yourself pointed out on the ticket, sometimes on Linux too. > > I still have a

Re: [Twisted-Python] hard dependency on setuptools

2015-01-26 Thread Adi Roiban
I think that setuptools is fine. Looking forward to see 3696 merged so that I don't have to manually hunt dependencies and this should help with implementing https://github.com/twisted-infra/twisted-buildbot-configuration/pull/7 Thanks! On 26 January 2015 at 03:50, Glyph wrote: > Hi all, > > I

[Twisted-Python] Review tag for closed tickets

2015-01-26 Thread Adi Roiban
Jean Paul commented that for merged tickets I should remove the review tag. I am lost between wiki pages and sphinx documentation. Where is the place where these these steps are described and maybe I am also not aware of other steps required after a branch is merged? Since the ticket is au

Re: [Twisted-Python] Review tag for closed tickets

2015-01-26 Thread Glyph Lefkowitz
> On Jan 26, 2015, at 11:12 AM, Adi Roiban wrote: > > Jean Paul commented that for merged tickets I should remove the review tag. > > I am lost between wiki pages and sphinx documentation.

Re: [Twisted-Python] Review tag for closed tickets

2015-01-26 Thread Adi Roiban
On 26 January 2015 at 20:11, Glyph Lefkowitz wrote: > > On Jan 26, 2015, at 11:12 AM, Adi Roiban wrote: > > Jean Paul commented that for merged tickets I should remove the review tag. > > I am lost between wiki pages and sphinx documentation. > > >

Re: [Twisted-Python] Review tag for closed tickets

2015-01-26 Thread exarkun
On 26 Jan, 08:51 pm, a...@roiban.ro wrote: The review should be completed before the ticket is merged, so the bot should not be doing this automatically. but in the commit message I do add the author, why not have the bot automatically assign the first author form the list, review merge and cl

Re: [Twisted-Python] Review tag for closed tickets

2015-01-26 Thread Glyph Lefkowitz
> On Jan 26, 2015, at 12:51 PM, Adi Roiban wrote: > > My bad... but then it also state "Make sure that it's green! " ... but > in a previous email I just found out that is ok for twistededchecker > and pyflakes to be red. This was definitely an oversight, so I've updated the wiki page to includ

Re: [Twisted-Python] Spurious failure on winxp32-py2.7

2015-01-26 Thread Glyph Lefkowitz
> On Jan 26, 2015, at 7:56 AM, Adi Roiban wrote: > > On 26 January 2015 at 04:00, Glyph wrote: >> >> On Jan 25, 2015, at 7:28 AM, exar...@twistedmatrix.com wrote: >> >> >> This test has intermittently failed on Windows since disttrial was merged >> into trunk. >> >> >> And, as you yourself