Re: [Twisted-Python] Permissions to trigger buildbot tests

2014-11-25 Thread Adi Roiban
Looks good. I would like to ask write permissions for Twisted SVN repo. For now, I plan to use this power to create branches for tickets in the review queue launch a buildbot test for a submitted patch. I think that this will make my review more useful as the developer could see the exact impact o

[Twisted-Python] HTTP combined log format in twisted.web.http changed from 13.2.0 to 14.0.0

2014-11-25 Thread Free Ekanayaka
Hi, it was line = '%s - - %s "%s" %d %s "%s" "%s"\n' % ( in 13.2.0 (twisted/web/http.py line 1920), and it's u'"%(ip)s" - - %(timestamp)s "%(method)s %(uri)s %(protocol)s" ' so basically the client IP now gets wrapped within double quotes, e.g. a log line that was looking l