Re: [Twisted-Python] naming question before we end up committed...

2014-10-08 Thread Glyph
On Sep 28, 2014, at 8:36 AM, Chris wrote: > +1 for twisted.logger. Since everyone seemed to agree, this is now in review: . -glyph ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.co

[Twisted-Python] a review to speed up other reviews?

2014-10-08 Thread Glyph
is keeping one of the buildbots persistently red. It's in review. There's some discussion on the ticket, If anyone has some free time to review it, this would make other code-reviews go just a little bit faster, since reviewers wouldn't need to kee

Re: [Twisted-Python] a review to speed up other reviews?

2014-10-08 Thread Jonathan Lange
Done. Not reviewed for style guide compliance, and I haven't run it locally or on the build slaves. Hope this helps. On Wed Oct 08 2014 at 8:32:59 AM Glyph wrote: > is keeping one of the > buildbots persistently red. It's in review. There's some dis

Re: [Twisted-Python] a review to speed up other reviews?

2014-10-08 Thread Glyph Lefkowitz
On Oct 8, 2014, at 2:13 AM, Jonathan Lange wrote: > Done. Not reviewed for style guide compliance, and I haven't run it locally > or on the build slaves. Hope this helps. Thanks very much for having a look at this! I'll address the feedback. You shouldn't need to review for style-guide compli

Re: [Twisted-Python] a review to speed up other reviews?

2014-10-08 Thread Jonathan Lange
Comments are on the ticket: https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to reassign when I did the review earlier today. On Wed Oct 08 2014 at 7:37:38 PM Glyph Lefkowitz wrote: > On Oct 8, 2014, at 2:13 AM, Jonathan Lange wrote: > > > Done. Not reviewed for style guide compl

Re: [Twisted-Python] a review to speed up other reviews?

2014-10-08 Thread Glyph Lefkowitz
On Oct 8, 2014, at 11:50 AM, Jonathan Lange wrote: > Comments are on the ticket: > https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to reassign > when I did the review earlier today. Thanks again. If that was intended to be a full review though, you did leave out one importan

Re: [Twisted-Python] a review to speed up other reviews?

2014-10-08 Thread Jonathan Lange
On Wed Oct 08 2014 at 7:54:57 PM Glyph Lefkowitz wrote: > > On Oct 8, 2014, at 11:50 AM, Jonathan Lange wrote: > > Comments are on the ticket: > https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to > reassign when I did the review earlier today. > > > ... > > It *looks* like a "a

[Twisted-Python] Boston Area Twisted Sprint

2014-10-08 Thread exarkun
Hello all, I'm happy to invite you to a Twisted sprint on Saturday, November 1st in Cambridge, Massachusetts. ClusterHQ will be hosting up to twenty (20) Twisted sprinters at the Cambridge Innovation Center ("Coronet City" room) in Kendall Square from 10AM until 11PM. The sprint topics are atte

Re: [Twisted-Python] porting twisted.spread to Python3

2014-10-08 Thread Kevin Horn
On Sun, Oct 5, 2014 at 2:58 PM, wrote: > On 04:23 pm, wolfgang@rohdewald.de wrote: > >> >> BTW what about Ticket 7628, news extension "port"? I could soon start >> feeding porting tickets but if this extension is useful, I guess it >> should be applied first. >> > > Looks like Kevin is workin