[Twisted-Python] naming question before we end up committed...

2014-09-26 Thread Glyph
While working on the package I just brought up in another thread, I realize we have another big new package coming in 14.1, "twisted.python.logger", and I'm wondering what the ".python" part of that package name is doing in there, and what value it adds. It's where "twisted.python.log" used to

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Glyph
On Sep 25, 2014, at 6:36 PM, weykent wrote: > On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz wrote: > >> So, does anyone out there have any code which makes use of the >> aforementioned bad attributes of ThreadPool, whose applications would break >> if I removed them? > > Yes. Specifically, I

Re: [Twisted-Python] naming question before we end up committed...

2014-09-26 Thread Adi Roiban
On 26 September 2014 08:10, Glyph wrote: > While working on the package I just brought up in another thread, I realize > we have another big new package coming in 14.1, "twisted.python.logger", and > I'm wondering what the ".python" part of that package name is doing in there, > and what value

Re: [Twisted-Python] naming question before we end up committed...

2014-09-26 Thread Laurens Van Houtven
+0 on “logger” (top-level names have a history of whimsy) +1 on making it top-level hth lvh signature.asc Description: Message signed with OpenPGP using GPGMail ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/c

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread weykent
On Sep 26, 2014, at 12:43 AM, Glyph wrote: > How about this: would you mind if ThreadPool were modified to still populate > these attributes for monitoring and debugging purposes, but completely > stopped honoring any destructive operations on them? In the case of > "pool.q", there is no sing

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Adi Roiban
On 26 September 2014 08:43, Glyph wrote: [snip] > My inclination would be to expand the thread pool to accommodate these > usages, but still deprecate these attributes in the next version; but add a > better "statistics" method that returned an object with "active", "pending", > and "idle" attrib

Re: [Twisted-Python] Python 3.3 buildslaves

2014-09-26 Thread Adi Roiban
On 15 September 2014 07:38, Glyph wrote: [snip] > Special privileges are required because one of the aspects of buildslave > maintenance is cloud control panel access to the cloud providers that > maintain this hardware, which, if abused, could end up billing the non-profit > which manages Twi

Re: [Twisted-Python] Python 3.3 buildslaves

2014-09-26 Thread exarkun
On 08:26 am, a...@roiban.ro wrote: I think that it would be nice to have some process to initiate new contributors to the whole review process and once one or more senior-reviewers consider that the new contributors is good to do reviews by itself, to give him commit privileges. +1 Jean-Paul

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Christopher Armstrong
On September 25, 2014 at 8:39:54 PM, weykent (weyk...@weasyl.com) wrote: On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz wrote: > So, does anyone out there have any code which makes use of the aforementioned > bad attributes of ThreadPool, whose applications would break if I removed > them? Y

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Jonathan Lange
On Fri, Sep 26, 2014 at 8:43 AM, Glyph wrote: > > On Sep 25, 2014, at 6:36 PM, weykent wrote: > > On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz > wrote: > > So, does anyone out there have any code which makes use of the > aforementioned bad attributes of ThreadPool, whose applications would brea