Re: [Twisted-Python] on contributions

2013-06-05 Thread Adi Roiban
On 5 June 2013 09:29, Glyph wrote: [snip] > So, please, go on contributing patches to Twisted; I thank you for your > contribution and I thank you doubly for your patience. >From my point of view, the fact that reviews take so long is one reason why committing patches to Twisted is not fun. So I

Re: [Twisted-Python] github, again

2013-06-05 Thread Jonathan Ballet
Hi, just shiming in, On Tue, Jun 04, 2013 at 09:55:19PM +0100, Terry Jones wrote: > > So when the code is ready, the feature branch including any accumulated > commits (history) will > > get merged - and not a clean diff against the main repo? > > I'm very far from being a git expert. In fact, I'

Re: [Twisted-Python] on contributions

2013-06-05 Thread Glyph
On Jun 5, 2013, at 12:37 AM, Adi Roiban wrote: > On 5 June 2013 09:29, Glyph wrote: > [snip] > >> So, please, go on contributing patches to Twisted; I thank you for your >> contribution and I thank you doubly for your patience. > > From my point of view, the fact that reviews take so long is

[Twisted-Python] Testing AMP-based code

2013-06-05 Thread Free Ekanayaka
Hi, following up from ticket #6502, I'm looking for recommendations/best practices for writing unit-tests for AMP-based code. As described in the ticket, the issue I'm currently facing is that the AMP implementation is subtly not re-entrant safe and doesn't work with a synchronous transport, for