Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Itamar Turner-Trauring
On Sun, Oct 21, 2012 at 11:00 PM, Glyph wrote: > > This seems like a pretty small benefit; adding a new dependency affects > lots of people and introduces a new point of failure in the installation > process, especially for Windows users who already have a devil of a time > getting Twisted instal

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Jasper St. Pierre
On Sun, Oct 21, 2012 at 11:00 PM, Glyph wrote: > On Oct 21, 2012, at 7:45 PM, Julian Berman wrote: > > This seems like a pretty small benefit; adding a new dependency affects lots > of people and introduces a new point of failure in the installation process, > especially for Windows users who alr

[Twisted-Python] Managing twisted application as init service.

2012-10-22 Thread Maxim Lacrima
Hi, I have been developing an application, which I would like to manage in a fashion similar to scripts placed in /etc/init.d. I.e. I want to start, stop, restart and monitor the application. Currently, I am trying to figure out a correct approach for this. Initially I thought to create a wrapper

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread exarkun
On 03:00 am, gl...@twistedmatrix.com wrote: >On Oct 21, 2012, at 7:45 PM, Julian Berman >wrote: >>The *benefit* though for me in having mock present is that it >>decreases the >>lines of code necessary to write stubs and mocks. While doing so is >>not really >>that difficult anyhow, it *is* jus

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Laurens Van Houtven
So, mock does have an autospec mode, which is not the default, but does result in eg methods undefined on the parent raising AttributeError. I don't know if there's a way to generate a mock from an interface: particularly the fact that interface methods don't have "self" in their signature might t

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread David Reid
On Mon, Oct 22, 2012 at 9:57 AM, Laurens Van Houtven <_...@lvh.cc> wrote: > So, mock does have an autospec mode, which is not the default, but does > result in eg methods undefined on the parent raising AttributeError. > It does, but it won't for instance know that for: mock_agent = mock.Mock

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Glyph
On Oct 22, 2012, at 5:47 AM, Itamar Turner-Trauring wrote: > A testing dependency isn't quite as problematic as a regular dependency; > you'd only need to install it if you wanted to run Twisted's test suite, > which probably most users do not bother with. This actually strikes me as a strong

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Glyph
On Oct 21, 2012, at 9:55 PM, Jasper St. Pierre wrote: > As I said, the issue I had was not "svn diff" -- I had been working on > my fix, uploaded it to Trac, and it was a few months or so before > someone reviewed it. I forget who it was, but the reviewer prompted me > to make a few small style c

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Kevin Horn
On Sun, Oct 21, 2012 at 11:05 PM, Glyph wrote: > On Oct 21, 2012, at 11:57 AM, Duncan McGreggor > wrote: > > I want to use git instead of svn so badly that I can taste it. > Hopefully this provides the motivation necessary to maintain the repo > :-) > > > For what it's worth, I haven't authored

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Sat, Oct 20, 2012 at 4:24 PM, Duncan McGreggor wrote: > Hey all, > > At the sprint today, Glyph mentioned that the github repo hasn't been > updated recently and needs someone to maintain it regularly. He also > mentioned that pull requests would be accepted from github, at which point > I imme

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Kevin Horn
On Sun, Oct 21, 2012 at 9:45 PM, Julian Berman wrote: > Hi. > > I'd like to gauge any interest in (or resistance towards) adding mock > (http://www.voidspace.org.uk/python/mock/mock.html) as a dependency for > the > test suite. > > In short, while I don't necessarily feel strongly about behavior

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Kevin Horn
On Sun, Oct 21, 2012 at 10:00 PM, Glyph wrote: > On Oct 21, 2012, at 7:45 PM, Julian Berman wrote: > > The *benefit* though for me in having mock present is that it decreases the > lines of code necessary to write stubs and mocks. While doing so is not > really > that difficult anyhow, it *is* j

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread David Reid
On Mon, Oct 22, 2012 at 10:55 AM, Duncan McGreggor < oubiw...@twistedmatrix.com> wrote: > On Sat, Oct 20, 2012 at 4:24 PM, Duncan McGreggor > wrote: > > Hey all, > > > > At the sprint today, Glyph mentioned that the github repo hasn't been > > updated recently and needs someone to maintain it reg

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Glyph
On Oct 22, 2012, at 11:30 AM, David Reid wrote: > I'm a little concerned about how you ended up with a thing that which wasn't > mergeable? Could we start by you documenting how you created this repo? Also, how did powdahound create theirs? Understanding the distinction so that other git us

Re: [Twisted-Python] Adding mock as a test suite dependency

2012-10-22 Thread Julian Berman
From: exar...@twistedmatrix.com > Subject: Re: [Twisted-Python] Adding mock as a test suite dependency > > On 03:00 am, gl...@twistedmatrix.com wrote: > >Also I don't particularly like the testing style associated with Mock. > >I think it might discourage us yet further from writing verified fakes

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Mon, Oct 22, 2012 at 11:30 AM, David Reid wrote: > > > On Mon, Oct 22, 2012 at 10:55 AM, Duncan McGreggor > wrote: >> >> On Sat, Oct 20, 2012 at 4:24 PM, Duncan McGreggor >> wrote: >> > Hey all, >> > >> > At the sprint today, Glyph mentioned that the github repo hasn't been >> > updated recen

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Mon, Oct 22, 2012 at 11:49 AM, Glyph wrote: > > On Oct 22, 2012, at 11:30 AM, David Reid wrote: >> >> I'm a little concerned about how you ended up with a thing that which wasn't >> mergeable? Could we start by you documenting how you created this repo? > > > Also, how did powdahound create t

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Mon, Oct 22, 2012 at 12:01 PM, Duncan McGreggor wrote: > On Mon, Oct 22, 2012 at 11:30 AM, David Reid wrote: >> >> >> On Mon, Oct 22, 2012 at 10:55 AM, Duncan McGreggor >> wrote: >>> >>> On Sat, Oct 20, 2012 at 4:24 PM, Duncan McGreggor >>> wrote: >>> > Hey all, >>> > >>> > At the sprint tod

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Glyph
On Oct 22, 2012, at 10:53 AM, Kevin Horn wrote: > > > On Sun, Oct 21, 2012 at 11:05 PM, Glyph wrote: > On Oct 21, 2012, at 11:57 AM, Duncan McGreggor > wrote: > >> I want to use git instead of svn so badly that I can taste it. >> Hopefully this provides the motivation necessary to maintain

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Glyph
On Oct 22, 2012, at 12:01 PM, Duncan McGreggor wrote: > Sure thing. All I did to build a git repo was the usual: > > git svn clone svn://svn.twistedmatrix.com/svn/Twitsed/trunk twisted The spelling error in this command makes me think that maybe you didn't copy the command exactly from where

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Glyph
On Oct 22, 2012, at 12:01 PM, Duncan McGreggor wrote: > ... the local copy ... I should also say that I think it's very important to set up a documented, automated process, ideally on the twistedmatrix.com infrastructure somewhere, that will do the pull and update and stuff. There's already

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Mon, Oct 22, 2012 at 12:23 PM, Glyph wrote: > > On Oct 22, 2012, at 12:01 PM, Duncan McGreggor > wrote: > > Sure thing. All I did to build a git repo was the usual: > > git svn clone svn://svn.twistedmatrix.com/svn/Twitsed/trunk twisted > > > The spelling error in this command makes me think t

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Mon, Oct 22, 2012 at 12:30 PM, Glyph wrote: > On Oct 22, 2012, at 12:01 PM, Duncan McGreggor > wrote: >> >> ... the local copy ... >> > > I should also say that I think it's very important to set up a documented, > automated process, Agreed. > ideally on the twistedmatrix.com infrastructure

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Duncan McGreggor
On Mon, Oct 22, 2012 at 12:04 PM, Duncan McGreggor wrote: > On Mon, Oct 22, 2012 at 12:01 PM, Duncan McGreggor > wrote: >> On Mon, Oct 22, 2012 at 11:30 AM, David Reid wrote: >>> >>> >>> On Mon, Oct 22, 2012 at 10:55 AM, Duncan McGreggor >>> wrote: On Sat, Oct 20, 2012 at 4:24 PM, Dun

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Lucas Taylor
On Oct 21, 2012, at 11:05 PM, Glyph wrote: >> >> The few times I've tried to contributed to Twisted, svn was actually a big >> barrier. Trying to update my patches so that I'm sure the tests pass on >> trunk produced mysterious merge conflicts in files I've never touched. Maybe >> I'm bad at

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Kevin Horn
On Mon, Oct 22, 2012 at 2:22 PM, Glyph wrote: > > On Oct 22, 2012, at 10:53 AM, Kevin Horn wrote: > > > On Sun, Oct 21, 2012 at 11:05 PM, Glyph wrote: >> >> >> For what it's worth, I haven't authored a branch for Twisted with SVN in >> the last 3 years. I use Bazaar almost exclusively and I ge

Re: [Twisted-Python] git repo maintenance

2012-10-22 Thread Glyph
On Oct 22, 2012, at 4:54 PM, Kevin Horn wrote: > On Mon, Oct 22, 2012 at 2:22 PM, Glyph wrote: > > On Oct 22, 2012, at 10:53 AM, Kevin Horn wrote: >> >> On Sun, Oct 21, 2012 at 11:05 PM, Glyph wrote: >> >> For what it's worth, I haven't authored a branch for Twisted with SVN in the >> las