Re: [Twisted-Python] startTLS errors not propagating to Factory

2021-04-29 Thread Glyph
> On Apr 29, 2021, at 3:09 AM, Richard van der Hoff wrote: > Right! That sounds plausible, and certainly gives me some places to poke. > I'll have another look later. Thanks very much! > Glad to help. Looking forward to the resolution on this! For what it's worth: it may also be useful to exp

Re: [Twisted-Python] startTLS errors not propagating to Factory

2021-04-29 Thread Richard van der Hoff
On 29/04/2021 07:36, Glyph wrote: In my tests at least, TLSMemoryBIOProtocol.connectionLost is doing exactly the right thing - it is called with an unhelpful reason, but substitutes back in the helpful reason which has already been stashed. Rather, the problem, as I see it, is that it's not

Re: [Twisted-Python] startTLS errors not propagating to Factory

2021-04-28 Thread Glyph
> On Apr 28, 2021, at 2:43 PM, Richard van der Hoff wrote: > > On 28/04/2021 07:06, Glyph wrote: >>> Is the SMTP code holding the Factory wrong? Or is it reasonable to expect >>> the verification error to propagate into clientConnectionFailed - in which >>> case, how could this work? >>> >>>

Re: [Twisted-Python] startTLS errors not propagating to Factory

2021-04-28 Thread Richard van der Hoff
On 28/04/2021 07:06, Glyph wrote: Is the SMTP code holding the Factory wrong? Or is it reasonable to expect the verification error to propagate into clientConnectionFailed - in which case, how could this work? Thanks for your thoughts! Hi Richard, Sorry for the delayed response here. Th

Re: [Twisted-Python] startTLS errors not propagating to Factory

2021-04-27 Thread Glyph
> On Apr 9, 2021, at 4:07 PM, Richard van der Hoff wrote: > > Hi folks, > > I've been investigating https://github.com/matrix-org/synapse/issues/9566, > which amounts to: "when there is a TLS error connecting to the SMTP server, > the resultant exception is unreadable". > > I think I've trac