Re: [Twisted-Python] failUnlessFailure vs assertFailure

2018-01-03 Thread Glyph
> On Jan 3, 2018, at 1:19 PM, Craig Rodrigues wrote: > > Probably failUnlessFailure as an alias to assertFailure() was done to mimic > some of the deprecations that occurred > in the Python unittest module in Python 2.7: > https://docs.python.org/2/library/unittest.html#deprecated-aliases >

Re: [Twisted-Python] failUnlessFailure vs assertFailure

2018-01-03 Thread Craig Rodrigues
Probably failUnlessFailure as an alias to assertFailure() was done to mimic some of the deprecations that occurred in the Python unittest module in Python 2.7: https://docs.python.org/2/library/unittest.html#deprecated-aliases It would probably be a good idea to change the usage of failUnlessFailu