Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-17 Thread Glyph Lefkowitz
> On Feb 17, 2017, at 9:48 AM, Jean-Paul Calderone > wrote: > > On Thu, Feb 16, 2017 at 12:47 AM, Glyph Lefkowitz > wrote: > >> On Feb 15, 2017, at 6:51 AM, Jean-Paul Calderone > > wrote: >> >> It doesn't sound crazy to say "t

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-17 Thread Jean-Paul Calderone
On Thu, Feb 16, 2017 at 12:47 AM, Glyph Lefkowitz wrote: > > On Feb 15, 2017, at 6:51 AM, Jean-Paul Calderone < > exar...@twistedmatrix.com> wrote: > > It doesn't sound crazy to say "treq 16.12.0 test suite should be required > to pass for Twisted trunk@HEAD (at least until around Twisted 17.12,

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-15 Thread Glyph Lefkowitz
> On Feb 15, 2017, at 6:11 AM, Tristan Seligmann > wrote: > > On Wed, 15 Feb 2017 at 15:23 Jean-Paul Calderone > wrote: > > I wonder about the details of how treq's failures went unnoticed. Is > development sufficiently inactive that no one looked at CI bet

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-15 Thread Glyph Lefkowitz
> On Feb 15, 2017, at 6:51 AM, Jean-Paul Calderone > wrote: > > It doesn't sound crazy to say "treq 16.12.0 test suite should be required to > pass for Twisted trunk@HEAD (at least until around Twisted 17.12, probably?). That seems like a reasonable requirement, yes. -g

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-15 Thread Jean-Paul Calderone
On Wed, Feb 15, 2017 at 9:11 AM, Tristan Seligmann wrote: > On Wed, 15 Feb 2017 at 15:23 Jean-Paul Calderone < > exar...@twistedmatrix.com> wrote: > >> >> I wonder about the details of how treq's failures went unnoticed. Is >> development sufficiently inactive that no one looked at CI between th

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-15 Thread Tristan Seligmann
On Wed, 15 Feb 2017 at 15:23 Jean-Paul Calderone wrote: > > I wonder about the details of how treq's failures went unnoticed. Is > development sufficiently inactive that no one looked at CI between the > breakage and the release? Wasn't that a period of several months? Or does > it have a Twis

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-15 Thread Jean-Paul Calderone
On Wed, Feb 15, 2017 at 3:39 AM, Glyph Lefkowitz wrote: > > On Feb 11, 2017, at 5:54 PM, Jean-Paul Calderone < > exar...@twistedmatrix.com> wrote: > > On Sat, Feb 11, 2017 at 5:03 AM, Amber Hawkie Brown < > hawk...@atleastfornow.net> wrote: > >> On behalf of Twisted Matrix Laboratories, I am hono

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-15 Thread Glyph Lefkowitz
> On Feb 11, 2017, at 5:54 PM, Jean-Paul Calderone > wrote: > > On Sat, Feb 11, 2017 at 5:03 AM, Amber Hawkie Brown > mailto:hawk...@atleastfornow.net>> wrote: > On behalf of Twisted Matrix Laboratories, I am honoured to announce the > release of Twisted 17.1! > > The highlights of this rele

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-14 Thread Glyph Lefkowitz
> On Feb 12, 2017, at 5:00 AM, Tristan Seligmann > wrote: > > On Sun, 12 Feb 2017 at 03:45 Glyph Lefkowitz > wrote: > > Yeah, this is a lack of test coverage for the 'default' case. Technically it > is a regression, but it's probably pretty unusual to use the

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-14 Thread Glyph Lefkowitz
> On Feb 12, 2017, at 4:10 AM, Phil Mayers wrote: > > On 12/02/2017 01:44, Glyph Lefkowitz wrote: > >> Yeah, this is a lack of test coverage for the 'default' case. >> Technically it /is/ a regression, but it's probably pretty unusual to >> use the default; point being, I don't think we need an

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-12 Thread Tristan Seligmann
On Sun, 12 Feb 2017 at 03:45 Glyph Lefkowitz wrote: > > Yeah, this is a lack of test coverage for the 'default' case. Technically > it *is* a regression, but it's probably pretty unusual to use the > default; point being, I don't think we need an emergency release here. > The functionality that

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-12 Thread Phil Mayers
On 12/02/2017 01:44, Glyph Lefkowitz wrote: Yeah, this is a lack of test coverage for the 'default' case. Technically it /is/ a regression, but it's probably pretty unusual to use the default; point being, I don't think we need an emergency release here. Agreed. It's completely tolerable. N

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-11 Thread Jean-Paul Calderone
On Sat, Feb 11, 2017 at 5:03 AM, Amber Hawkie Brown < hawk...@atleastfornow.net> wrote: > On behalf of Twisted Matrix Laboratories, I am honoured to announce the > release of Twisted 17.1! > > The highlights of this release are: > > - twisted.web.client.Agent now supports IPv6! It's also now the p

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-11 Thread Glyph Lefkowitz
> On Feb 11, 2017, at 3:14 PM, Phil Mayers wrote: > > On 11/02/17 18:12, Phil Mayers wrote: >> On 11/02/2017 17:28, Tristan Seligmann wrote: >> >>> String endpoint descriptions, as used by twist/twistd among other >>> things, for listening on tcp ports now require the "tcp:": that is, "80" >>>

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-11 Thread Phil Mayers
On 11/02/17 18:12, Phil Mayers wrote: On 11/02/2017 17:28, Tristan Seligmann wrote: String endpoint descriptions, as used by twist/twistd among other things, for listening on tcp ports now require the "tcp:": that is, "80" is no longer accepted, you need to use "tcp:80". In which case there's

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-11 Thread Phil Mayers
On 11/02/2017 17:28, Tristan Seligmann wrote: String endpoint descriptions, as used by twist/twistd among other things, for listening on tcp ports now require the "tcp:": that is, "80" is no longer accepted, you need to use "tcp:80". In which case there's a regression in the "portforward" twis

Re: [Twisted-Python] Twisted 17.1 Release Announcement

2017-02-11 Thread Tristan Seligmann
On Sat, 11 Feb 2017 at 12:04 Amber Hawkie Brown wrote: > - Lots of deprecated code removals, to make a sleeker, less confusing > Twisted. > Something perhaps not obvious from the release notes: String endpoint descriptions, as used by twist/twistd among other things, for listening on tcp ports