Re: [Twisted-Python] SNI callback with support for deferreds

2015-10-26 Thread Glyph Lefkowitz
> On Oct 26, 2015, at 5:37 AM, Jonathan Stoppani wrote: > > It also needs a serious overhaul on its indentation - something messed up > happened to that code :). > > I don't get it, I see it all as PEP8 compliant (will need to adapt spacing to > Twisted's code standards, but that should be al

Re: [Twisted-Python] SNI callback with support for deferreds

2015-10-26 Thread Jonathan Stoppani
On Mon, Oct 26, 2015 at 3:37 AM, Glyph Lefkowitz wrote: > > The implementation of this solution is available at > https://gist.github.com/GaretJax/124c523a62ba48c9eec1, and I'd like to > contribute it back to Twisted, however, it has no unit tests and needs some > design decisions/validation. > >

Re: [Twisted-Python] SNI callback with support for deferreds

2015-10-25 Thread Glyph Lefkowitz
> On Oct 25, 2015, at 4:54 AM, Jonathan Stoppani wrote: > > Hello, > > A couple of days ago I asked on Stack Overflow about returning a deferred > from an SNI callback and have pyOpenSSL wait for it to fire before continuing > handling the request. > > Thanks to some pointers by Gyph I've fo