Re: [Twisted-Python] Python 3: Odd failure to print unhandled error tb

2018-05-30 Thread Jason Litzinger
> My guess is that since `d` is at the global scope, it doesn't get garbage > collected until some unfortunately late phase in the interpreter tear-down > where maybe stderr isn't even available any more. Here be dragons. > > I'd definitely ignore this case for now and fix the others, which are

Re: [Twisted-Python] Python 3: Odd failure to print unhandled error tb

2018-05-30 Thread Glyph
> On May 30, 2018, at 10:04 PM, Jason Litzinger wrote: > > Any thoughts on why no traceback is printed for case 1? Is it even > worth worrying about? My guess is that since `d` is at the global scope, it doesn't get garbage collected until some unfortunately late phase in the interpreter tea

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Adi Roiban
On 4 July 2016 at 12:27, Craig Rodrigues wrote: > On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > >> >> >> Only the modules (including the test modules) from dist3.py are executed >> on Python3 >> https://github.com/twisted/twisted/blob/trunk/twisted/python/dist3.py >> >> In the header of t

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > > > Only the modules (including the test modules) from dist3.py are executed > on Python3 > https://github.com/twisted/twisted/blob/trunk/twisted/python/dist3.py > > In the header of that file you can see > > # -*- test-case-name: twisted.pytho

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Mon, Jul 4, 2016 at 3:30 AM, Adi Roiban wrote: > > > Is it possible to add the actual invocation of setup.py to coverage? >> > > > That seems like a hole that the actual invocation of setup.py that does >> the build and install >> > > is not part of the coverage reporting. setup.py is just a

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Adi Roiban
On 4 July 2016 at 08:00, Craig Rodrigues wrote: > > > On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > >> >> >> >> On 4 July 2016 at 00:43, Craig Rodrigues wrote: >> >>> Hi, >>> >>> I submitted this pull request: >>> https://github.com/twisted/twisted/pull/224 >>> >>> and codecov is saying

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > > > > On 4 July 2016 at 00:43, Craig Rodrigues wrote: > >> Hi, >> >> I submitted this pull request: >> https://github.com/twisted/twisted/pull/224 >> >> and codecov is saying that only 66.67% of the patch is covered because it >> is not hittin

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-03 Thread Adi Roiban
On 4 July 2016 at 00:43, Craig Rodrigues wrote: > Hi, > > I submitted this pull request: > https://github.com/twisted/twisted/pull/224 > > and codecov is saying that only 66.67% of the patch is covered because it > is not hitting the Python 3 specific block: > > https://codecov.io/gh/twisted/twis

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-09-15 Thread Glyph
On Sep 11, 2013, at 10:48 AM, Zooko Wilcox-OHearn wrote: > We can instead *require* > the user to supply a type with the bytestring originally, and then > remember the type that the user supplied. This breaks only a few use > cases that are probably very rare, and in fact might be unfixable > an

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-09-11 Thread Zooko Wilcox-OHearn
Hello, Harry! I just noticed this thread. I opened a ticket for this a while back: https://twistedmatrix.com/trac/ticket/5203# FilePath.children() should return FilePath objects with unicodes in them instead of strs There is some discussion on that ticket. For what it is worth, I agree with It

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-07-15 Thread Glyph
First off, hi Harry! I am super glad that someone has taken an interest in this. Please let me know if I can be helpful in your effort to fix this. FilePath totally has the right sort of shape to handle all these problems very gracefully, but its current implementation is (as you have noticed

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-07-14 Thread Itamar Turner-Trauring
On 07/14/2013 10:18 AM, Harry Bock wrote: Is this something I can open a ticket for? I believe there's already a ticket of sorts, with an old defunct branch starting working on this - https://twistedmatrix.com/trac/ticket/2366 - it would be really great if you could revive it and add support

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-07-14 Thread Harry Bock
On Sun, Jul 14, 2013 at 8:16 AM, Itamar Turner-Trauring wrote: > On 07/13/2013 10:00 PM, Harry Bock wrote: > >> Hi all, >> >> My name is Harry Bock. I'm interested in helping out porting Twisted to >> Python 3, and I've popped in IRC a few times to introduce myself and ask a >> few questions. A

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-07-14 Thread Itamar Turner-Trauring
On 07/13/2013 10:00 PM, Harry Bock wrote: Hi all, My name is Harry Bock. I'm interested in helping out porting Twisted to Python 3, and I've popped in IRC a few times to introduce myself and ask a few questions. A few developers agreed that working on trial dependencies would be a big help.

Re: [Twisted-Python] Python 3: bytes vs. str in twisted.python.filepath

2013-07-14 Thread Tristan Seligmann
On Sun, Jul 14, 2013 at 4:00 AM, Harry Bock wrote: > (b) Misunderstandings at the application level about the underlying > filesystem's path encoding is not the problem of the Twisted API. Correct > me if I'm wrong, but that's the responsibility of the system administrator > or individual user (

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Itamar Turner-Trauring
On 06/19/2012 03:01 PM, gelin yan wrote: > > Sigh too, I am still using 2.6.6 & twisted 11.0; however I think it > is not so difficult to migrate to 2.7. > Just to be clear, Python 2.6 is still supported as of 12.1 and will continue to be supported (at the minimum for the next release and proba

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread gelin yan
On Wed, Jun 20, 2012 at 2:28 AM, Itamar Turner-Trauring wrote: > > Le Jun 19, 2012 à 10:50 AM, Itamar Turner-Trauring > a > > écrit : > > > >> We've dropped support for 2.6 post-12.1. So that's not a problem. We can > >> do these changes now in trunk. > > > > I really hope you mean 2.5. > > Sigh

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Itamar Turner-Trauring
> Le Jun 19, 2012 à 10:50 AM, Itamar Turner-Trauring a > écrit : > >> We've dropped support for 2.6 post-12.1. So that's not a problem. We can >> do these changes now in trunk. > > I really hope you mean 2.5. Sigh. Yes. Next release will be 2.6 and later. ___

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Glyph
Le Jun 19, 2012 à 10:50 AM, Itamar Turner-Trauring a écrit : > We've dropped support for 2.6 post-12.1. So that's not a problem. We can > do these changes now in trunk. I really hope you mean 2.5.___ Twisted-Python mailing list Twisted-Python@twistedm

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Itamar Turner-Trauring
> That said, there are > syntax changes ('except...as...' being the big one) that make supporting > 2.5->3 difficult, and only becomes reasonable at 2.6->3. So it may be > necessary to get 2to3 involved for some fixers. We've dropped support for 2.6 post-12.1. So that's not a problem. We can do

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Thijs Triemstra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/19/2012 07:15 PM, Antoine Pitrou wrote: > On Tue, 19 Jun 2012 08:55:51 -0700 Glyph > wrote: >> >> On Jun 19, 2012, at 7:43 AM, Vladimir Perić wrote: >> >>> there are basically two strategies: maintaining py2 code and >>> using 2to3 when instal

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Antoine Pitrou
On Tue, 19 Jun 2012 08:55:51 -0700 Glyph wrote: > > On Jun 19, 2012, at 7:43 AM, Vladimir Perić wrote: > > > there are basically two strategies: > > maintaining py2 code and using 2to3 when installing under py3, or > > maintaining a codebase which is compatible with both 2 and 3 > > Based on th

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Glyph
On Jun 19, 2012, at 7:43 AM, Vladimir Perić wrote: > there are basically two strategies: > maintaining py2 code and using 2to3 when installing under py3, or > maintaining a codebase which is compatible with both 2 and 3 Based on the experiences of other porters I have talked to, and heard speaki

Re: [Twisted-Python] Python 3 support in Twisted: Request for relaxation of coverage requirements

2012-06-19 Thread Itamar Turner-Trauring
On 06/19/2012 10:43 AM, Vladimir Perić wrote: > 3) apply > > To quote Lennart Regebro, "The Python 2 builtin apply() has been > removed in Python 3. It’s used to call a function, but since you can > call the function directly it serves no purpose and has been > deprecated since Python 2.3." I've re

Re: [Twisted-Python] Python 3

2010-09-21 Thread Glyph Lefkowitz
On Sep 21, 2010, at 5:43 PM, Laurens Van Houtven wrote: > 64 bit vs 32 bit shouldn't be a problem since Twisted is just Python. That's not accurate at all, since there are lots of places that Python can be broken (the struct module, in particular) with respect to 64-bit. Plus, Twisted has a l

Re: [Twisted-Python] Python 3

2010-09-21 Thread Laurens Van Houtven
Nope. It wouldn't be excessively hard to do, once some of the sillier missing methods on bytes objects are fixed -- it's just not very much of a priority. Twisted is used for a lot of production apps which often aren't even deployed on recent versions of 2.x, let alone 3.x, so supporting 2.x prope

Re: [Twisted-Python] Python 3

2010-09-21 Thread Glyph Lefkowitz
On Sep 21, 2010, at 4:53 PM, Itamar Turner-Trauring wrote: > No. Supporting Python 3 takes a large amount of effort which, as a mostly > volunteer driven organization, Twisted cannot afford at the moment. However, as a volunteer driven organization, you may change this at any time by simply vol

Re: [Twisted-Python] Python 3

2010-09-21 Thread Itamar Turner-Trauring
> I found it hard to tell what the level of support is for Python 3 - > particularly on 64 bit Windows 7. > > I found some tickets in trac, but othewise no clear statement. > > Is Twisted 10.x OK on Python 3? No. Supporting Python 3 takes a large amount of effort which, as a mostly volunteer drive