Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-03 Thread Wolfgang Rohdewald
Am Freitag, 3. Juli 2015, 23:00:45 schrieb Jørn Lomax: > I have found another issue I'm wondering a little how to handle. There > are places in the bana_test file that sys.maxint is used. This no longer > exists in python3, so how should it be handled. Should we make an > artificial maxint to us

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-03 Thread Glyph
> On Jul 3, 2015, at 2:00 PM, Jørn Lomax wrote: > > I have found another issue I'm wondering a little how to handle. There are > places in the bana_test file that sys.maxint is used. This no longer exists > in python3, so how should it be handled. Should we make an artificial maxint > to use

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-03 Thread Jørn Lomax
I have found another issue I'm wondering a little how to handle. There are places in the bana_test file that sys.maxint is used. This no longer exists in python3, so how should it be handled. Should we make an artificial maxint to use for python3. I might want to note that it is not used for co

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-02 Thread Glyph Lefkowitz
> On Jul 2, 2015, at 11:12 AM, Glyph wrote: > > >> On Jul 2, 2015, at 6:13 AM, Itamar Turner-Trauring > > wrote: >> >> >> On 2015-07-01 17:33, Glyph wrote: >> >>> >>> We may actually need to change the wire protocol to allow some applications >>> to continue to

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-02 Thread Glyph
> On Jul 2, 2015, at 6:13 AM, Itamar Turner-Trauring > wrote: > > > On 2015-07-01 17:33, Glyph wrote: > >> >> We may actually need to change the wire protocol to allow some applications >> to continue to work on py3, to allow for a 'text' type that corresponds to >> Python unicode. This

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-02 Thread Itamar Turner-Trauring
On 2015-07-01 17:33, Glyph wrote: > We may actually need to change the wire protocol to allow some applications > to continue to work on py3, to allow for a 'text' type that corresponds to > Python unicode. This should probably be done after the initial port though. Really? That seems like

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-01 Thread Glyph
> On Jul 1, 2015, at 9:46 AM, Jørn Lomax wrote: > > Thank you very much. That is the exact answer I wanted :) > > I'm guessing maybe the tests need updating, because they seem to send use > unicode data, which of course didn't make any difference in py2, but now it > does. We may actually ne

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-01 Thread Jørn Lomax
Thank you very much. That is the exact answer I wanted :) I'm guessing maybe the tests need updating, because they seem to send use unicode data, which of course didn't make any difference in py2, but now it does. On 01.07.2015 18:40, Itamar Turner-Trauring wrote: On 2015-07-01 05:33, Jørn

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-01 Thread Itamar Turner-Trauring
On 2015-07-01 05:33, Jørn Lomax wrote: > I'm a gsoc student working on the buildbot project, porting it to py3. Part > of this is looking at porting the dependencies buildbot has in twisted and > try to port them. > > twisted.spread is the most used twisted dependency, so I have started wor

Re: [Twisted-Python] Porting twisted.spread.banana to py3

2015-07-01 Thread Wolfgang Rohdewald
Am Mittwoch, 1. Juli 2015, 11:33:58 schrieb Jørn Lomax: > I'm a gsoc student working on the buildbot project, porting it to py3. > Part of this is looking at porting the dependencies buildbot has in > twisted and try to port them. > > twisted.spread is the most used twisted dependency, so I have