Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-06 Thread Adi Roiban
On 3 October 2017 at 00:09, Glyph wrote: > [snip] > I remember there was a PB based channel for communicating with Trac > but I can't find where it is defined. > I see that kenan is using something [1] BOT_PORT = 15243, I can't find > where a service with that port is started. > > > The PB inter

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-02 Thread Glyph
> On Oct 2, 2017, at 2:48 AM, Adi Roiban wrote: > > On 1 October 2017 at 20:09, Glyph wrote: >> On Oct 1, 2017, at 12:06 PM, Craig Rodrigues wrote: >> >> >> Rather than write a bot specific to Twisted, why not just adapt the Twisted >> project to use a bot written by another project? >> >>

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-02 Thread Adi Roiban
On 1 October 2017 at 20:09, Glyph wrote: > On Oct 1, 2017, at 12:06 PM, Craig Rodrigues wrote: > > > Rather than write a bot specific to Twisted, why not just adapt the Twisted > project to use a bot written by another project? > > > Personally I don't care either way :-). I was just describing

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-01 Thread Glyph
> On Oct 1, 2017, at 12:06 PM, Craig Rodrigues wrote: > > Rather than write a bot specific to Twisted, why not just adapt the Twisted > project to use a bot written by another project? Personally I don't care either way :-). I was just describing my understanding of the existing plan, not end

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-01 Thread Craig Rodrigues
On Sat, Sep 30, 2017 at 3:14 PM, Adi Roiban wrote: > > > orking on a bot to re-open pull requests when a submitter posts a "please > review" comment: https://github.com/markrwilliams/txghbot Rather than write a bot specific to Twisted, why not just adapt the Twisted project to use a bot writte

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-01 Thread Glyph
> On Sep 30, 2017, at 3:14 PM, Adi Roiban wrote: > > I am restarting this discussion > https://twistedmatrix.com/pipermail/twisted-python/2016-May/030333.html > > I am starting a new thread since I want to keep the focus on the > review process / workflow / markers, and not on the things requi