Re: [Twisted-Python] Conch text attribute flattening quirks

2012-02-24 Thread Jonathan Jacobs
On Thu, Feb 23, 2012 at 16:12, wrote: > I think the behavior you observed is a bug in the implementation (I > noticed it during our IRC conversation the other day as well, but wasn't > sure if I'd made a mistake or misread something).  It should be fixed, > and perhaps that TODO test made to pass

Re: [Twisted-Python] Conch text attribute flattening quirks

2012-02-23 Thread exarkun
On 22 Feb, 04:15 pm, jonathan+twis...@jsphere.com wrote: >On Wed, Feb 22, 2012 at 17:25, Tim Allen wrote: >>...that is, there's no code for 'end bold' or 'end italics' (or blink, >>dim, >>underline, invisible, any kind of colouring, etc.) just an 'end all >>special attributes' code. Therefore it'

Re: [Twisted-Python] Conch text attribute flattening quirks

2012-02-22 Thread Jonathan Jacobs
On Wed, Feb 22, 2012 at 17:25, Tim Allen wrote: > ...that is, there's no code for 'end bold' or 'end italics' (or blink, dim, > underline, invisible, any kind of colouring, etc.) just an 'end all > special attributes' code. Therefore it's reasonable for conch's helper > library to not handle neste

Re: [Twisted-Python] Conch text attribute flattening quirks

2012-02-22 Thread Tim Allen
On Wed, Feb 22, 2012 at 01:47:46PM +0200, Jonathan Jacobs wrote: > >>> from twisted.conch.insults.helper import CharacterAttribute > >>> from twisted.conch.insults.text import flatten, attributes as A > >>> flatten(A.normal['hello', A.bold[' world '], 'quux'], > >>> CharacterAttribute()) > 'hello\