Re: [Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-11 Thread Jason J. W. Williams
Pleasure. :) -J On Fri, Mar 11, 2011 at 2:28 PM, Glyph Lefkowitz wrote: > > On Mar 11, 2011, at 12:52 PM, Jason J. W. Williams wrote: > >> Hi Glyph, >> >> I re-opened 4456 and attached a patch. I think that's this issue. The only >> other one I found in the tickets was for Conch and that one wa

Re: [Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-11 Thread Glyph Lefkowitz
On Mar 11, 2011, at 12:52 PM, Jason J. W. Williams wrote: > Hi Glyph, > > I re-opened 4456 and attached a patch. I think that's this issue. The only > other one I found in the tickets was for Conch and that one was marked fixed. Thanks! At the latest, this should get reviewed at the sprint.

Re: [Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-11 Thread Jason J. W. Williams
Hi Glyph, I re-opened 4456 and attached a patch. I think that's this issue. The only other one I found in the tickets was for Conch and that one was marked fixed. -J Sent via iPhone Is your e-mail Premiere? On Mar 11, 2011, at 9:51, Glyph Lefkowitz wrote: > On Mar 11, 2011, at 2:25 AM, Jas

Re: [Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-11 Thread Glyph Lefkowitz
On Mar 11, 2011, at 2:25 AM, Jason J. W. Williams wrote: > Setting it as a class level attribute seems to suppress it: > class TestError(Exception): > ... message = "" > ... > ... def __init__(self, msg): > ...self.message = msg > > Since it's a string and passed by value I

Re: [Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-10 Thread Jason J. W. Williams
Setting it as a class level attribute seems to suppress it: >>> class TestError(Exception): ... message = "" ... ... def __init__(self, msg): ...self.message = msg Since it's a string and passed by value I think this would work. I'll open up a ticket if one's not already. -J On

Re: [Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-10 Thread Glyph Lefkowitz
On Mar 10, 2011, at 5:45 PM, Jason J. W. Williams wrote: > Hi Guys, > > Been seeing this error for a long time and finally getting off my bum > to see about fixing it: > > twisted/web/error.py:53: DeprecationWarning: BaseException.message has > been deprecated as of Python 2.6 > > It looks like

[Twisted-Python] twisted.web.error.Error & BaseException.message deprecation

2011-03-10 Thread Jason J. W. Williams
Hi Guys, Been seeing this error for a long time and finally getting off my bum to see about fixing it: twisted/web/error.py:53: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 It looks like the issue is the "self.message = message" assignment in __init__: https://g