Re: [Twisted-Python] incompatible change in 15.3 - something reviewers should look for

2015-08-12 Thread Glyph Lefkowitz
> On Aug 12, 2015, at 3:46 AM, Jonathan Lange wrote: > > From the perspective of Twisted development, why does it matter? The one reason that it matters is that we need to consistently tell users how to prepare for the fact that eventually, everything will be new-style. Perhaps it will only

Re: [Twisted-Python] incompatible change in 15.3 - something reviewers should look for

2015-08-12 Thread Jonathan Lange
On Wed, 12 Aug 2015 at 07:25 Adi Roiban wrote: > On 12 August 2015 at 01:24, Glyph wrote: > > > We discovered this because this change breaks > > https://github.com/twisted/axiom, and probably it breaks other packages > as > > well, since lots of things inherit from Service. So please remain >

Re: [Twisted-Python] incompatible change in 15.3 - something reviewers should look for

2015-08-11 Thread Adi Roiban
Hi, Thanks for the notice! On 12 August 2015 at 01:24, Glyph wrote: > In https://twistedmatrix.com/trac/changeset/45163 > twisted.internet.application.service.Service to be a new-style class. Just > to remind everyone, converting an old-style class to a new-style class is an > incompatible chan

[Twisted-Python] incompatible change in 15.3 - something reviewers should look for

2015-08-11 Thread Glyph
In https://twistedmatrix.com/trac/changeset/45163 twisted.internet.application.service.Service to be a new-style class. Just to remind everyone, converting an old-style class to a new-style class is an incompatible change, and reviewers should look for this. We discovered this because this cha