Re: [Twisted-Python] feedback on next version of Fireshark using twisted framework....

2012-05-03 Thread David Strauss
On Thu, May 3, 2012 at 1:05 PM, Glyph wrote: > Actually, you're better off using twisted.python.filepath.FilePath.child :). > > That documentation has quite the personality. ___

Re: [Twisted-Python] feedback on next version of Fireshark using twisted framework....

2012-05-03 Thread Glyph
On May 3, 2012, at 2:12 PM, Jasper St. Pierre wrote: > you're better off using os.path.join Actually, you're better off using twisted.python.filepath.FilePath.child :). HTH, HAND, -g

Re: [Twisted-Python] feedback on next version of Fireshark using twisted framework....

2012-05-03 Thread Stephan
thanks for the feed back Jasper! More feedback welcome. Yes the code def. needs to be cleaned up before public release, and I will make more use of python libs for path concatenation. The feedback I'm specifically looking for is anything related to how I'm using twisted and process management. The

Re: [Twisted-Python] feedback on next version of Fireshark using twisted framework....

2012-05-03 Thread Jasper St. Pierre
You seem to have some indentation issues. You have a random assortment of Python style issues (some lines end with a semicolon). You use 'foo' + '/' + 'bar' to generate paths. While not evil (I think all major platforms will support that and do the translation on their own), you're better off using

[Twisted-Python] feedback on next version of Fireshark using twisted framework....

2012-05-03 Thread Stephan
Hi I have an open source project that is pretty well-known in the security community. http://www.fireshark.org it's a service wrapper that runs a headless version of firefox to visit malicious sites to store telemetry data. The old service used PERL for threading (very painful), so a while ago I c