Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-23 Thread Glyph
> On Mar 23, 2016, at 3:19 PM, Tom Prince wrote: > > Nothing about #8264's *requirements* leads to hybrid classes. But the > implementation makes *every* currently old-style class into a > hybrid-class.. Looks like the implementation needs to be revisited then :). -glyph___

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-23 Thread Tom Prince
On Tue, Mar 22, 2016 at 10:26 PM, Glyph wrote: > Nothing about 8244 would involve making more hybrid classes. Classes > decorated as @oldStyle must be pure old style (the semantics of hybrids are > much, much closer to new-style than old-style) so they have to be what they > are today. When we f

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-23 Thread Glyph
> On Mar 23, 2016, at 2:10 PM, L. Daniel Burr wrote: > > Hi Glyph, > On March 23, 2016 at 1:39:53 PM, Glyph (gl...@twistedmatrix.com > ) wrote: > >> >>> On Mar 23, 2016, at 9:22 AM, L. Daniel Burr >> > wrote: >>> >>> My concern is th

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-23 Thread L. Daniel Burr
Hi Glyph, On March 23, 2016 at 1:39:53 PM, Glyph (gl...@twistedmatrix.com) wrote: On Mar 23, 2016, at 9:22 AM, L. Daniel Burr wrote: My concern is that, should these classes be converted into hybrids via the @oldStyle decorator, my service may experience some reduction in the number of reques

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-23 Thread Glyph
> On Mar 23, 2016, at 9:22 AM, L. Daniel Burr wrote: > > My concern is that, should these classes be converted into hybrids via the > @oldStyle decorator, my service may experience some reduction in the number > of requests per second that it handles If oldStyle converts the classes into hybr

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-23 Thread L. Daniel Burr
Hi Glyph, On March 22, 2016 at 11:27:10 PM, Glyph (gl...@twistedmatrix.com) wrote: On Mar 22, 2016, at 12:33 PM, L. Daniel Burr wrote: Hi all, Hi Daniel, I tried to comment on the ticket, but SpamBayes rejected it as spam. The spam-monitoring queue is empty, which means another admin probab

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-22 Thread Amber Brown
Worth noting that the converted hybrid classes are opt in - by default they are a no-op. This means you can run under TWISTED_NEWSTYLE=1 for your tests to ensure that when all the classes go natively new style, everything works, but leave it off in prod. Then in a later release, all of these classe

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-22 Thread Glyph
> On Mar 22, 2016, at 12:33 PM, L. Daniel Burr wrote: > > Hi all, Hi Daniel, > I tried to comment on the ticket, but SpamBayes rejected it as spam. The spam-monitoring queue is empty, which means another admin probably got to this before I did. But when I plugged the following paragraph in,

[Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-22 Thread L. Daniel Burr
Hi all, I tried to comment on the ticket, but SpamBayes rejected it as spam. As a person who runs twisted apps via Pypy whenever possible, I wanted to point out that this ticket may result in a performance regression: according to  http://pypy.org/performance.html, "Classes that inherit from bot