Re: [Twisted-Python] Theory and practice of Pull Requests

2017-09-28 Thread Craig Rodrigues
Hi, I have commented on that ticket with my suggestion for a GitHub commit template. I don't think we need to do anything drastic, but I think that we can perform some small incremental improvements that make the user experience of committing to Twisted more pleasant. -- Craig On Thu, Sep 28, 2

[Twisted-Python] Theory and practice of Pull Requests

2017-09-28 Thread Moshe Zadka
FYI, I opened https://twistedmatrix.com/trac/ticket/9292 which seeks to realign our theory (what we say in CONTRIBUTING) and what we do in practice regarding pull requests on GitHub. Please comment on the ticket if you see any issues! Moshe Z. ___ Twiste