Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-05 Thread exarkun
On 5 Nov, 11:57 pm, ita...@itamarst.org wrote: On 11/04/2014 09:54 PM, Glyph wrote: I don't follow. Are you saying that logger fixed some python 3 stuff, and by reverting it we're losing that, or that log regressed after 14.0 and logger fixed it and that by reverting it we are regressing

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-05 Thread Itamar Turner-Trauring
http://twistedmatrix.com/trac/ticket/7563 ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-05 Thread Itamar Turner-Trauring
On 11/04/2014 09:54 PM, Glyph wrote: I don't follow. Are you saying that logger fixed some python 3 stuff, and by reverting it we're losing that, or that log regressed after 14.0 and logger fixed it and that by reverting it we are regressing with respect to its usability in 14.0? Logger b

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-05 Thread Glyph
> On Nov 5, 2014, at 3:54 AM, Glyph wrote: > >> On Nov 4, 2014, at 7:44 PM, Itamar Turner-Trauring > > wrote: >> >> On 2014-11-03 23:10, Glyph wrote: >> >>> In favor again of reverting is the fact that no code outside >>> twisted.python.logger or twisted.python.log

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-04 Thread Glyph
> On Nov 4, 2014, at 7:44 PM, Itamar Turner-Trauring > wrote: > > On 2014-11-03 23:10, Glyph wrote: > >> In favor again of reverting is the fact that no code outside >> twisted.python.logger or twisted.python.log has been modified to take >> advantage of the new system, so we're not going to

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-04 Thread Itamar Turner-Trauring
On 2014-11-03 23:10, Glyph wrote: > In favor again of reverting is the fact that no code outside > twisted.python.logger or twisted.python.log has been modified to take > advantage of the new system, so we're not going to be breaking any > dependencies on trunk. Except for the fact that Tw

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-04 Thread HawkOwl
On 4 Nov 2014, at 18:07, Glyph wrote: > >> On Nov 4, 2014, at 10:38 AM, HawkOwl wrote: >> >>> • Can please we do reviews of the fixes to the regressions as if they >>> were landing on trunk, and not have this revert re-open the need to review >>> the entire (rather large) change? >> >>

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-04 Thread Glyph
> On Nov 4, 2014, at 10:38 AM, HawkOwl wrote: > >> • Can please we do reviews of the fixes to the regressions as if they >> were landing on trunk, and not have this revert re-open the need to review >> the entire (rather large) change? > > How are we going to manage this? Do we need an “

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-04 Thread HawkOwl
On 4 Nov 2014, at 12:10, Glyph wrote: > > On the gripping hand, many of these regressions have been outstanding for > months, and so if we could get these fixed promptly enough, presumably we > would have done that already. This is mainly why I am in favour of this plan. They’re not small fix

Re: [Twisted-Python] The Path to Twisted 14.1

2014-11-03 Thread Glyph
> On Nov 3, 2014, at 2:43 PM, HawkOwl wrote: > > Hi everyone, > > To keep everyone in the loop... Thanks for the update! > Since 14.0 came out months ago, and we really should have 14.1, I think it’s > time we bit the bullet and cleaned out the regressions to get it out the > door. Unfortun

[Twisted-Python] The Path to Twisted 14.1

2014-11-03 Thread HawkOwl
Hi everyone, To keep everyone in the loop... Since 14.0 came out months ago, and we really should have 14.1, I think it’s time we bit the bullet and cleaned out the regressions to get it out the door. Unfortunately, all of the currently open regressions are from the new logging system (#6750,