Re: [Twisted-Python] TestCase methods names

2011-03-27 Thread exarkun
On 04:22 am, gl...@twistedmatrix.com wrote: >Looks great. Thanks for filing those! (And even with those new >tickets, -1 >total open issues this week! WTG!) At some point we'll run out of web2 tickets that we can close as wontfix (actually we may have already) and then we'll need to actually

Re: [Twisted-Python] TestCase methods names

2011-03-26 Thread Glyph Lefkowitz
Looks great. Thanks for filing those! (And even with those new tickets, -1 total open issues this week! WTG!) On Sat, Mar 26, 2011 at 3:39 PM, wrote: > On 19 Mar, 08:27 am, gl...@twistedmatrix.com wrote: > > > >On Mar 18, 2011, at 9:36 PM, exar...@twistedmatrix.com wrote: > >>>In concrete, I

Re: [Twisted-Python] TestCase methods names

2011-03-26 Thread exarkun
On 19 Mar, 08:27 am, gl...@twistedmatrix.com wrote: > >On Mar 18, 2011, at 9:36 PM, exar...@twistedmatrix.com wrote: >>>In concrete, I say that we should: >>> >>>- Deprecate those names that are deprecated in Python 3 (I mean, >>>still >>>provide the functionality, but with a DeprecationWarning) >

Re: [Twisted-Python] TestCase methods names

2011-03-19 Thread Laurens Van Houtven
I'm with JP, but a reasonable warning should be important, yes. cheers lvh ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] TestCase methods names

2011-03-19 Thread Glyph Lefkowitz
On Mar 18, 2011, at 9:36 PM, exar...@twistedmatrix.com wrote: >> In concrete, I say that we should: >> >> - Deprecate those names that are deprecated in Python 3 (I mean, still >> provide the functionality, but with a DeprecationWarning) >> >> - Stop using them in internal code. >> >> - Fix do

Re: [Twisted-Python] TestCase methods names

2011-03-18 Thread exarkun
On 15 Mar, 02:57 pm, facundobati...@gmail.com wrote: >Hello! > >The TestCase class, historically, provided several ways to do the same >(I guess because we inherited the semantics from Java). > >For example, to check equality, In Python2 we have: > >* assertEquals >* assertEqual >* failUnlessEqual

Re: [Twisted-Python] TestCase methods names

2011-03-16 Thread Jamu Kakar
Hi Facundo, On Tue, Mar 15, 2011 at 3:57 PM, Facundo Batista wrote: > So, I propose to stick to the same method names than Python; this way > we'll be more consistent and easy to learn than keep providing all > variants. > > In concrete, I say that we should: > > - Deprecate those names that are

[Twisted-Python] TestCase methods names

2011-03-15 Thread Facundo Batista
Hello! The TestCase class, historically, provided several ways to do the same (I guess because we inherited the semantics from Java). For example, to check equality, In Python2 we have: * assertEquals * assertEqual * failUnlessEqual However, note that "assertEquals" was never documented (not