Re: [Twisted-Python] SSl wincertstore Ticket 6371

2016-04-04 Thread Glyph
> On Apr 4, 2016, at 2:56 AM, John Aherne wrote: > > I have done a clean download of twisted and run the tests without any changes. OK. This is a bug we should investigate, but I think we can safely say it's a separate bug and not one which will cause your patch to fail review. -glyph___

[Twisted-Python] SSl wincertstore Ticket 6371

2016-04-04 Thread John Aherne
I have done a clean download of twisted and run the tests without any changes. I still get the same error on:-- twisted.names.test.test_tap.OptionsTests.test_recursiveConfiguration [ERROR] Traceback (most recent call last): Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was uncl

[Twisted-Python] SSl wincertstore Ticket 6371

2016-04-04 Thread John Aherne
The failure is in test_agent test_setsTrustRootOnContextDefaultTrustRoot This fails if wincertstore is available with this failure:- twisted.trial.unittest.FailTest: is not an instance of This is because the patch from aaron which I have applied has_sslverify.platformTrust check for wincert

Re: [Twisted-Python] SSL wincertstore Ticket 6371

2016-04-04 Thread Glyph
> On Apr 3, 2016, at 6:29 AM, John Aherne wrote: > > I have picked up on this again. > > There would appear to be a failing test in test_agent.py. You said 'test_agent' but the error below is coming from test_tap; which are you referring to? > I have added a new test to check that certificat

[Twisted-Python] SSL wincertstore Ticket 6371

2016-04-03 Thread John Aherne
I have picked up on this again. There would appear to be a failing test in test_agent.py. I have added a new test to check that certificateOptions.trustRoot is an instance of OpensSSLWindowsCertificateAuthorities if wincertstore is available And I have modified the existing test test_setsTrust