Re: [Twisted-Python] SMTPConnectError as a side effect on connection lost

2017-11-26 Thread Glyph
> On Nov 26, 2017, at 5:10 AM, Adi Roiban wrote: > > On 26 November 2017 at 05:36, Glyph wrote: >> >>> On Nov 25, 2017, at 8:52 PM, Adi Roiban wrote: >>> >>> Do you see anything suspicious with this code? >> >> Just that it looks like it leaves a Deferred in an error state. You said the >

Re: [Twisted-Python] SMTPConnectError as a side effect on connection lost

2017-11-26 Thread Adi Roiban
On 26 November 2017 at 05:36, Glyph wrote: > >> On Nov 25, 2017, at 8:52 PM, Adi Roiban wrote: >> >> Do you see anything suspicious with this code? > > Just that it looks like it leaves a Deferred in an error state. You said the > tests weren’t “written using” trial, but are you running them wit

Re: [Twisted-Python] SMTPConnectError as a side effect on connection lost

2017-11-25 Thread Glyph
> On Nov 25, 2017, at 8:52 PM, Adi Roiban wrote: > > Do you see anything suspicious with this code? Just that it looks like it leaves a Deferred in an error state. You said the tests weren’t “written using” trial, but are you running them with trial, or with any runner that will consider a lo

[Twisted-Python] SMTPConnectError as a side effect on connection lost

2017-11-25 Thread Adi Roiban
I hit a strange behavior in which the clone connection error from one test is raised as the error for another test. The tests are not written using trial, but I have thousands of other tests and I have never seen this behaviour. I tried to put a self-contained example at https://gist.github.com/