Re: [Twisted-Python] SMB server component for twisted

On 15/05/2020 10:52 am, Glyph wrote: y 14, 2020, at 5:23 PM, Wilfredo Sánchez Vega   I think it's great to get an SMB implementation in the Twisted org, but why would we even consider adding something like this to the main Twisted project? The advantage of twi

Re: [Twisted-Python] SMB server component for twisted

> On May 14, 2020, at 5:23 PM, Wilfredo Sánchez Vega > mailto:wsanc...@wsanchez.net)> wrote: > On May 7, 2020, at 12:48 AM, Glyph > mailto:gl...@twistedmatrix.com)> wrote: > > > > If you want to include it in Twisted itself, your best bet is to actually > > develop it within twisted, as a

Re: [Twisted-Python] SMB server component for twisted

On May 7, 2020, at 12:48 AM, Glyph wrote: > > If you want to include it in Twisted itself, your best bet is to actually > develop it within twisted, as a series of small contributions, rather than as > one gigantic one-shot one. Contributions over, say, 400 lines, take > exponentially longer

Re: [Twisted-Python] SMB server component for twisted

> On May 8, 2020, at 12:39 AM, Ian Haywood wrote: > > On 7/05/2020 5:48 pm, Glyph wrote: > >> If you want to include it in Twisted itself, your best bet is to actually >> develop it /within/ twisted, as a series of small contributions, rather than >> as one gigantic one-shot one. Contributi

Re: [Twisted-Python] SMB server component for twisted

On 7/05/2020 5:48 pm, Glyph wrote: If you want to include it in Twisted itself, your best bet is to actually develop it /within/ twisted, as a series of small contributions, rather than as one gigantic one-shot one.  Contributions over, say, 400 lines, take exponentially longer to review. So

Re: [Twisted-Python] SMB server component for twisted

> On May 4, 2020, at 9:17 PM, Ian Haywood wrote: > > I have begun work on a SMB (Server Message Block; Windows filesharing) server > protocol for twisted. Very exciting! Thanks for telling us about this. It would be great to have a memory-safe/Python implementation of SMB3! > Work so far is

Re: [Twisted-Python] SMB server component for twisted

Hi Ian On Tue, 5 May 2020 at 05:17, Ian Haywood wrote: > I have begun work on a SMB (Server Message Block; Windows filesharing) > server protocol for twisted. > > Work so far is here: https://github.com/ihaywood3/twsmb > > I'm looking for any advice particularly around what I should be doing so

[Twisted-Python] SMB server component for twisted

I have begun work on a SMB (Server Message Block; Windows filesharing) server protocol for twisted. Work so far is here: https://github.com/ihaywood3/twsmb I'm looking for any advice particularly around what I should be doing so this code is suitable for inclusion in twisted. Ian Haywood __