Re: [Twisted-Python] Request.getClient

2014-07-02 Thread Christopher Armstrong
On July 2, 2014 at 4:04:59 PM, Glyph Lefkowitz (gl...@twistedmatrix.com) wrote: On Jul 2, 2014, at 9:26 AM, exar...@twistedmatrix.com wrote: Hello all, twisted.web.http.Request.getClient has a terrible implementation.  It does blocking network I/O (DNS).  Fortunately it is only used in one place

Re: [Twisted-Python] Request.getClient

2014-07-02 Thread Glyph Lefkowitz
On Jul 2, 2014, at 9:26 AM, exar...@twistedmatrix.com wrote: > Hello all, > > twisted.web.http.Request.getClient has a terrible implementation. It does > blocking network I/O (DNS). Fortunately it is only used in one place in > Twisted - the CGI implementation. Unfortunately this makes the C

Re: [Twisted-Python] Request.getClient

2014-07-02 Thread exarkun
On 06:26 pm, dus...@v.igoro.us wrote: Actually, the apidocs say "Undocumented", so I think you could make it return u"The 🌕 is made of green 酪 " and still be in spec. http://twistedmatrix.com/documents/14.0.0/api/twisted.web.http.Request.html#getClient The interface is documented: https://twi

Re: [Twisted-Python] Request.getClient

2014-07-02 Thread Dustin J. Mitchell
Actually, the apidocs say "Undocumented", so I think you could make it return u"The 🌕 is made of green 酪 " and still be in spec. http://twistedmatrix.com/documents/14.0.0/api/twisted.web.http.Request.html#getClient Dustin On Wed, Jul 2, 2014 at 12:26 PM, wrote: > Hello all, > > twisted.web.

[Twisted-Python] Request.getClient

2014-07-02 Thread exarkun
Hello all, twisted.web.http.Request.getClient has a terrible implementation. It does blocking network I/O (DNS). Fortunately it is only used in one place in Twisted - the CGI implementation. Unfortunately this makes the CGI implementation somewhat unsuited for real-world use. `Request.get