Re: [Twisted-Python] On testing things wrapping other things

2014-09-21 Thread Glyph
On Sep 21, 2014, at 10:52 AM, weykent wrote: > On Sep 21, 2014, at 10:36 AM, Glyph wrote: > >> If anything I'd say that the problem with this code is that it's not a >> public, documented interface. The clients of this library might want to test >> it as well :). > > Ah! You are referring t

Re: [Twisted-Python] On testing things wrapping other things

2014-09-21 Thread weykent
On Sep 21, 2014, at 10:36 AM, Glyph wrote: > If anything I'd say that the problem with this code is that it's not a > public, documented interface. The clients of this library might want to test > it as well :). Ah! You are referring to both _wrap and _issueRequest here, right? That makes sen

Re: [Twisted-Python] On testing things wrapping other things

2014-09-21 Thread Glyph
On Sep 20, 2014, at 11:31 AM, weykent wrote: > Hi, > > Recently I worked on refactoring a project so that it was, in my opinion, > more testable. For reference, the diff is available at >

[Twisted-Python] On testing things wrapping other things

2014-09-20 Thread weykent
Hi, Recently I worked on refactoring a project so that it was, in my opinion, more testable. For reference, the diff is available at , and the important parts in t