Re: [Twisted-Python] Old-class-only support in manhole

2011-03-27 Thread exarkun
On 04:23 am, gl...@twistedmatrix.com wrote: >On Sat, Mar 26, 2011 at 2:47 PM, Facundo Batista >wrote: >>On Sat, Mar 26, 2011 at 3:13 PM, wrote: >> >> > The idea here is cool, and I think it would be nice to support it, >>but >> > this code is pretty gross and, as far as I know, broken. I think

Re: [Twisted-Python] Old-class-only support in manhole

2011-03-26 Thread Glyph Lefkowitz
On Sat, Mar 26, 2011 at 2:47 PM, Facundo Batista wrote: > On Sat, Mar 26, 2011 at 3:13 PM, wrote: > > > The idea here is cool, and I think it would be nice to support it, but > > this code is pretty gross and, as far as I know, broken. I think we > > should think about getting rid of it. If we

Re: [Twisted-Python] Old-class-only support in manhole

2011-03-26 Thread Facundo Batista
On Sat, Mar 26, 2011 at 3:13 PM, wrote: > The idea here is cool, and I think it would be nice to support it, but > this code is pretty gross and, as far as I know, broken.  I think we > should think about getting rid of it.  If we go that route, then you > should be able to ignore it for your Py

Re: [Twisted-Python] Old-class-only support in manhole

2011-03-26 Thread exarkun
On 25 Mar, 10:26 pm, facundobati...@gmail.com wrote: >Hello! > >Creating a test case for a change in twisted/manhole/explorer.py, I >found these lines in CRUFT_WatchyThingie.watchObject: > >if type(object) is not types.InstanceType: >raise TypeError, "Sorry, can only place a wat

[Twisted-Python] Old-class-only support in manhole

2011-03-25 Thread Facundo Batista
Hello! Creating a test case for a change in twisted/manhole/explorer.py, I found these lines in CRUFT_WatchyThingie.watchObject: if type(object) is not types.InstanceType: raise TypeError, "Sorry, can only place a watch on Instances." Always talking in Python 2, if you pass a