Re: [Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-28 Thread Glyph Lefkowitz
> On Apr 28, 2015, at 10:55 AM, Brian Costlow wrote: > > Okay, figured this out. Glad to hear it! > Abstract of the issue: I am a dumbass. We all make mistakes. And a lot of people make this specific one :-). > First, Itamar gets to thrash me soundly, No need for violence! > as there was

Re: [Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-28 Thread Brian Costlow
Okay, figured this out. Abstract of the issue: I am a dumbass. First, Itamar gets to thrash me soundly, as there was a bug in some code (not shown in my example) that is not properly tested. That code was responsible for "turning off" the protocol instance if connectionLost method was called, by

Re: [Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-28 Thread Brian Costlow
On Mon, Apr 27, 2015 at 4:55 PM, Glyph Lefkowitz wrote: > > Nothing strikes me as obviously wrong about this code (except the > "deferToThread" which seems *slightly* > suspicious, since nothing in the example appears to have anything to do > with threads, and whenever you get threads involved th

Re: [Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-27 Thread Brian Costlow
On Mon, Apr 27, 2015 at 8:26 PM, Itamar Turner-Trauring wrote: > self.in_send_message seems like a potential source of bugs (can't see it > being set to False on all branches here) and is also likely unnecessary. > self.in_send_message is redundant with self.waiting_id, which was added later, an

Re: [Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-27 Thread Itamar Turner-Trauring
self.in_send_message seems like a potential source of bugs (can't see it being set to False on all branches here) and is also likely unnecessary. General advice: 1. Simplify, simplify, simplify. 2. Unit tests (see https://twistedmatrix.com/documents/current/core/howto/trial.html). _

Re: [Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-27 Thread Glyph Lefkowitz
> On Apr 27, 2015, at 1:05 PM, Brian Costlow wrote: > > Summary: I am having an issue writing data from an object based on twisted's > LineReceiver. Calling self.transport.write from the protocol, some data makes > it through, some does not. Using tcpdump, I am not seeing the missing data > c

[Twisted-Python] Looking for some advice debugging issue with transport.write calls

2015-04-27 Thread Brian Costlow
Summary: I am having an issue writing data from an object based on twisted's LineReceiver. Calling self.transport.write from the protocol, some data makes it through, some does not. Using tcpdump, I am not seeing the missing data cross the network interface. Ubuntu LTS 14.04 Python 2.7.6 Twisted 1