Re: [Twisted-Python] Log Rotation Blocks w/ Large Number of Log Files

2010-03-17 Thread Jason J. W. Williams
As requested: http://twistedmatrix.com/trac/ticket/4372 Thank you for taking a look at it. -J On Wed, Mar 17, 2010 at 10:12 AM, Glyph Lefkowitz wrote: > > On Mar 16, 2010, at 5:34 PM, Jason J. W. Williams wrote: > > Given I've only used Twisted in the past and not contributed to it, I > was curi

Re: [Twisted-Python] Log Rotation Blocks w/ Large Number of Log Files

2010-03-17 Thread Glyph Lefkowitz
On Mar 16, 2010, at 5:34 PM, Jason J. W. Williams wrote: > Given I've only used Twisted in the past and not contributed to it, I > was curious if someone could take a look at my changes to > twisted.python.logfile.LogFile's rotate() method and see if there's > any reason the changes would be a ba

Re: [Twisted-Python] Log Rotation Blocks w/ Large Number of Log Files

2010-03-16 Thread Jason J. W. Williams
True. Technically, you could also just kick it out to syslog and let logrotate.d do the rotation for you. The code I put up had a major "concurrency" error in that multiple rotation threads could be launched and conflict with each other (try to remove the same file). Updated the Gist to deal with

Re: [Twisted-Python] Log Rotation Blocks w/ Large Number of Log Files

2010-03-16 Thread Maarten ter Huurne
On Tuesday 16 March 2010, Jason J. W. Williams wrote: > Twistd blocks for a long period of time when the number of log files > built up is large, thereby causing connections to freeze and > (depending on the length of the rotation) time out. > > Given I've only used Twisted in the past and not co

[Twisted-Python] Log Rotation Blocks w/ Large Number of Log Files

2010-03-16 Thread Jason J. W. Williams
Hello, Twistd blocks for a long period of time when the number of log files built up is large, thereby causing connections to freeze and (depending on the length of the rotation) time out. Given I've only used Twisted in the past and not contributed to it, I was curious if someone could take a lo