Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool - time to test!

2014-10-11 Thread Glyph
On Oct 11, 2014, at 11:17 AM, weykent wrote: > On Oct 10, 2014, at 11:26 PM, Glyph wrote: > >> The ticket is in review now, >> and the branch is . > > I just tested my threadpool statistics collection code against that branch, > and it works perfe

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool - time to test!

2014-10-11 Thread weykent
On Oct 10, 2014, at 11:26 PM, Glyph wrote: > The ticket is in review now, and > the branch is . I just tested my threadpool statistics collection code against that branch, and it works perfectly! Thanks a lot for your effort in this branch. __

[Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool - time to test!

2014-10-10 Thread Glyph
Again as per , in order to conclude this discussion, I need to provide Twisted users with a branch to test their code against. Well, now you have it - and as per the policy you have a week from the send

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-10-01 Thread Glyph
On Sep 30, 2014, at 10:12 PM, Joshua Bartlett wrote: > On 1 October 2014 14:09, Glyph wrote: > > That said: why did you need a threadpool of daemon threads? > > That's a very good question. One of my comaintainers thinks the answer is, > "My codebase is old enough to vote and to answer your

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-30 Thread Joshua Bartlett
On 1 October 2014 14:09, Glyph wrote: > > That said: why did you need a threadpool of daemon threads? > That's a very good question. One of my comaintainers thinks the answer is, "My codebase is old enough to vote and to answer your question I'd probably have to turn our SVN server back on. Plea

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-30 Thread Glyph
On Sep 28, 2014, at 6:56 PM, Joshua Bartlett wrote: > On 26 September 2014 08:31, Glyph Lefkowitz wrote: > So, does anyone out there have any code which makes use of the aforementioned > bad attributes of ThreadPool, whose applications would break if I removed > them? If so, how can I make y

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-28 Thread Joshua Bartlett
On 26 September 2014 08:31, Glyph Lefkowitz wrote: > So, does anyone out there have any code which makes use of the > aforementioned bad attributes of ThreadPool, whose applications would break > if I removed them? If so, how can I make you feel as bad about yourselves > for using it as I feel b

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Jonathan Lange
On Fri, Sep 26, 2014 at 8:43 AM, Glyph wrote: > > On Sep 25, 2014, at 6:36 PM, weykent wrote: > > On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz > wrote: > > So, does anyone out there have any code which makes use of the > aforementioned bad attributes of ThreadPool, whose applications would brea

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Christopher Armstrong
On September 25, 2014 at 8:39:54 PM, weykent (weyk...@weasyl.com) wrote: On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz wrote: > So, does anyone out there have any code which makes use of the aforementioned > bad attributes of ThreadPool, whose applications would break if I removed > them? Y

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Adi Roiban
On 26 September 2014 08:43, Glyph wrote: [snip] > My inclination would be to expand the thread pool to accommodate these > usages, but still deprecate these attributes in the next version; but add a > better "statistics" method that returned an object with "active", "pending", > and "idle" attrib

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread weykent
On Sep 26, 2014, at 12:43 AM, Glyph wrote: > How about this: would you mind if ThreadPool were modified to still populate > these attributes for monitoring and debugging purposes, but completely > stopped honoring any destructive operations on them? In the case of > "pool.q", there is no sing

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-26 Thread Glyph
On Sep 25, 2014, at 6:36 PM, weykent wrote: > On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz wrote: > >> So, does anyone out there have any code which makes use of the >> aforementioned bad attributes of ThreadPool, whose applications would break >> if I removed them? > > Yes. Specifically, I

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-25 Thread weykent
On Sep 25, 2014, at 3:31 PM, Glyph Lefkowitz wrote: > So, does anyone out there have any code which makes use of the aforementioned > bad attributes of ThreadPool, whose applications would break if I removed > them? Yes. Specifically, I am maintaining this AMP responder method: @FetchThre

[Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

2014-09-25 Thread Glyph Lefkowitz
Hi all, (For those of you wondering about the subject, note that this message is sent in compliance with This email sent in compliance with .) I've been trying to improve the reliability of the buildbots