Re: [Twisted-Python] Handling upstream patches

2015-10-20 Thread Gavin Panella
On 20 October 2015 at 00:20, Glyph Lefkowitz wrote: > The spam filter has been re-set, and I don't see any items in the > monitoring queue. Did you try to re-submit it recently and get denied? I was denied the once and I didn't immediately retry. I resubmitted the patch later in the day and it wa

Re: [Twisted-Python] Handling upstream patches

2015-10-19 Thread Glyph Lefkowitz
> On Oct 19, 2015, at 3:22 AM, Gavin Panella wrote: > > On 18 October 2015 at 22:47, Glyph Lefkowitz wrote: > [...] >> I'd still prefer that we just accept patches consistently through one >> mechanism. Forgetting about the license question for a second, >> although today the review queue happe

Re: [Twisted-Python] Handling upstream patches

2015-10-19 Thread Gavin Panella
On 18 October 2015 at 22:47, Glyph Lefkowitz wrote: [...] > I'd still prefer that we just accept patches consistently through one > mechanism. Forgetting about the license question for a second, > although today the review queue happens to be empty (!!!), a patch > needs a champion willing to resp

Re: [Twisted-Python] Handling upstream patches

2015-10-18 Thread Glyph Lefkowitz
> On Oct 18, 2015, at 6:10 AM, Gavin Panella wrote: > > On 16 October 2015 at 17:50, Glyph Lefkowitz wrote: > [...] >> Canonical's IP policy is weird, and it is not clear to me that a patch >> necessarily has to be MIT licensed to be accepted into Ubuntu's >> Twisted, since Ubuntu itself is a c

Re: [Twisted-Python] Handling upstream patches

2015-10-18 Thread Gavin Panella
On 16 October 2015 at 17:50, Glyph Lefkowitz wrote: [...] > Canonical's IP policy is weird, and it is not clear to me that a patch > necessarily has to be MIT licensed to be accepted into Ubuntu's > Twisted, since Ubuntu itself is a commercial work. Instinctively I would assume that Ubuntu would

Re: [Twisted-Python] Handling upstream patches

2015-10-16 Thread Glyph Lefkowitz
> On Oct 16, 2015, at 6:23 AM, Gavin Panella wrote: > > On 16 October 2015 at 12:07, Adi Roiban wrote: >> As a Twisted committer do I need to care about LP / Ubuntu upstream patches? >> >> Does Twisted has a follow-up process so that upstream patches are >> applied in trunk? > > I think we (t

Re: [Twisted-Python] Handling upstream patches

2015-10-16 Thread Gavin Panella
On 16 October 2015 at 12:07, Adi Roiban wrote: > As a Twisted committer do I need to care about LP / Ubuntu upstream patches? > > Does Twisted has a follow-up process so that upstream patches are > applied in trunk? I think we (the MAAS team) should propose our patch for inclusion into Twisted.

[Twisted-Python] Handling upstream patches

2015-10-16 Thread Adi Roiban
Hi, I have received notification for the following LP/Ubuntu issues https://bugs.launchpad.net/ubuntu/+source/twisted/+bug/1505748 https://bugs.launchpad.net/maas/+bug/1504971 -- I think that they are related to http://twistedmatrix.com/trac/ticket/7650 --- As a Twisted committer do